From f178f5cb87fdcf60b51b90a5ccfefaf5a9da356c Mon Sep 17 00:00:00 2001 From: Danilo Leal Date: Sat, 23 Aug 2025 09:57:17 -0300 Subject: [PATCH] Allow edit cards to collapse --- crates/agent_ui/src/acp/thread_view.rs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/crates/agent_ui/src/acp/thread_view.rs b/crates/agent_ui/src/acp/thread_view.rs index 8fc91e0083..9e5d9196f3 100644 --- a/crates/agent_ui/src/acp/thread_view.rs +++ b/crates/agent_ui/src/acp/thread_view.rs @@ -1686,6 +1686,7 @@ impl AcpThreadView { tool_call.status, ToolCallStatus::Rejected | ToolCallStatus::Canceled | ToolCallStatus::Failed ); + let needs_confirmation = matches!( tool_call.status, ToolCallStatus::WaitingForConfirmation { .. } @@ -1693,11 +1694,8 @@ impl AcpThreadView { let is_edit = matches!(tool_call.kind, acp::ToolKind::Edit) || tool_call.diffs().next().is_some(); let use_card_layout = needs_confirmation || is_edit; - - let is_collapsible = !tool_call.content.is_empty() && !use_card_layout; - - let is_open = - needs_confirmation || is_edit || self.expanded_tool_calls.contains(&tool_call.id); + let is_collapsible = !tool_call.content.is_empty() && !needs_confirmation; + let is_open = needs_confirmation || self.expanded_tool_calls.contains(&tool_call.id); let gradient_overlay = |color: Hsla| { div()