Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Allow server to see client disconnection before giving up on reconnecting

Browse source
This commit is contained in:
Antonio Scandurra 2022-12-13 12:17:21 +01:00
parent 417db95693
commit f1884d608b
1 changed files with 38 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

69
crates/call/src/room.rs
View file

@ -264,45 +264,52 @@ impl Room {
}); });
// Wait for client to re-establish a connection to the server. // Wait for client to re-establish a connection to the server.
let mut reconnection_timeout = cx.background().timer(RECONNECT_TIMEOUT).fuse(); {
let client_reconnection = async { let mut reconnection_timeout = cx.background().timer(RECONNECT_TIMEOUT).fuse();
loop { let client_reconnection = async {
if let Some(status) = client_status.next().await { let mut remaining_attempts = 3;
if status.is_connected() { while remaining_attempts > 0 {
return true; if let Some(status) = client_status.next().await {
if status.is_connected() {
let rejoin_room = async {
let response =
client.request(proto::JoinRoom { id: room_id }).await?;
let room_proto =
response.room.ok_or_else(|| anyhow!("invalid room"))?;
this.upgrade(&cx)
.ok_or_else(|| anyhow!("room was dropped"))?
.update(&mut cx, |this, cx| {
this.status = RoomStatus::Online;
this.apply_room_update(room_proto, cx)
})?;
anyhow::Ok(())
};
if rejoin_room.await.is_ok() {
return true;
} else {
remaining_attempts -= 1;
}
}
} else {
return false;
} }
} else {
return false;
} }
false
} }
} .fuse();
.fuse(); futures::pin_mut!(client_reconnection);
futures::pin_mut!(client_reconnection);
futures::select_biased! { futures::select_biased! {
reconnected = client_reconnection => { reconnected = client_reconnection => {
if reconnected { if reconnected {
// Client managed to reconnect to the server. Now attempt to join the room. // If we successfully joined the room, go back around the loop
let rejoin_room = async { // waiting for future connection status changes.
let response = client.request(proto::JoinRoom { id: room_id }).await?;
let room_proto = response.room.ok_or_else(|| anyhow!("invalid room"))?;
this.upgrade(&cx)
.ok_or_else(|| anyhow!("room was dropped"))?
.update(&mut cx, |this, cx| {
this.status = RoomStatus::Online;
this.apply_room_update(room_proto, cx)
})?;
anyhow::Ok(())
};
// If we successfully joined the room, go back around the loop
// waiting for future connection status changes.
if rejoin_room.await.log_err().is_some() {
continue; continue;
} }
} }
_ = reconnection_timeout => {}
} }
_ = reconnection_timeout => {}
} }
// The client failed to re-establish a connection to the server // The client failed to re-establish a connection to the server