Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve One theme contrasts (#20304)

Browse source 
Closes #5334
Closes #15521 

Improve contrast across the board in default One themes. 

We are currently building out some theme tools to make improvements to
contrast and tweaking themes in general easier, so these should continue
to improve over time.

**Light**

Before | After

![CleanShot 2024-11-06 at 11 26
02@2x](https://github.com/user-attachments/assets/2e5d5649-4131-4d42-accc-9bbcf34defeb)

**Dark**
Before | After

![CleanShot 2024-11-06 at 11 30
26@2x](https://github.com/user-attachments/assets/78bc5134-6113-48fd-b026-88e427c631a3)

**Note 1**: there are more improvements to be made, but this should deal
with the most egregious issues.

Release Notes:

- Improved contrast in default One themes
This commit is contained in:
Nate Butler 2024-11-06 11:56:02 -05:00 • committed by GitHub
parent 449e20de3d
commit f22e56ff42
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 54 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

108
assets/themes/one/one.json
View file

@ -27,15 +27,15 @@
"ghost_element.active": "#454a56ff", "ghost_element.active": "#454a56ff",
"ghost_element.selected": "#454a56ff", "ghost_element.selected": "#454a56ff",
"ghost_element.disabled": "#2e343eff", "ghost_element.disabled": "#2e343eff",
"text": "#c8ccd4ff", "text": "#dce0e5ff",
"text.muted": "#838994ff", "text.muted": "#a9afbcff",
"text.placeholder": "#696B77ff", "text.placeholder": "#878a98ff",
"text.disabled": "#696B77ff", "text.disabled": "#878a98ff",
"text.accent": "#74ade8ff", "text.accent": "#74ade8ff",
"icon": "#c8ccd4ff", "icon": "#dce0e5ff",
"icon.muted": "#838994ff", "icon.muted": "#a9afbcff",
"icon.disabled": "#696B77ff", "icon.disabled": "#878a98ff",
"icon.placeholder": "#838994ff", "icon.placeholder": "#a9afbcff",
"icon.accent": "#74ade8ff", "icon.accent": "#74ade8ff",
"status_bar.background": "#3b414dff", "status_bar.background": "#3b414dff",
"title_bar.background": "#3b414dff", "title_bar.background": "#3b414dff",
@ -60,19 +60,19 @@
"editor.active_line.background": "#2f343ebf", "editor.active_line.background": "#2f343ebf",
"editor.highlighted_line.background": "#2f343eff", "editor.highlighted_line.background": "#2f343eff",
"editor.line_number": "#c8ccd459", "editor.line_number": "#c8ccd459",
"editor.active_line_number": "#c8ccd4ff", "editor.active_line_number": "#dce0e5ff",
"editor.invisible": "#696B77ff", "editor.invisible": "#878a98ff",
"editor.wrap_guide": "#c8ccd40d", "editor.wrap_guide": "#c8ccd40d",
"editor.active_wrap_guide": "#c8ccd41a", "editor.active_wrap_guide": "#c8ccd41a",
"editor.document_highlight.read_background": "#74ade81a", "editor.document_highlight.read_background": "#74ade81a",
"editor.document_highlight.write_background": "#555a6366", "editor.document_highlight.write_background": "#555a6366",
"terminal.background": "#282c33ff", "terminal.background": "#282c33ff",
"terminal.foreground": "#c8ccd4ff", "terminal.foreground": "#dce0e5ff",
"terminal.bright_foreground": "#c8ccd4ff", "terminal.bright_foreground": "#dce0e5ff",
"terminal.dim_foreground": "#282c33ff", "terminal.dim_foreground": "#282c33ff",
"terminal.ansi.black": "#282c33ff", "terminal.ansi.black": "#282c33ff",
"terminal.ansi.bright_black": "#525561ff", "terminal.ansi.bright_black": "#525561ff",
"terminal.ansi.dim_black": "#c8ccd4ff", "terminal.ansi.dim_black": "#dce0e5ff",
"terminal.ansi.red": "#d07277ff", "terminal.ansi.red": "#d07277ff",
"terminal.ansi.bright_red": "#673a3cff", "terminal.ansi.bright_red": "#673a3cff",
"terminal.ansi.dim_red": "#eab7b9ff", "terminal.ansi.dim_red": "#eab7b9ff",
@ -91,8 +91,8 @@
"terminal.ansi.cyan": "#6eb4bfff", "terminal.ansi.cyan": "#6eb4bfff",
"terminal.ansi.bright_cyan": "#3a565bff", "terminal.ansi.bright_cyan": "#3a565bff",
"terminal.ansi.dim_cyan": "#b9d9dfff", "terminal.ansi.dim_cyan": "#b9d9dfff",
"terminal.ansi.white": "#c8ccd4ff", "terminal.ansi.white": "#dce0e5ff",
"terminal.ansi.bright_white": "#c8ccd4ff", "terminal.ansi.bright_white": "#dce0e5ff",
"terminal.ansi.dim_white": "#575d65ff", "terminal.ansi.dim_white": "#575d65ff",
"link_text.hover": "#74ade8ff", "link_text.hover": "#74ade8ff",
"conflict": "#dec184ff", "conflict": "#dec184ff",
@ -107,14 +107,14 @@
"error": "#d07277ff", "error": "#d07277ff",
"error.background": "#d072771a", "error.background": "#d072771a",
"error.border": "#4c2b2cff", "error.border": "#4c2b2cff",
"hidden": "#696B77ff", "hidden": "#878a98ff",
"hidden.background": "#696B771a", "hidden.background": "#696b771a",
"hidden.border": "#414754ff", "hidden.border": "#414754ff",
"hint": "#5a6f89ff", "hint": "#788ca6ff",
"hint.background": "#5a6f891a", "hint.background": "#5a6f891a",
"hint.border": "#293b5bff", "hint.border": "#293b5bff",
"ignored": "#696B77ff", "ignored": "#878a98ff",
"ignored.background": "#696B771a", "ignored.background": "#696b771a",
"ignored.border": "#464b57ff", "ignored.border": "#464b57ff",
"info": "#74ade8ff", "info": "#74ade8ff",
"info.background": "#74ade81a", "info.background": "#74ade81a",
@ -131,7 +131,7 @@
"success": "#a1c181ff", "success": "#a1c181ff",
"success.background": "#a1c1811a", "success.background": "#a1c1811a",
"success.border": "#38482fff", "success.border": "#38482fff",
"unreachable": "#838994ff", "unreachable": "#a9afbcff",
"unreachable.background": "#8389941a", "unreachable.background": "#8389941a",
"unreachable.border": "#464b57ff", "unreachable.border": "#464b57ff",
"warning": "#dec184ff", "warning": "#dec184ff",
@ -211,7 +211,7 @@
"font_weight": null "font_weight": null
}, },
"embedded": { "embedded": {
"color": "#c8ccd4ff", "color": "#dce0e5ff",
"font_style": null, "font_style": null,
"font_weight": null "font_weight": null
}, },
@ -236,7 +236,7 @@
"font_weight": null "font_weight": null
}, },
"hint": { "hint": {
"color": "#5a6f89ff", "color": "#788ca6ff",
"font_style": null, "font_style": null,
"font_weight": 700 "font_weight": 700
}, },
@ -276,7 +276,7 @@
"font_weight": null "font_weight": null
}, },
"preproc": { "preproc": {
"color": "#c8ccd4ff", "color": "#dce0e5ff",
"font_style": null, "font_style": null,
"font_weight": null "font_weight": null
}, },
@ -361,7 +361,7 @@
"font_weight": null "font_weight": null
}, },
"variable": { "variable": {
"color": "#c8ccd4ff", "color": "#dce0e5ff",
"font_style": null, "font_style": null,
"font_weight": null "font_weight": null
}, },
@ -402,15 +402,15 @@
"ghost_element.active": "#cacacaff", "ghost_element.active": "#cacacaff",
"ghost_element.selected": "#cacacaff", "ghost_element.selected": "#cacacaff",
"ghost_element.disabled": "#ebebecff", "ghost_element.disabled": "#ebebecff",
"text": "#383a41ff", "text": "#242529ff",
"text.muted": "#7e8087ff", "text.muted": "#58585aff",
"text.placeholder": "#a1a1a3ff", "text.placeholder": "#7e8086ff",
"text.disabled": "#a1a1a3ff", "text.disabled": "#7e8086ff",
"text.accent": "#5c78e2ff", "text.accent": "#5c78e2ff",
"icon": "#383a41ff", "icon": "#242529ff",
"icon.muted": "#7e8087ff", "icon.muted": "#58585aff",
"icon.disabled": "#a1a1a3ff", "icon.disabled": "#7e8086ff",
"icon.placeholder": "#7e8087ff", "icon.placeholder": "#58585aff",
"icon.accent": "#5c78e2ff", "icon.accent": "#5c78e2ff",
"status_bar.background": "#dcdcddff", "status_bar.background": "#dcdcddff",
"title_bar.background": "#dcdcddff", "title_bar.background": "#dcdcddff",
@ -428,26 +428,26 @@
"scrollbar.thumb.border": "#dfdfe0ff", "scrollbar.thumb.border": "#dfdfe0ff",
"scrollbar.track.background": "#00000000", "scrollbar.track.background": "#00000000",
"scrollbar.track.border": "#eeeeeeff", "scrollbar.track.border": "#eeeeeeff",
"editor.foreground": "#383a41ff", "editor.foreground": "#242529ff",
"editor.background": "#fafafaff", "editor.background": "#fafafaff",
"editor.gutter.background": "#fafafaff", "editor.gutter.background": "#fafafaff",
"editor.subheader.background": "#ebebecff", "editor.subheader.background": "#ebebecff",
"editor.active_line.background": "#ebebecbf", "editor.active_line.background": "#ebebecbf",
"editor.highlighted_line.background": "#ebebecff", "editor.highlighted_line.background": "#ebebecff",
"editor.line_number": "#383a4159", "editor.line_number": "#383a4159",
"editor.active_line_number": "#383a41ff", "editor.active_line_number": "#242529ff",
"editor.invisible": "#a3a3a4ff", "editor.invisible": "#a3a3a4ff",
"editor.wrap_guide": "#383a410d", "editor.wrap_guide": "#383a410d",
"editor.active_wrap_guide": "#383a411a", "editor.active_wrap_guide": "#383a411a",
"editor.document_highlight.read_background": "#5c78e21a", "editor.document_highlight.read_background": "#5c78e21a",
"editor.document_highlight.write_background": "#a3a3a466", "editor.document_highlight.write_background": "#a3a3a466",
"terminal.background": "#fafafaff", "terminal.background": "#fafafaff",
"terminal.foreground": "#383a41ff", "terminal.foreground": "#242529ff",
"terminal.bright_foreground": "#383a41ff", "terminal.bright_foreground": "#242529ff",
"terminal.dim_foreground": "#fafafaff", "terminal.dim_foreground": "#fafafaff",
"terminal.ansi.black": "#fafafaff", "terminal.ansi.black": "#fafafaff",
"terminal.ansi.bright_black": "#aaaaaaff", "terminal.ansi.bright_black": "#aaaaaaff",
"terminal.ansi.dim_black": "#383a41ff", "terminal.ansi.dim_black": "#242529ff",
"terminal.ansi.red": "#d36151ff", "terminal.ansi.red": "#d36151ff",
"terminal.ansi.bright_red": "#f0b0a4ff", "terminal.ansi.bright_red": "#f0b0a4ff",
"terminal.ansi.dim_red": "#6f312aff", "terminal.ansi.dim_red": "#6f312aff",
@ -466,11 +466,11 @@
"terminal.ansi.cyan": "#3a82b7ff", "terminal.ansi.cyan": "#3a82b7ff",
"terminal.ansi.bright_cyan": "#a3bedaff", "terminal.ansi.bright_cyan": "#a3bedaff",
"terminal.ansi.dim_cyan": "#254058ff", "terminal.ansi.dim_cyan": "#254058ff",
"terminal.ansi.white": "#383a41ff", "terminal.ansi.white": "#242529ff",
"terminal.ansi.bright_white": "#383a41ff", "terminal.ansi.bright_white": "#242529ff",
"terminal.ansi.dim_white": "#97979aff", "terminal.ansi.dim_white": "#97979aff",
"link_text.hover": "#5c78e2ff", "link_text.hover": "#5c78e2ff",
"conflict": "#dec184ff", "conflict": "#a48819ff",
"conflict.background": "#faf2e6ff", "conflict.background": "#faf2e6ff",
"conflict.border": "#f4e7d1ff", "conflict.border": "#f4e7d1ff",
"created": "#669f59ff", "created": "#669f59ff",
@ -482,19 +482,19 @@
"error": "#d36151ff", "error": "#d36151ff",
"error.background": "#fbdfd9ff", "error.background": "#fbdfd9ff",
"error.border": "#f6c6bdff", "error.border": "#f6c6bdff",
"hidden": "#a1a1a3ff", "hidden": "#7e8086ff",
"hidden.background": "#dcdcddff", "hidden.background": "#dcdcddff",
"hidden.border": "#d3d3d4ff", "hidden.border": "#d3d3d4ff",
"hint": "#9294beff", "hint": "#7274a7ff",
"hint.background": "#e2e2faff", "hint.background": "#e2e2faff",
"hint.border": "#cbcdf6ff", "hint.border": "#cbcdf6ff",
"ignored": "#a1a1a3ff", "ignored": "#7e8086ff",
"ignored.background": "#dcdcddff", "ignored.background": "#dcdcddff",
"ignored.border": "#c9c9caff", "ignored.border": "#c9c9caff",
"info": "#5c78e2ff", "info": "#5c78e2ff",
"info.background": "#e2e2faff", "info.background": "#e2e2faff",
"info.border": "#cbcdf6ff", "info.border": "#cbcdf6ff",
"modified": "#a47a23ff", "modified": "#a48819ff",
"modified.background": "#faf2e6ff", "modified.background": "#faf2e6ff",
"modified.border": "#f4e7d1ff", "modified.border": "#f4e7d1ff",
"predictive": "#9b9ec6ff", "predictive": "#9b9ec6ff",
@ -506,10 +506,10 @@
"success": "#669f59ff", "success": "#669f59ff",
"success.background": "#dfeadbff", "success.background": "#dfeadbff",
"success.border": "#c8dcc1ff", "success.border": "#c8dcc1ff",
"unreachable": "#7e8087ff", "unreachable": "#58585aff",
"unreachable.background": "#dcdcddff", "unreachable.background": "#dcdcddff",
"unreachable.border": "#c9c9caff", "unreachable.border": "#c9c9caff",
"warning": "#dec184ff", "warning": "#a48819ff",
"warning.background": "#faf2e6ff", "warning.background": "#faf2e6ff",
"warning.border": "#f4e7d1ff", "warning.border": "#f4e7d1ff",
"players": [ "players": [
@ -544,7 +544,7 @@
"selection": "#d361513d" "selection": "#d361513d"
}, },
{ {
"cursor": "#dec184ff", "cursor": "#a48819ff",
"background": "#dec184ff", "background": "#dec184ff",
"selection": "#dec1843d" "selection": "#dec1843d"
}, },
@ -586,7 +586,7 @@
"font_weight": null "font_weight": null
}, },
"embedded": { "embedded": {
"color": "#383a41ff", "color": "#242529ff",
"font_style": null, "font_style": null,
"font_weight": null "font_weight": null
}, },
@ -611,7 +611,7 @@
"font_weight": null "font_weight": null
}, },
"hint": { "hint": {
"color": "#9294beff", "color": "#7274a7ff",
"font_style": null, "font_style": null,
"font_weight": 700 "font_weight": 700
}, },
@ -651,12 +651,12 @@
"font_weight": null "font_weight": null
}, },
"preproc": { "preproc": {
"color": "#383a41ff", "color": "#242529ff",
"font_style": null, "font_style": null,
"font_weight": null "font_weight": null
}, },
"primary": { "primary": {
"color": "#383a41ff", "color": "#242529ff",
"font_style": null, "font_style": null,
"font_weight": null "font_weight": null
}, },
@ -666,7 +666,7 @@
"font_weight": null "font_weight": null
}, },
"punctuation": { "punctuation": {
"color": "#383a41ff", "color": "#242529ff",
"font_style": null, "font_style": null,
"font_weight": null "font_weight": null
}, },
@ -736,7 +736,7 @@
"font_weight": null "font_weight": null
}, },
"variable": { "variable": {
"color": "#383a41ff", "color": "#242529ff",
"font_style": null, "font_style": null,
"font_weight": null "font_weight": null
}, },