Return optional transaction ids from undo/redo

This will allow the editor to restore selections that it associated with the start or end of a transaction.
This commit is contained in:
Nathan Sobo 2021-12-10 18:08:26 -07:00
parent 77defe6e28
commit f35c419f43
3 changed files with 32 additions and 18 deletions

View file

@ -224,14 +224,14 @@ impl MultiBuffer {
}) })
} }
pub fn undo(&mut self, cx: &mut ModelContext<Self>) { pub fn undo(&mut self, cx: &mut ModelContext<Self>) -> Option<TransactionId> {
// TODO // TODO
self.as_singleton() self.as_singleton()
.unwrap() .unwrap()
.update(cx, |buffer, cx| buffer.undo(cx)) .update(cx, |buffer, cx| buffer.undo(cx))
} }
pub fn redo(&mut self, cx: &mut ModelContext<Self>) { pub fn redo(&mut self, cx: &mut ModelContext<Self>) -> Option<TransactionId> {
// TODO // TODO
self.as_singleton() self.as_singleton()
.unwrap() .unwrap()

View file

@ -1443,26 +1443,34 @@ impl Buffer {
cx.notify(); cx.notify();
} }
pub fn undo(&mut self, cx: &mut ModelContext<Self>) { pub fn undo(&mut self, cx: &mut ModelContext<Self>) -> Option<TransactionId> {
let was_dirty = self.is_dirty(); let was_dirty = self.is_dirty();
let old_version = self.version.clone(); let old_version = self.version.clone();
for operation in self.text.undo() { if let Some((transaction_id, operations)) = self.text.undo() {
for operation in operations {
self.send_operation(Operation::Buffer(operation), cx); self.send_operation(Operation::Buffer(operation), cx);
} }
self.did_edit(&old_version, was_dirty, cx); self.did_edit(&old_version, was_dirty, cx);
Some(transaction_id)
} else {
None
}
} }
pub fn redo(&mut self, cx: &mut ModelContext<Self>) { pub fn redo(&mut self, cx: &mut ModelContext<Self>) -> Option<TransactionId> {
let was_dirty = self.is_dirty(); let was_dirty = self.is_dirty();
let old_version = self.version.clone(); let old_version = self.version.clone();
for operation in self.text.redo() { if let Some((transaction_id, operations)) = self.text.redo() {
for operation in operations {
self.send_operation(Operation::Buffer(operation), cx); self.send_operation(Operation::Buffer(operation), cx);
} }
self.did_edit(&old_version, was_dirty, cx); self.did_edit(&old_version, was_dirty, cx);
Some(transaction_id)
} else {
None
}
} }
} }

View file

@ -1221,28 +1221,34 @@ impl Buffer {
self.history.ops.values() self.history.ops.values()
} }
pub fn undo(&mut self) -> Vec<Operation> { pub fn undo(&mut self) -> Option<(TransactionId, Vec<Operation>)> {
let mut ops = Vec::new();
if let Some(transaction) = self.history.pop_undo().cloned() { if let Some(transaction) = self.history.pop_undo().cloned() {
let transaction_id = transaction.id;
let selections = transaction.selections_before.clone(); let selections = transaction.selections_before.clone();
let mut ops = Vec::new();
ops.push(self.undo_or_redo(transaction).unwrap()); ops.push(self.undo_or_redo(transaction).unwrap());
for (set_id, selections) in selections { for (set_id, selections) in selections {
ops.extend(self.restore_selection_set(set_id, selections)); ops.extend(self.restore_selection_set(set_id, selections));
} }
Some((transaction_id, ops))
} else {
None
} }
ops
} }
pub fn redo(&mut self) -> Vec<Operation> { pub fn redo(&mut self) -> Option<(TransactionId, Vec<Operation>)> {
let mut ops = Vec::new();
if let Some(transaction) = self.history.pop_redo().cloned() { if let Some(transaction) = self.history.pop_redo().cloned() {
let transaction_id = transaction.id;
let selections = transaction.selections_after.clone(); let selections = transaction.selections_after.clone();
let mut ops = Vec::new();
ops.push(self.undo_or_redo(transaction).unwrap()); ops.push(self.undo_or_redo(transaction).unwrap());
for (set_id, selections) in selections { for (set_id, selections) in selections {
ops.extend(self.restore_selection_set(set_id, selections)); ops.extend(self.restore_selection_set(set_id, selections));
} }
Some((transaction_id, ops))
} else {
None
} }
ops
} }
fn undo_or_redo(&mut self, transaction: Transaction) -> Result<Operation> { fn undo_or_redo(&mut self, transaction: Transaction) -> Result<Operation> {