From f3b7f5944d9acf324d8dd93b436bf6e60675c45b Mon Sep 17 00:00:00 2001 From: Mikayla Maki Date: Tue, 29 Oct 2024 12:30:55 -0700 Subject: [PATCH] Fix a rare crash on startup (#19922) Release Notes: - Fixed a rare crash that could happen when certain SQL statements are prepared --- crates/sqlez/src/statement.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/sqlez/src/statement.rs b/crates/sqlez/src/statement.rs index 462f902239..f1d89919ec 100644 --- a/crates/sqlez/src/statement.rs +++ b/crates/sqlez/src/statement.rs @@ -58,13 +58,13 @@ impl<'a> Statement<'a> { &mut remaining_sql_ptr, ); - remaining_sql = CStr::from_ptr(remaining_sql_ptr); - statement.raw_statements.push(raw_statement); - connection.last_error().with_context(|| { format!("Prepare call failed for query:\n{}", query.as_ref()) })?; + remaining_sql = CStr::from_ptr(remaining_sql_ptr); + statement.raw_statements.push(raw_statement); + if !connection.can_write() && sqlite3_stmt_readonly(raw_statement) == 0 { let sql = CStr::from_ptr(sqlite3_sql(raw_statement));