Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

preview tabs: Support find all references (#10470)

Browse source 
`FindAllReferences` will now open a preview tab, jumping to a definition
will also open a preview tab.


https://github.com/zed-industries/zed/assets/53836821/fa3db1fd-ccb3-4559-b3d2-b1fe57f86481

Note: One thing I would like to improve here is also adding support for
reopening `FindAllReferences` using the navigation history. As of now
the navigation history is lacking support for reopening items other then
project files, which needs to be implemented first.

Release Notes:

- N/A
This commit is contained in:
Bennet Bo Fenner 2024-04-12 17:22:12 +02:00 • committed by GitHub
parent 7b01a29f5a
commit f4d9a97195
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

16
crates/editor/src/editor.rs
View file

@ -129,6 +129,7 @@ use ui::{
Tooltip, Tooltip,
}; };
use util::{defer, maybe, post_inc, RangeExt, ResultExt, TryFutureExt}; use util::{defer, maybe, post_inc, RangeExt, ResultExt, TryFutureExt};
use workspace::item::ItemHandle;
use workspace::notifications::NotificationId; use workspace::notifications::NotificationId;
use workspace::Toast; use workspace::Toast;
use workspace::{ use workspace::{
@ -8002,11 +8003,16 @@ impl Editor {
cx, cx,
); );
}); });
let item = Box::new(editor);
if split { if split {
workspace.split_item(SplitDirection::Right, Box::new(editor), cx); workspace.split_item(SplitDirection::Right, item.clone(), cx);
} else { } else {
workspace.add_item_to_active_pane(Box::new(editor), cx); workspace.add_item_to_active_pane(item.clone(), cx);
} }
workspace.active_pane().clone().update(cx, |pane, cx| {
let item_id = item.item_id();
pane.set_preview_item_id(Some(item_id), cx);
});
} }
pub fn rename(&mut self, _: &Rename, cx: &mut ViewContext<Self>) -> Option<Task<Result<()>>> { pub fn rename(&mut self, _: &Rename, cx: &mut ViewContext<Self>) -> Option<Task<Result<()>>> {
@ -9521,7 +9527,11 @@ impl Editor {
cx.spawn(|_, mut cx| async move { cx.spawn(|_, mut cx| async move {
let workspace = workspace.ok_or_else(|| anyhow!("cannot jump without workspace"))?; let workspace = workspace.ok_or_else(|| anyhow!("cannot jump without workspace"))?;
let editor = workspace.update(&mut cx, |workspace, cx| { let editor = workspace.update(&mut cx, |workspace, cx| {
workspace.open_path(path, None, true, cx) // Reset the preview item id before opening the new item
workspace.active_pane().update(cx, |pane, cx| {
pane.set_preview_item_id(None, cx);
});
workspace.open_path_preview(path, None, true, true, cx)
})?; })?;
let editor = editor let editor = editor
.await? .await?