Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

debugger: Fix panics when debugging with inline values or confirming in console (#30677)

Browse source 
The first panic was caused by an unwrap that assumed a file would always
have a root syntax node.

The second was caused by a double lease panic when clicking enter in the
debug console while there was a completion menu open

Release Notes:

- N/A
This commit is contained in:
Anthony Eid 2025-05-14 11:50:42 +02:00 • committed by GitHub
parent ed361ff6a2
commit f4eea0db2e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
crates/debugger_ui/src/session/running/console.rs
View file

@ -150,8 +150,9 @@ impl Console {
pub fn evaluate(&mut self, _: &Confirm, window: &mut Window, cx: &mut Context<Self>) { pub fn evaluate(&mut self, _: &Confirm, window: &mut Window, cx: &mut Context<Self>) {
let expression = self.query_bar.update(cx, |editor, cx| { let expression = self.query_bar.update(cx, |editor, cx| {
let expression = editor.text(cx); let expression = editor.text(cx);
cx.defer_in(window, |editor, window, cx| {
editor.clear(window, cx); editor.clear(window, cx);
});
expression expression
}); });

4
crates/project/src/project.rs
View file

@ -3580,7 +3580,9 @@ impl Project {
let snapshot = buffer_handle.read(cx).snapshot(); let snapshot = buffer_handle.read(cx).snapshot();
let root_node = snapshot.syntax_root_ancestor(range.end).unwrap(); let Some(root_node) = snapshot.syntax_root_ancestor(range.end) else {
return Task::ready(Ok(vec![]));
};
let row = snapshot let row = snapshot
.summary_for_anchor::<text::PointUtf16>(&range.end) .summary_for_anchor::<text::PointUtf16>(&range.end)