Clean up some stray todos (#11380)
Quick little todo comment cleanups, either because they aren't needed or a comment will suffice. Release Notes: - N/A
This commit is contained in:
parent
15299dcf80
commit
f576bd3aaf
4 changed files with 1 additions and 7 deletions
|
@ -110,7 +110,6 @@ impl AssistantPanel {
|
|||
let user_store = app_state.user_store.clone();
|
||||
|
||||
cx.new_view(|cx| {
|
||||
// todo!("this will panic if the semantic index failed to load or has not loaded yet")
|
||||
let project_index = cx.update_global(|semantic_index: &mut SemanticIndex, cx| {
|
||||
semantic_index.project_index(project.clone(), cx)
|
||||
});
|
||||
|
@ -819,9 +818,7 @@ impl AssistantChat {
|
|||
});
|
||||
|
||||
for tool_call in tool_calls {
|
||||
// todo!(): we should not be sending when the tool is still running / has no result
|
||||
// For now I'm going to have to assume we send an empty string because otherwise
|
||||
// the Chat API will break -- there is a required message for every tool call by ID
|
||||
// Every tool call _must_ have a result by ID, otherwise OpenAI will error.
|
||||
let content = match &tool_call.result {
|
||||
Some(result) => result.format(&tool_call.name),
|
||||
None => "".to_string(),
|
||||
|
|
|
@ -160,7 +160,6 @@ impl Render for FileAttachmentView {
|
|||
})
|
||||
.into_any_element()
|
||||
}
|
||||
// todo!(): show a better error view when the file attaching didn't work
|
||||
Err(err) => div().child(err.to_string()).into_any_element(),
|
||||
}
|
||||
}
|
||||
|
|
|
@ -78,7 +78,6 @@ impl Database {
|
|||
.await?;
|
||||
|
||||
// todo! check user is a project-collaborator
|
||||
|
||||
let room = self.get_room(room_id, &tx).await?;
|
||||
return Ok((project.id, room));
|
||||
}
|
||||
|
|
|
@ -74,7 +74,6 @@ impl InlineCompletionProvider for SupermavenCompletionProvider {
|
|||
_direction: Direction,
|
||||
_cx: &mut ModelContext<Self>,
|
||||
) {
|
||||
// todo!("cycling")
|
||||
}
|
||||
|
||||
fn accept(&mut self, _cx: &mut ModelContext<Self>) {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue