Clean up some stray todos (#11380)

Quick little todo comment cleanups, either because they aren't needed or
a comment will suffice.

Release Notes:

- N/A
This commit is contained in:
Kyle Kelley 2024-05-03 16:17:56 -07:00 committed by GitHub
parent 15299dcf80
commit f576bd3aaf
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 1 additions and 7 deletions

View file

@ -110,7 +110,6 @@ impl AssistantPanel {
let user_store = app_state.user_store.clone(); let user_store = app_state.user_store.clone();
cx.new_view(|cx| { cx.new_view(|cx| {
// todo!("this will panic if the semantic index failed to load or has not loaded yet")
let project_index = cx.update_global(|semantic_index: &mut SemanticIndex, cx| { let project_index = cx.update_global(|semantic_index: &mut SemanticIndex, cx| {
semantic_index.project_index(project.clone(), cx) semantic_index.project_index(project.clone(), cx)
}); });
@ -819,9 +818,7 @@ impl AssistantChat {
}); });
for tool_call in tool_calls { for tool_call in tool_calls {
// todo!(): we should not be sending when the tool is still running / has no result // Every tool call _must_ have a result by ID, otherwise OpenAI will error.
// For now I'm going to have to assume we send an empty string because otherwise
// the Chat API will break -- there is a required message for every tool call by ID
let content = match &tool_call.result { let content = match &tool_call.result {
Some(result) => result.format(&tool_call.name), Some(result) => result.format(&tool_call.name),
None => "".to_string(), None => "".to_string(),

View file

@ -160,7 +160,6 @@ impl Render for FileAttachmentView {
}) })
.into_any_element() .into_any_element()
} }
// todo!(): show a better error view when the file attaching didn't work
Err(err) => div().child(err.to_string()).into_any_element(), Err(err) => div().child(err.to_string()).into_any_element(),
} }
} }

View file

@ -78,7 +78,6 @@ impl Database {
.await?; .await?;
// todo! check user is a project-collaborator // todo! check user is a project-collaborator
let room = self.get_room(room_id, &tx).await?; let room = self.get_room(room_id, &tx).await?;
return Ok((project.id, room)); return Ok((project.id, room));
} }

View file

@ -74,7 +74,6 @@ impl InlineCompletionProvider for SupermavenCompletionProvider {
_direction: Direction, _direction: Direction,
_cx: &mut ModelContext<Self>, _cx: &mut ModelContext<Self>,
) { ) {
// todo!("cycling")
} }
fn accept(&mut self, _cx: &mut ModelContext<Self>) { fn accept(&mut self, _cx: &mut ModelContext<Self>) {