Pass hold: true to Alacritty for tasks (#13898)

It seems `hold: false` causes alacritty to close the channel earlier,
without waiting for the output from the child command to go to Zed.

Fixes [#13683](https://github.com/zed-industries/zed/issues/13683)

Release Notes:

- Fixed loosing output of a spawned task
([#13683](https://github.com/zed-industries/zed/issues/13683)).

[Screencast from 2024-07-06
18-28-56.webm](https://github.com/zed-industries/zed/assets/39293/4ebef8b5-7c0d-46be-9341-4ac0d809458d)
This commit is contained in:
Aleksei Gusev 2024-07-11 17:50:00 +03:00 committed by GitHub
parent 45c54d189a
commit f61abe0247
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 93 additions and 6 deletions

View file

@ -340,7 +340,7 @@ impl TerminalBuilder {
alacritty_terminal::tty::Options {
shell: alac_shell,
working_directory: working_directory.clone(),
hold: false,
hold: !matches!(shell.clone(), Shell::System),
env: env.into_iter().collect(),
}
};