Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

keymap_ui: Don't try to parse empty action arguments as JSON (#36278)

Browse source 
Closes #ISSUE

Release Notes:

- Keymap Editor: Fixed an issue where leaving the arguments field empty
would result in an error even if arguments were optional
This commit is contained in:
Ben Kunkle 2025-08-15 16:59:57 -05:00 • committed by GitHub
parent 3d77ad7e1a
commit f642f7615f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
crates/settings_ui/src/keybindings.rs
View file

@ -2181,6 +2181,7 @@ impl KeybindingEditorModal {
let value = action_arguments let value = action_arguments
.as_ref() .as_ref()
.filter(|args| !args.is_empty())
.map(|args| { .map(|args| {
serde_json::from_str(args).context("Failed to parse action arguments as JSON") serde_json::from_str(args).context("Failed to parse action arguments as JSON")
}) })