Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not log unfinished tools use that are in the middle of streaming (#29275)

Browse source 
Release Notes:

- N/A
This commit is contained in:
Oleksiy Syvokon 2025-04-23 16:19:01 +03:00 • committed by GitHub
parent d5f3fbdc88
commit f69aeb6311
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
crates/eval/src/instance.rs
View file

@ -1030,14 +1030,11 @@ impl ThreadDialog {
current_text.push_str(text);
}
// TODO: Tool use is currently broken, both here and in Markdown output.
// Specifically, we get a stream of partial `tool_use` messages,
// each of which gets logged individually. A simple fix is to log
// just the final message, but we also need to make sure that
// this behavior doesn't happen in the actual assistant thread.
Ok(LanguageModelCompletionEvent::ToolUse(tool_use)) => {
flush_text(&mut current_text, &mut content);
content.push(MessageContent::ToolUse(tool_use.clone()));
if tool_use.is_input_complete {
content.push(MessageContent::ToolUse(tool_use.clone()));
}
}
Ok(LanguageModelCompletionEvent::Thinking { text, signature }) => {
flush_text(&mut current_text, &mut content);