Optimize REPL kernel spec refresh (#21844)

Python kernelspec refresh now only performed on (known) python files. 

Release Notes:

- N/A
This commit is contained in:
Kyle Kelley 2024-12-11 06:20:44 -08:00 committed by GitHub
parent ae351298b4
commit f8b6d71670
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 34 additions and 17 deletions

View file

@ -173,7 +173,7 @@ impl ReplStore {
let remote_kernel_specifications = self.get_remote_kernel_specifications(cx);
cx.spawn(|this, mut cx| async move {
let all_specs = cx.background_executor().spawn(async move {
let mut all_specs = local_kernel_specifications
.await?
.into_iter()
@ -186,10 +186,21 @@ impl ReplStore {
}
}
this.update(&mut cx, |this, cx| {
this.kernel_specifications = all_specs;
cx.notify();
})
anyhow::Ok(all_specs)
});
cx.spawn(|this, mut cx| async move {
let all_specs = all_specs.await;
if let Ok(specs) = all_specs {
this.update(&mut cx, |this, cx| {
this.kernel_specifications = specs;
cx.notify();
})
.ok();
}
anyhow::Ok(())
})
}