Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

gpui: Don't panic when failing to exec system opener (#21674)

Browse source
This commit is contained in:
Cole Miller 2024-12-06 22:11:40 -05:00 • committed by GitHub
parent 4d22a07a1e
commit fa7dddd6b5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

10
crates/gpui/src/platform/mac/platform.rs
View file

@ -10,7 +10,7 @@ use crate::{
PlatformTextSystem, PlatformWindow, Result, ScreenCaptureSource, SemanticVersion, Task,
WindowAppearance, WindowParams,
};
use anyhow::anyhow;
use anyhow::{anyhow, Context as _};
use block::ConcreteBlock;
use cocoa::{
appkit::{
@ -57,6 +57,7 @@ use std::{
sync::Arc,
};
use strum::IntoEnumIterator;
use util::ResultExt;
#[allow(non_upper_case_globals)]
const NSUTF8StringEncoding: NSUInteger = 4;
@ -779,15 +780,16 @@ impl Platform for MacPlatform {
}
fn open_with_system(&self, path: &Path) {
let path = path.to_path_buf();
let path = path.to_owned();
self.0
.lock()
.background_executor
.spawn(async move {
std::process::Command::new("open")
let _ = std::process::Command::new("open")
.arg(path)
.spawn()
.expect("Failed to open file");
.context("invoking open command")
.log_err();
})
.detach();
}