From fa96e2259bfdb5cae22642ce69276de520406c22 Mon Sep 17 00:00:00 2001 From: Devzeth <47153906+devzeth@users.noreply.github.com> Date: Sat, 1 Mar 2025 17:22:12 +0100 Subject: [PATCH] paths: Add support for clickable file paths in the Odin language format (#25842) This PR adds support for clickable file paths in the Odin language format. The odin compiler errors use the format `/path/to/file.odin(1:1)`. We didn't recognize this format, making these paths non-clickable in the terminal. Also added tests for this. Release Notes: - Added support for clickable file paths in the Odin language format. --------- Co-authored-by: Peter Tripp --- crates/util/src/paths.rs | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/crates/util/src/paths.rs b/crates/util/src/paths.rs index c2d66b573e..f333f285fd 100644 --- a/crates/util/src/paths.rs +++ b/crates/util/src/paths.rs @@ -165,7 +165,7 @@ pub const FILE_ROW_COLUMN_DELIMITER: char = ':'; const ROW_COL_CAPTURE_REGEX: &str = r"(?x) ([^\(]+)(?: - \((\d+),(\d+)\) # filename(row,column) + \((\d+)[,:](\d+)\) # filename(row,column), filename(row:column) | \((\d+)\)() # filename(row) ) @@ -649,6 +649,14 @@ mod tests { column: None, } ); + assert_eq!( + PathWithPosition::parse_str("/testing/out/src/file_finder.odin(7:15)"), + PathWithPosition { + path: PathBuf::from("/testing/out/src/file_finder.odin"), + row: Some(7), + column: Some(15), + } + ); } #[test]