Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

assistant: Put /search behind a feature flag (#15987)

Browse source 
This PR puts the `/search` slash command behind a feature flag.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2024-08-08 12:33:59 -04:00 • committed by GitHub
parent 8ba5207c6c
commit fbc629df7d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

9
crates/assistant/src/assistant.rs
View file

@ -17,6 +17,7 @@ use client::{proto, Client};
use command_palette_hooks::CommandPaletteFilter; use command_palette_hooks::CommandPaletteFilter;
pub use context::*; pub use context::*;
pub use context_store::*; pub use context_store::*;
use feature_flags::FeatureFlagAppExt;
use fs::Fs; use fs::Fs;
use gpui::{actions, impl_actions, AppContext, Global, SharedString, UpdateGlobal}; use gpui::{actions, impl_actions, AppContext, Global, SharedString, UpdateGlobal};
use indexed_docs::IndexedDocsRegistry; use indexed_docs::IndexedDocsRegistry;
@ -272,7 +273,6 @@ fn register_slash_commands(prompt_builder: Option<Arc<PromptBuilder>>, cx: &mut
slash_command_registry.register_command(symbols_command::OutlineSlashCommand, true); slash_command_registry.register_command(symbols_command::OutlineSlashCommand, true);
slash_command_registry.register_command(tabs_command::TabsSlashCommand, true); slash_command_registry.register_command(tabs_command::TabsSlashCommand, true);
slash_command_registry.register_command(project_command::ProjectSlashCommand, true); slash_command_registry.register_command(project_command::ProjectSlashCommand, true);
slash_command_registry.register_command(search_command::SearchSlashCommand, true);
slash_command_registry.register_command(prompt_command::PromptSlashCommand, true); slash_command_registry.register_command(prompt_command::PromptSlashCommand, true);
slash_command_registry.register_command(default_command::DefaultSlashCommand, true); slash_command_registry.register_command(default_command::DefaultSlashCommand, true);
slash_command_registry.register_command(term_command::TermSlashCommand, true); slash_command_registry.register_command(term_command::TermSlashCommand, true);
@ -286,6 +286,13 @@ fn register_slash_commands(prompt_builder: Option<Arc<PromptBuilder>>, cx: &mut
); );
} }
slash_command_registry.register_command(fetch_command::FetchSlashCommand, false); slash_command_registry.register_command(fetch_command::FetchSlashCommand, false);
cx.observe_flag::<search_command::SearchSlashCommandFeatureFlag, _>(move |is_enabled, _cx| {
if is_enabled {
slash_command_registry.register_command(search_command::SearchSlashCommand, true);
}
})
.detach();
} }
pub fn humanize_token_count(count: usize) -> String { pub fn humanize_token_count(count: usize) -> String {

7
crates/assistant/src/slash_command/search_command.rs
View file

@ -5,6 +5,7 @@ use super::{
}; };
use anyhow::Result; use anyhow::Result;
use assistant_slash_command::{ArgumentCompletion, SlashCommandOutputSection}; use assistant_slash_command::{ArgumentCompletion, SlashCommandOutputSection};
use feature_flags::FeatureFlag;
use gpui::{AppContext, Task, WeakView}; use gpui::{AppContext, Task, WeakView};
use language::{CodeLabel, LineEnding, LspAdapterDelegate}; use language::{CodeLabel, LineEnding, LspAdapterDelegate};
use semantic_index::SemanticIndex; use semantic_index::SemanticIndex;
@ -17,6 +18,12 @@ use ui::{prelude::*, IconName};
use util::ResultExt; use util::ResultExt;
use workspace::Workspace; use workspace::Workspace;
pub(crate) struct SearchSlashCommandFeatureFlag;
impl FeatureFlag for SearchSlashCommandFeatureFlag {
const NAME: &'static str = "search-slash-command";
}
pub(crate) struct SearchSlashCommand; pub(crate) struct SearchSlashCommand;
impl SlashCommand for SearchSlashCommand { impl SlashCommand for SearchSlashCommand {