Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Enable clippy::useless_conversion (#8767)

Browse source 
This PR enables the
[`clippy::useless_conversion`](https://rust-lang.github.io/rust-clippy/master/index.html#/useless_conversion)
rule and fixes the outstanding violations.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2024-03-03 10:22:55 -05:00 • committed by GitHub
parent 20d133322a
commit fe04f69caf
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
30 changed files with 53 additions and 66 deletions
Download patch file Download diff file Expand all files Collapse all files

7
crates/editor/src/scroll/autoscroll.rs
View file

@ -62,7 +62,7 @@ impl Editor {
line_height: Pixels,
cx: &mut ViewContext<Editor>,
) -> bool {
let visible_lines = f32::from(viewport_height / line_height);
let visible_lines = viewport_height / line_height;
let display_map = self.display_map.update(cx, |map, cx| map.snapshot(cx));
let mut scroll_position = self.scroll_manager.scroll_position(&display_map);
let max_scroll_top = if matches!(self.mode, EditorMode::AutoHeight { .. }) {
@ -241,11 +241,10 @@ impl Editor {
let scroll_right = scroll_left + viewport_width;
if target_left < scroll_left {
self.scroll_manager.anchor.offset.x = (target_left / max_glyph_width).into();
self.scroll_manager.anchor.offset.x = target_left / max_glyph_width;
true
} else if target_right > scroll_right {
self.scroll_manager.anchor.offset.x =
((target_right - viewport_width) / max_glyph_width).into();
self.scroll_manager.anchor.offset.x = (target_right - viewport_width) / max_glyph_width;
true
} else {
false