Commit graph

1722 commits

Author SHA1 Message Date
Antonio Scandurra
ce45e1cb4c Panic
- Go to diagnostics view
- Select all occurrences of x_for_display_point via cmd-d
- Park the cursors at the start of the parenthesis
- Hit ctrl-m
2024-03-04 20:11:40 +01:00
Antonio Scandurra
78aaaa8b1e WIP 2024-03-04 19:16:29 +01:00
Antonio Scandurra
2045c83099 Move defer_draw to ElementContext 2024-03-04 15:59:25 +01:00
Antonio Scandurra
f57f6344b4 Introduce AnyElement::deferred_draw and use it in Overlay 2024-03-04 14:33:48 +01:00
Antonio Scandurra
022fada0f2 Fix registration of mouse event listeners by using hitbox 2024-03-02 19:19:12 +01:00
Antonio Scandurra
ba45a04045 Move element states for reused views correctly 2024-03-02 14:08:36 +01:00
Antonio Scandurra
f52d9f8c24 Checkpoint
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2024-03-01 19:15:08 +01:00
Antonio Scandurra
8847f73af5 WIP 2024-03-01 18:21:34 +01:00
Antonio Scandurra
3a7b4de0f5 WIP 2024-03-01 17:12:12 +01:00
Antonio Scandurra
82ec8405d6 WIP 2024-03-01 16:19:33 +01:00
Antonio Scandurra
7b7a046b94 Make occlusion optional in Interactivity 2024-03-01 15:48:54 +01:00
Antonio Scandurra
1ba395a33a Checkpoint
Co-Authored-By: Thorsten <thorsten@zed.dev>
2024-03-01 11:41:52 +01:00
Nathan Sobo
a165e997ba WIP: Compare occlusion ids instead of bounds in mouse listeners 2024-02-29 22:34:17 -07:00
Nathan Sobo
8444b11e76 Checkpoint 2024-02-29 20:31:12 -07:00
Nathan Sobo
609370f9d6 Merge branch 'fix-todo-comments' into fix-hover 2024-02-29 18:15:51 -07:00
Nathan Sobo
2108c764ad Remove ! from todo!() in comments
This practice makes it difficult to locate todo!s in my code when I'm working.
Let's take out the bang if we want to keep doing this.
2024-02-29 17:42:24 -07:00
Nathan Sobo
bdedeab7af Get GPUI compiling with some todos 2024-02-29 17:34:36 -07:00
Antonio Scandurra
542fb5c89a WIP 2024-02-29 18:00:03 +01:00
Antonio Scandurra
0fde56909c WIP 2024-02-29 16:27:19 +01:00
Antonio Scandurra
d75ef8e62d Simplify control flow in view caching 2024-02-29 10:17:11 +01:00
Conrad Irwin
9bd5ebb74b
Revert "Introduce a new ToggleGraphicsProfiler command (#7607)" (#8567)
This reverts commit 0cebf68306.

Although this thing is very cool, it is a top source of crashes.

Example crash:
```
Segmentation fault: 11 on thread 26
  objc_retain +16
  invocation function for block in Overlay::onCommandBufferCommit(id<MTLCommandBuffer>) +60
  MTLDispatchListApply +52
```

Release Notes:

- Removed "Toggle Graphics Profiler" as it crashes too much.
2024-02-28 16:39:51 -07:00
Rom Grk
7f954cbbb8
linux: improve key translation (#8560)
This PR brings linux XKB key translation more in line with the macOS
logic, which fixes quite a few key bindings.
2024-02-28 15:13:02 -08:00
Roman
b76e0d997e
Linux: Rewrite the event loop using calloop (#8314)
This PR unifies the event loop code for Wayland and X11. On Wayland,
blocking dispatch is now used. On X11, the invisible window is no longer
needed.

Release Notes:

- N/A

---------

Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com>
Co-authored-by: Tadeo Kondrak <me@tadeo.ca>
Co-authored-by: Mikayla Maki <mikayla@zed.dev>
Co-authored-by: julia <julia@zed.dev>
2024-02-28 14:59:11 -08:00
Conrad Irwin
014e6f66bb
gpui: Don't impl IntoElement on () (#8555)
Although it's kinda cute, rust makes it too easy to accidentally return
() from a function.

/cc @nathansobo

Release Notes:

- N/A
2024-02-28 15:19:05 -07:00
Antonio Scandurra
f5cd8247d1 WIP 2024-02-28 19:59:49 +01:00
Antonio Scandurra
821960bf14 Rename commit_root to layout
Co-Authored-By: Nathan <nathan@zed.dev>
2024-02-28 19:27:12 +01:00
Antonio Scandurra
57f5f128f3
Fix flickering cursor style when a pane was zoomed (#8546)
Release Notes:

- N/A

Co-authored-by: Max Brunsfeld <max@zed.dev>
2024-02-28 18:50:48 +01:00
Antonio Scandurra
7aba9eb4b7
Introduce a short-term solution for flickering (#8542)
This uses bounds checking alone to determine hover state to avoid
flicker. It's a short-term solution because the rendering is incorrect.
We think this is better than flickering though and buys us some time as
we work on a more robust solution overall.

Release Notes:

- Fixed flickering when hovering.

---------

Co-authored-by: Nathan <nathan@zed.dev>
2024-02-28 17:57:20 +01:00
Antonio Scandurra
0ab1e6f451 WIP 2024-02-28 14:29:59 +01:00
Nathan Sobo
17d736b23d WIP: Move constructor of cursor names to after_layout 2024-02-27 21:18:09 -07:00
Nathan Sobo
6006b171f7 WIP 2024-02-27 20:26:12 -07:00
Nathan Sobo
5790d9ba27 WIP: Rename layout phase methods and give each a state
Shred mode. I don't want to force things to be optional just to account for both phases though.
2024-02-27 20:08:35 -07:00
Nathan Sobo
d5766dc69f Rename element methods 2024-02-27 13:30:40 -07:00
Nathan Sobo
3e5c11dc41 Eliminate with_z_index 2024-02-27 13:19:29 -07:00
Antonio Scandurra
ed1a256f99 Add a new commit_root method 2024-02-27 19:42:15 +01:00
Antonio Scandurra
28e795f2fd WIP: start removing draw as it won't work with the two passes 2024-02-27 18:14:56 +01:00
Antonio Scandurra
98374a70d3 Introduce a new Element::commit_bounds method 2024-02-27 16:09:32 +01:00
Antonio Scandurra
33abbcb535 Simplify DrawableElement and expose AnyElement::downcast_mut 2024-02-27 14:01:44 +01:00
Antonio Scandurra
7481c0d556 Remove Element::element_id method from trait 2024-02-27 13:52:57 +01:00
Antonio Scandurra
a1d5249b8e Fix regression in Div and simplify painting 2024-02-27 13:39:07 +01:00
Antonio Scandurra
21bde9b653 💄 2024-02-27 11:07:39 +01:00
Antonio Scandurra
5183dbb5be Fix remaining compile errors and runtime panics 2024-02-27 10:33:20 +01:00
Nathan Sobo
7c6e6971da WIP: Separate ElementState from FrameState 2024-02-26 23:16:23 -07:00
Nathan Sobo
81b5c74b0e Rename Element::State -> FrameState 2024-02-26 20:42:03 -07:00
Nathan Sobo
47e48e20d3 Checkpoint 2024-02-26 20:27:57 -07:00
Nathan Sobo
4584c5e2b3 WIP 2024-02-26 17:46:56 -07:00
Nathan Sobo
e07c53c27f Checkpoint 2024-02-26 15:44:07 -07:00
Nathan Sobo
e917d1d251 Cherry-pick BoundsTree from a previous attempt 2024-02-26 15:35:09 -07:00
Kirill Bulatov
a0c8debd35
Mention possible run options in the task modal placeholder (#8449)
Release Notes:

- Improved run task modal's placeholder

---------

Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
2024-02-27 00:04:56 +02:00
Julia
d4584a10b6
Tell Wayland compositor we can handle keyboard ver 4 for repeat info (#8446)
Fixes us not getting Wayland key repeat info from the compositor

Release Notes:

- N/A
2024-02-26 15:13:01 -05:00