Conrad Irwin
0c2bc6e553
Fix some international keybindings ( #2957 )
...
This adds primitive interaction with the IME system for keyboard
shortcuts in zed.
- Consult the IME functionality when handling keyboard shortcuts. This
allows you to bind to characters (like " on a Brazillian keybaord, or $
on a Czech keyboard) that aren't typed with an unmodified key.
([#1981 ](https://github.com/zed-industries/community/issues/1981 ))
([#1913 ](https://github.com/zed-industries/community/issues/1913 ))
Co-authored-with: Antonio Scandurra <me@as-cii.com>
2023-09-11 11:56:57 -06:00
Conrad Irwin
e017dc6a5e
Fix ctrl-` on Brazillian too
2023-09-11 11:33:04 -06:00
Conrad Irwin
0a6e577e10
Fix some international keybindings
...
This adds primitive interaction with the IME system for keyboard
shortcuts in zed.
For zed-industries/community#1981
For zed-industroes/community#1913
2023-09-11 10:35:42 -06:00
Nathan Sobo
684db11afd
Use platform API to request mouse position
...
Co-Authored-By: Conrad Irwin <conrad@zed.dev>
2023-08-23 13:10:41 -06:00
Max Brunsfeld
d9ef987b04
Fix AppKit screen coordinate conversion leading to wrong window bounds
2023-08-17 15:23:28 -07:00
Mikayla Maki
40030f32d9
Fix two mouse event bugs ( #2835 )
...
This PR fixes two bugs we discovered in Zed's mouse event handling while
investigating an interesting and mysterious bug we we were seeing, where
spurious `MouseMoved` events would continuously be dispatched after
control-clicking.
Release Notes:
- Fixed a rendering glitch that could occur after control-clicking
certain elements.
2023-08-09 09:04:32 -07:00
Max Brunsfeld
0b93a30821
Terminate synthetic drag state on mouse up w/ ctrl held
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2023-08-08 17:39:45 -07:00
Nathan Sobo
0dc70e6cbf
Rename mac platform Window to MacWindow for clarity
2023-08-08 17:21:06 -06:00
Nathan Sobo
8e49d1419a
Minimize window id usage
2023-08-08 16:38:46 -06:00
Nathan Sobo
afd89b256a
Store AnyWindowHandles instead of usizes
2023-08-08 16:06:53 -06:00
Julia
2e3aa703d9
In macOS platform layer map a ctrl-click to a right click
2023-07-19 15:43:45 -04:00
Antonio Scandurra
318deed25b
Skip key down event if preceded by its key equivalent version
...
Previously, we would only track whether the previous key down event
was a key equivalent. However, this could cause issues when pressing
certain keystrokes in rapid succession, e.g.:
- Pressing `shift-right` (to select a character)
- Pressing a character (with or without `shift` held down)
This would cause GPUI to ignore the second event because it was
preceded by a key equivalent event. With this commit, we track the
last key equivalent event, and skip the key down event only if it
matches the last key equivalent event.
2023-07-07 12:02:08 +02:00
Antonio Scandurra
146809eef0
Merge branch 'main' into panels
2023-05-22 14:10:17 +02:00
Antonio Scandurra
5a8fb18c20
Show workspace only after initializing it
2023-05-19 19:35:00 +02:00
Kirill Bulatov
f12dffa60c
Reintroduce more accesible modal keybindings
...
Brings commit 475fc40923
back
2023-05-11 20:59:10 +03:00
Joseph Lyons
0ab94551f4
Revert "More keybindings in macOs modals with buttons"
...
This reverts commit 1398a12062
.
2023-05-11 11:37:34 -04:00
Kirill Bulatov
1398a12062
More keybindings in macOs modals with buttons
...
Closes https://github.com/zed-industries/community/issues/1095
by forcing the non-Cancel button to get a focus.
Due to the way macOs handles buttons on modals, the focus gain had to be
achieved via certain button addition order, rather than conventional
"setFocus"-ish API, see the related comment for details.
Co-authored-by: Antonio Scandurra <antonio@zed.dev>
2023-05-02 21:10:20 +03:00
Nathan Sobo
2615a11f7c
Don't export platform::* from gpui
...
I'd like to avoid cluttering the top-level namespace with all the platform-
specific types.
2023-04-07 11:45:53 -06:00
Antonio Scandurra
2f95510a2e
Start integrating Copilot with editor
...
There's still a bit to do in terms of reusing the previous suggestion
when the prefix matches, but we're getting there.
2023-03-28 09:42:01 -07:00
Antonio Scandurra
9713d1bb31
Fix invalid translation between bottom/top left coordinate spaces
...
Co-Authored-By: Mikayla Maki <mikayla@zed.dev>
2023-03-28 09:42:01 -07:00
Antonio Scandurra
99cca59c84
Restructure verification code prompting to open a window instead
...
Also, prevent multiple calls to `sign_in` from racing with each other.
2023-03-28 09:42:01 -07:00
Mikayla Maki
adf94a1681
Switch from using the key window to the main window mac platform API
...
When the help menu is open, the help menu's search field is the key window, and this was causing menu item action resolution to fail
co-authored-by: Max <max@zed.dev>
2023-03-10 14:43:28 -08:00
Max Brunsfeld
fbc934b884
Adjust window's traffic light position when setting its title
2023-02-23 14:44:45 -08:00
Julia
e56dfd9177
Tell OS about window title
2023-02-15 15:55:55 -05:00
Mikayla Maki
87cf8ac60e
Fixed strange y results from faulty conversion to screen coordinates
...
co-authored-by: Nathan <nathan@zed.dev>
2023-02-07 15:26:03 -08:00
Mikayla Maki
db2aaa4367
Fixed bug in setting cursor style
2023-02-07 14:35:46 -08:00
Kay Simmons
1593b1e13d
window position restoration working
2023-01-26 16:35:00 -08:00
Kay Simmons
a369fb8033
better but still broken
2023-01-25 17:05:57 -08:00
Kay Simmons
5eac797a93
mostly working now
2023-01-25 11:36:38 -08:00
Kay Simmons
15799f7af6
wip
2023-01-25 11:32:19 -08:00
Mikayla Maki
ecb7d1072f
Fixes a broken conditional that is only caught on darwin systems
2023-01-25 09:33:07 -08:00
Mikayla Maki
45e4e3354e
Changed the presenter to only send 'set_cursor_style' on the topmost window
...
co-authored-by: Antonio <antonio@zed.dev>
2023-01-25 09:10:35 -08:00
Mikayla Maki
27a80a1c94
WIP
2023-01-25 09:10:35 -08:00
Mikayla Maki
426aeb7c5e
WIP - adds platform APIs for checking the top most window
2023-01-25 09:10:35 -08:00
Mikayla Maki
8dcaa81aad
switch return type of accepts_first_mouse
2023-01-20 18:19:24 -08:00
Mikayla Maki
310d867aab
Switch PopUp windows to use the NSTrackingArea API and add support for the mouseExited event
...
Co-authored-by: Antonio <antonio@zed.dev>
2023-01-20 16:35:25 -08:00
Mikayla Maki
8af1294ba5
Changed platform mouse moved handling to only fire on active or popup windows
...
co-authored-by: Antonio <antonio@zed.dev>
2023-01-20 09:37:09 -08:00
Mikayla Maki
5a00729fad
Merge pull request #2051 from zed-industries/show-following-to-followed
...
Show following to followed
2023-01-20 09:23:34 -08:00
Mikayla Maki
97203e1e02
Fix broken merge
2023-01-20 09:19:58 -08:00
Mikayla Maki
95e661a78c
Switched from active hover to NSViews acceptsFirstMouse API
...
Co-authored-by: Nathan <nathan@zed.dev>
2023-01-20 09:14:38 -08:00
Julia
131f3471fc
Don't dispatch mousemove without focus & avoid swallowing external moves
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
2023-01-20 10:11:28 -05:00
Mikayla Maki
88170df7f0
Switched from active hover to NSViews acceptsFirstMouse API
2023-01-19 15:21:26 -08:00
Kay Simmons
73e7967a12
working f and t bindings
2023-01-06 14:24:20 -08:00
Antonio Scandurra
d275474b23
Don't focus incoming call and project shared notification windows
2022-11-02 14:17:16 +01:00
Antonio Scandurra
f611b443c0
Convert window frame rect to screen coordinates
2022-10-26 14:27:53 +02:00
Antonio Scandurra
5a8061ac7b
Add the ability to open a window on a given screen
...
This is done by supplying the screen in the `WindowOptions` struct.
Note that it's optional, and we will let the operating system choose
which screen to show the window on when `screen` is not provided, as
we did before this change.
2022-10-26 12:04:45 +02:00
K Simmons
a725ded95e
Add fn modifier to modifier keys in gpui and refactor platform events to use a single modifiers struct
2022-10-24 23:50:39 -07:00
Antonio Scandurra
458a6a7310
💄
2022-09-16 11:09:30 +02:00
Antonio Scandurra
582ca666d0
Don't assume BOOL
is a boolean
2022-09-16 11:03:15 +02:00
Antonio Scandurra
b6ff8e7749
Introduce workaround for spurious windowDidBecomeKey
event
2022-09-16 10:55:15 +02:00