Marshall Bowers
1cc7f66f86
Fix documentation labels obscuring other content in completion menu ( #4167 )
...
This PF fixes an issue where the documentation labels in the completion
menu could end up completing obscuring the primary content.
#### Before
<img width="691" alt="Screenshot 2024-01-19 at 1 42 19 PM"
src="https://github.com/zed-industries/zed/assets/1486634/187f2978-08be-4f5e-ba93-91ed09cd6e87 ">
#### After
<img width="704" alt="Screenshot 2024-01-19 at 1 39 45 PM"
src="https://github.com/zed-industries/zed/assets/1486634/e5929c04-bace-4336-b878-4ada5660d235 ">
Since this involved changes to the `ListItem`, I also made sure to test
the other problematic case that was fixed in #3845 to make sure we
didn't regress there:
<img width="665" alt="Screenshot 2024-01-19 at 1 39 11 PM"
src="https://github.com/zed-industries/zed/assets/1486634/14b72d44-b6a6-4aef-a708-37fb60b8875a ">
I also tried to capture these cases in the `ListItem` stories to make it
easier to test all of them at once:
<img width="1141" alt="Screenshot 2024-01-19 at 1 40 03 PM"
src="https://github.com/zed-industries/zed/assets/1486634/333886ff-e394-4cba-89db-98352481c7f6 ">
Release Notes:
- Fixed an issue where documentation labels could obscure other content
in the editor completion menu
([#2419 ](https://github.com/zed-industries/community/issues/2419 )).
2024-01-19 14:01:09 -05:00
Marshall Bowers
decf320a74
Rename overflow_hidden_{x,y} to overflow_{x,y}_hidden ( #4146 )
...
This PR renames the `overflow_hidden_x` and `overflow_hidden_y` methods
to `overflow_x_hidden` and `overflow_y_hidden`, respectively.
This provides consistency with our `overflow_x_scroll` /
`overflow_y_scroll` methods, as well as better matches Tailwind's
naming.
Release Notes:
- N/A
2024-01-18 22:10:41 -05:00
Conrad Irwin
6c2da0d25b
Revert "Store a z-index id per-layer ( #4128 )"
...
This reverts commit 28a2337218e992f84735
2024-01-18 13:28:23 -07:00
Julia
bc2302f723
Store a z-index id per-layer
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2024-01-18 13:24:25 -05:00
Conrad Irwin
f6ef07e716
Make chat prettier (to my eyes at least)
2024-01-13 21:37:13 -07:00
Max Brunsfeld
83f4c61657
Remove 2 suffix from gpui_macros, fix compile errors in tests
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 13:12:21 -08:00
Max Brunsfeld
f5ba22659b
Remove 2 suffix from gpui
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-01-03 12:59:39 -08:00
