Max Brunsfeld
149a718d65
Don't scroll List on scroll wheel events outside of its bounds
2023-12-15 13:38:49 -08:00
Max Brunsfeld
a5e037befa
Avoid duplicate render of a pane when it is zoomed
2023-12-15 13:26:48 -08:00
Max Brunsfeld
e3e988c150
Always render panes via pane_group::Member::render
...
Remove distinct code path for rendering panes in a PaneAxis, as this dropped
the logic for rendering the leader border and info box.
2023-12-15 13:26:36 -08:00
Max Brunsfeld
4eb609a954
Enable zoom ( #3668 )
...
* [x] zoom
* [x] pane tests
2023-12-15 12:58:03 -08:00
Nate Butler
7af0edf5b6
Editor UI Cleanup ( #3676 )
...
[[PR Description]]
TODO:
- [x] Style fold marker
- [x] Editor - Code action icon too large, should use muted color,
should have tooltip
- [ ] Style inline assistant
- Prompt text gets cut off veritcally
- [x] Line height on inline assist editor isn't tall enough
- Nate: This is my fault due to the line height (relative: 1) we are
setting on non-buffer editors. I'll look into this.
- [ ] Style diagnostic hover (right now it's an opaque box on some
themes)
- Nate: This needs status tints, we are working on it
- [ ] Hovering over a symbol shows a dialogue that appears underneath
the scroll-bar
Release Notes:
- N/A
2023-12-15 15:49:55 -05:00
Nate Butler
e71f2b49e8
Style fold control
2023-12-15 15:41:53 -05:00
Conrad Irwin
b8cdcf4e93
fix theme selector gaps ( #3682 )
...
- Don't scroll beyond end of uniform list
- Restore position of uniform_list padding
[[PR Description]]
Release Notes:
- N/A
2023-12-15 13:27:17 -07:00
Nathan Sobo
3781626379
Merge branch 'main' into arena
2023-12-15 13:22:19 -07:00
Conrad Irwin
3c3e5ed7d8
Fix bug where vim commands were copied on each update_matches ( #3680 )
...
In zed1, the array of commands was recalculated on every update_matches,
In zed2 it's cached before we change the focus.
Release Notes:
- N/A
2023-12-15 13:20:10 -07:00
Conrad Irwin
2fe9a1df21
Restore position of uniform_list padding
...
It should be inside the scrollable area.
2023-12-15 13:18:51 -07:00
Max Brunsfeld
4c3ec0a8e5
Enable pane tests
2023-12-15 12:00:58 -08:00
Conrad Irwin
a35fdf45fc
Don't scroll beyond end of uniform list
2023-12-15 12:54:12 -07:00
Max Brunsfeld
9a8225c855
When a dock is zoomed, don't render it in its normal place
2023-12-15 11:48:25 -08:00
Max Brunsfeld
a4c123bb11
Fix logic for activating panel when re-docking it
2023-12-15 11:47:01 -08:00
Marshall Bowers
b1a61ca21e
Fix toolbar width ( #3681 )
...
This PR fixes an issue with the toolbar width introduced in #3666 .
The lack of a flex container was making the toolbar contents not take up
the full width, and thus not positions items correctly along its main
axis.
Release Notes:
- N/A
2023-12-15 14:44:29 -05:00
Max Brunsfeld
793381f455
Render zoomed item in the workspace
2023-12-15 11:19:59 -08:00
Marshall Bowers
487edcb12b
Rework collab panel rendering to use gpui::list
( #3678 )
...
This PR reworks the rendering of the collab panel to use `gpui::list`,
so that we don't render any items that are not visible on the screen.
In the process we also fixed some bugs in the channel list:
- Fixed the context menu for channels not deploying when activated via
keyboard
- Fixed drag and drop for channels
- Made it so when navigating the collab panel via keyboard the list only
scrolls enough to reveal the next item when navigating to an item that
is currently off-screen
Release Notes:
- N/A
2023-12-15 14:11:24 -05:00
Mikayla Maki
dc7f4f4786
Fix editor mouse event dispatch stealing clicks ( #3679 )
...
[[PR Description]]
Release Notes:
-
2023-12-15 11:06:31 -08:00
Marshall Bowers
5c060ceb1c
Format code
2023-12-15 14:03:49 -05:00
Marshall Bowers
5417127902
Fix channel drag and drop
...
Also add the ability to unnest a channel by dragging it to the "Channels"
header. This is currently not working due to a collab server issue.
Co-authored-by: Max <max@zed.dev>
2023-12-15 14:01:24 -05:00
Conrad Irwin
d0dbf8e1e2
Fix bug where vim commands were copied on each update_matches
...
In zed1, the array of commands was recalculated on every update_matches,
In zed2 it's cached before we change the focus.
2023-12-15 11:59:06 -07:00
Marshall Bowers
a40f04b71f
Only scroll enough to reveal the next channel if it isn't visible
...
Co-authored-by: Max <max@zed.dev>
2023-12-15 13:50:51 -05:00
Mikayla
b4135dd2f1
Fix editor mouse event dispatch
2023-12-15 10:26:41 -08:00
Marshall Bowers
47fc03ab98
Fix positioning of the inline context menu
...
Added a new `bounds_for_item` for `ListState`.
Co-authored-by: Max <max@zed.dev>
2023-12-15 13:24:30 -05:00
Mikayla
a2852e36ce
Fix pane resizing
2023-12-15 10:07:10 -08:00
Antonio Scandurra
0a57171066
Use a safe API for Arena
2023-12-15 19:03:37 +01:00
Nate Butler
4cb0f60779
Update size of code action indicator and show when active
2023-12-15 12:29:33 -05:00
Nate Butler
83525bf142
Revert change to single line editor height
2023-12-15 12:22:33 -05:00
Marshall Bowers
b478a4c4d5
Perform scroll interactions through the ListState
2023-12-15 12:10:40 -05:00
Nate Butler
d13c1486da
Update fold_indicator render
2023-12-15 12:09:06 -05:00
Marshall Bowers
6c10ff8548
Render the collab panel using a gpui::list
2023-12-15 11:56:03 -05:00
Nate Butler
6345e6d4d2
Add some right side padding in titlebar.
2023-12-15 11:25:24 -05:00
Nate Butler
d099d35948
Reduce intensity of project panel icons
2023-12-15 11:20:56 -05:00
Nate Butler
47eaf1abd8
Remove red borders, improve left side padding
2023-12-15 11:07:40 -05:00
Nate Butler
50a44dd8ba
Improve tooltip with keybinding styling
2023-12-15 11:07:17 -05:00
Nate Butler
f459fc5e27
Fix import
2023-12-15 10:33:27 -05:00
Nate Butler
62ea58618c
Merge branch 'main' into story-enhancements
2023-12-15 10:26:59 -05:00
Nate Butler
3d9e051b07
Update storybook2.rs
2023-12-15 10:25:07 -05:00
Antonio Scandurra
be73dd852d
Move Arena
to a thread-local and use it to allocate AnyElement
2023-12-15 16:18:05 +01:00
Antonio Scandurra
e1ca8e81bb
Use an Arena to reuse allocations for listeners
2023-12-15 15:13:32 +01:00
Piotr Osiewicz
ff3f4f3027
search: Reintroduce whole word switch ( #3672 )
...
It seems to have been lost in the recent styling pass.
Release Notes:
- N/A
2023-12-15 12:20:54 +01:00
Piotr Osiewicz
2b3d9deabe
Dismiss Recent Projects & VCS modals on ESC ( #3671 )
...
Release Notes:
- N/A
2023-12-15 12:07:25 +01:00
Kirill Bulatov
4bfe46f53a
Restore zed1 behavior for buffer search deploy
2023-12-15 12:23:03 +02:00
Kirill Bulatov
31ff7d40ed
Adjust copy/paste buffer only on the copy error action trigger
2023-12-15 11:34:00 +02:00
Kirill Bulatov
a6403aad1a
Remove extra nits, do not panic on clicking the buffer separator
2023-12-15 11:28:48 +02:00
Julia
de523c2d80
Give correct focus handle when project search has no matches
2023-12-14 23:49:44 -05:00
Julia
4be84f3db0
Merge branch 'main' into focus-handlers-on-draw
2023-12-14 23:08:23 -05:00
Julia
d4e09230cc
Give result-less project search a focus handle
2023-12-14 22:29:33 -05:00
Conrad Irwin
7e1d61d116
Merge branch 'main' into user-menu
2023-12-14 20:18:20 -07:00
Mikayla Maki
46bd6088e8
Fix some todos, add others ( #3669 )
...
As it says on the tin
Release Notes:
-
2023-12-14 19:00:58 -08:00