Conrad Irwin
41a99c686b
Potential fix for #2422
2024-01-22 11:10:15 -07:00
Mikayla
6419df82ee
Fix certain hovers being cut off
2024-01-22 09:49:07 -08:00
Conrad Irwin
c49477746e
TYPO
2024-01-22 09:56:59 -07:00
Conrad Irwin
0903d29ab3
Improve logic for reused bindings, add docs.
2024-01-22 09:53:04 -07:00
Julia
3b3252b040
Rewrote and documented was_top_layer
logic
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
2024-01-22 11:50:47 -05:00
Julia
455d5eeb89
Preserve stacking order ID order when reusing cached view state
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
2024-01-22 10:50:52 -05:00
Conrad Irwin
6c4d024237
TYPO
2024-01-22 08:40:21 -07:00
Conrad Irwin
c5d7c8e122
Fix cmd-k left
2024-01-22 08:38:20 -07:00
Julia
831769ce8c
Ignore stacking order entry ids in was_top_layer
2024-01-22 10:16:59 -05:00
Julia
2c3d9805a4
Store a z-index id per-layer
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2024-01-22 10:16:59 -05:00
Conrad Irwin
7ec4f22202
de-dbg!
2024-01-22 08:14:30 -07:00
Antonio Scandurra
de64de22a3
Introduce a ZED_MEASUREMENTS
env var and use it to measure frame time
2024-01-22 11:39:20 +01:00
Conrad Irwin
b9c7bafc80
Merge remote-tracking branch 'origin/main' into jk
2024-01-21 22:03:54 -07:00
Conrad Irwin
4143d3a36e
Work on tests
2024-01-21 22:00:35 -07:00
Mikayla
b65cae5874
Moved Frame struct into element context, to be close to it's associated methods
2024-01-21 20:52:24 -08:00
Mikayla
c05edee2b5
Port the rest of the app
2024-01-21 20:26:33 -08:00
Mikayla
df4566fd1e
Refactor out element context from GPUI
2024-01-21 19:43:35 -08:00
Conrad Irwin
9d261cf859
Merge branch 'main' into jk
2024-01-21 20:36:18 -07:00
Conrad Irwin
8c541b4930
Comment out tests for nwo
2024-01-21 20:16:14 -07:00
Conrad Irwin
b06e2eb6af
Update handling of 'pending' keys
...
Before this change if you had a matching binding and a pending key,
the matching binding happened unconditionally.
Now we will wait a second before triggering that binding to give you
time to complete the action.
2024-01-21 20:12:01 -07:00
Mikayla
2f9958621b
Do an initial pass on refactoring out ElementContext from WindowContext
2024-01-21 18:40:20 -08:00
Mikayla Maki
a8990baaac
Document more gpui ( #4187 )
...
Also add several `TODO!(docs)` comments to places that need more
feedback.
Release Notes:
- N/A
2024-01-21 15:10:04 -08:00
Mikayla
118a3461a7
Restore erronously removed APIs
2024-01-21 14:33:34 -08:00
Mikayla
660a391806
Fix typos, mark docs related todos in GPUI
2024-01-21 14:28:40 -08:00
Mikayla
aa57a4cfbc
Document / lockdown more of GPUI
2024-01-21 14:26:45 -08:00
Conrad Irwin
b8ed83a452
Refactor key dispatch to work in terms of bindings
2024-01-21 12:27:26 -07:00
Piotr Osiewicz
6c82380232
chore: Fix clippy::needless_borrow up to an editor
2024-01-21 15:03:24 +01:00
Thorsten Ball
29e74a648f
When searching in visual mode switch to normal mode ( #4178 )
...
This matches Neovim behaviour by setting the mode to `Normal` when using
search while in visual mode.
Release Notes:
- Fixed Vim mode not switching to normal mode from visual mode when
using search (`/`) while in visual mode.
2024-01-21 08:42:47 +01:00
Mikayla
476de329b3
Fix issues in element comment
2024-01-20 20:19:01 -08:00
Mikayla
2083fdcaf6
Fix compile issue
2024-01-20 20:15:43 -08:00
Mikayla
bf878b8257
Document the canvas and div
2024-01-20 20:15:23 -08:00
Mikayla
a44aae9e91
Finish documenting the action, asset, color, and element modules in GPUI
...
Remove SmallVec from the public API of GPUI
2024-01-20 20:15:23 -08:00
Conrad Irwin
3b84291343
Updates to chat after Hack#2 ( #4175 )
...
Release Notes:
- Channels: Improved font sizes in chat
- Channels: Added a link preview when hovering over links in chat
- Channels: Fixed rendering of newlines in chat messages
- Added a new setting "use_autoclose" (defaulting to true) that lets you
disable autoclose per language.
([#1420 ](https://github.com/zed-industries/community/issues/1420 ))
([#1903 ](https://github.com/zed-industries/community/issues/1903 ))
2024-01-20 20:03:37 -07:00
Mikayla
4184686e8d
Lock down test platform implementation
2024-01-20 15:03:36 -08:00
Mikayla
017661818d
Fix typo
2024-01-20 14:42:38 -08:00
Mikayla
9da6b8c7f6
Lock down mac os platform type visibility in the rest of GPUI
...
Add documentation to all platform types
2024-01-20 14:38:03 -08:00
Conrad Irwin
29ac1fd081
Merge remote-tracking branch 'origin/main' into chat-font-size
2024-01-20 14:51:53 -07:00
Thorsten Ball
87be105af7
When searching in visual mode switch to normal mode
...
This matches Neovim behaviour by setting the mode to `Normal` when using
search while in visual mode.
Co-authored-by: Conrad <conrad@zed.dev>
2024-01-20 16:33:07 +01:00
Mikayla
33105486aa
Make platform input handler private
...
Automatically record the context on non-view input handlers
Simplify the async window context update() method
2024-01-20 06:56:19 -08:00
Conrad Irwin
23d991962a
Link previews in chat
2024-01-19 16:59:17 -07:00
Conrad Irwin
cb84043400
Merge branch 'main' into fix-notification-positioning
2024-01-19 12:55:52 -07:00
Conrad Irwin
00e46fdde0
Fix positioning of windows on secondary displays
...
CGDisplayBounds returns data in "global display coordinates" (which are
the same as Zed's coordinates), different from the NS APIs which use
"screen coordinates" (which have the Y axis inverted)
Also remove some transmutes while we're at it
2024-01-19 12:51:59 -07:00
Marshall Bowers
1cc7f66f86
Fix documentation labels obscuring other content in completion menu ( #4167 )
...
This PF fixes an issue where the documentation labels in the completion
menu could end up completing obscuring the primary content.
#### Before
<img width="691" alt="Screenshot 2024-01-19 at 1 42 19 PM"
src="https://github.com/zed-industries/zed/assets/1486634/187f2978-08be-4f5e-ba93-91ed09cd6e87 ">
#### After
<img width="704" alt="Screenshot 2024-01-19 at 1 39 45 PM"
src="https://github.com/zed-industries/zed/assets/1486634/e5929c04-bace-4336-b878-4ada5660d235 ">
Since this involved changes to the `ListItem`, I also made sure to test
the other problematic case that was fixed in #3845 to make sure we
didn't regress there:
<img width="665" alt="Screenshot 2024-01-19 at 1 39 11 PM"
src="https://github.com/zed-industries/zed/assets/1486634/14b72d44-b6a6-4aef-a708-37fb60b8875a ">
I also tried to capture these cases in the `ListItem` stories to make it
easier to test all of them at once:
<img width="1141" alt="Screenshot 2024-01-19 at 1 40 03 PM"
src="https://github.com/zed-industries/zed/assets/1486634/333886ff-e394-4cba-89db-98352481c7f6 ">
Release Notes:
- Fixed an issue where documentation labels could obscure other content
in the editor completion menu
([#2419 ](https://github.com/zed-industries/community/issues/2419 )).
2024-01-19 14:01:09 -05:00
Conrad Irwin
2166f071b3
Fix panic in window open ( #4148 )
...
Fix a panic caused by toggleFullScreen on one window untoggling
full-screen on
another.
I managed to reproduce this only once, which makes me sad, but this
change
should fix it regardless.
https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1705631681238979
Release Notes:
- Fixed an occasional panic when opening a new fullscreen window.
2024-01-19 11:08:06 -07:00
Marshall Bowers
01f06f96a1
Update tenses of doc comment summary lines ( #4161 )
...
This PR updates the tenses used by the summary line of doc comments to
match the [Rust API documentation
conventions](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#summary-sentence ).
Specifically:
> The summary line should be written in third person singular present
indicative form. Basically, this means write ‘Returns’ instead of
‘Return’.
I'm sure there are plenty occurrences that I missed.
Release Notes:
- N/A
2024-01-19 11:18:50 -05:00
Antonio Scandurra
9446e573e9
Reuse layout for view's element when it wasn't cached
2024-01-19 10:26:39 +01:00
Conrad Irwin
d76bd100f5
Show cursors for remote participants ( #4082 )
...
This PR enables cursors for remote participants.
They are shown for 2 seconds when you focus a buffer, and then on hover.
Release Notes:
- Added usernames next to remote cursors
2024-01-18 20:58:09 -07:00
Conrad Irwin
87d60beda7
Fix a double borrow error in window.open
...
It seems that sometimes calling toggleFullScreen will cause the
display_layer callback of a different window to fire.
2024-01-18 20:55:50 -07:00
Marshall Bowers
decf320a74
Rename overflow_hidden_{x,y}
to overflow_{x,y}_hidden
( #4146 )
...
This PR renames the `overflow_hidden_x` and `overflow_hidden_y` methods
to `overflow_x_hidden` and `overflow_y_hidden`, respectively.
This provides consistency with our `overflow_x_scroll` /
`overflow_y_scroll` methods, as well as better matches Tailwind's
naming.
Release Notes:
- N/A
2024-01-18 22:10:41 -05:00
Mikayla Maki
bac2e59eac
Fix popin for project panel by pre-resolving keybindings in the project panel ( #4141 )
...
Also, factors out the fluent building APIs from IntoElement into their
own traits.
Also makes the project panel context menu initialization fluent:
<img width="1328" alt="Screenshot 2024-01-18 at 3 33 45 PM"
src="https://github.com/zed-industries/zed/assets/2280405/3468b6f2-07f0-48cf-bec1-ac0379333209 ">
Release Notes:
- Fixed pop in when right clicking on the project panel.
2024-01-18 16:16:50 -08:00