Nate Butler
740e2cc5bf
Start on ui root doc
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-11-03 16:28:54 -04:00
Kirill Bulatov
edacffab58
Refresh diagnostics inside the tab ( #3225 )
...
r-a now has 2 different types of diagnostics:
* "disk-based" ones that come from `cargo check` and related, that emit
`project::Event::DiskBasedDiagnosticsStarted` and
`DiskBasedDiagnosticsFinished`
* "flycheck" diagnostics from r-a itself, that it tries to dynamically
apply to every buffer open, that come with `DiagnosticsUpdated` event.
Latter diagnostics update frequently, on every file close and open, but
`diagnostics.rs` logic had never polled for new diagnostics after
registering the `DiagnosticsUpdated` event, so the only way we could
have newer diagnostics was to re-open the whole panel.
The PR fixes that, and also adds more debug logging to the module.
The logic of the fix looks very familiar to previous related fix:
https://github.com/zed-industries/zed/pull/3128
One notable thing after the fix: "flycheck" diagnostics stay forever if
the diagnostics panel is opened: excerpts in that panel do not allow the
buffer to get dropped (hence, closed in terms of r-a) and get the
updated, zero diagnostics.
If the diagnostics panel is opened and closed multiple times, those
errors gradually disappear.
Release Notes:
- Fixed diagnostics panel not refreshing its contents properly
2023-11-03 22:03:05 +02:00
Kirill Bulatov
918d123284
Fix the test
2023-11-03 21:51:12 +02:00
Kirill Bulatov
6f8947a3d3
Fix a compilation error
2023-11-03 21:51:12 +02:00
Kirill Bulatov
9cb8ce172d
Refresh diagnostics inside the tab
2023-11-03 21:51:12 +02:00
Marshall Bowers
fa7d6c0e70
Remove Default impl for ThemeColors` ( #3226 )
...
This PR removes the `Default` impl for `ThemeColors`.
Since we need default light and dark variants for `ThemeColors`, we
can't use a single `Default` impl.
Release Notes:
- N/A
2023-11-03 15:40:50 -04:00
Max Brunsfeld
66499f60ee
Fix double borrow in synchronous tests that take AppContext
...
Co-authored-by: Mikayla <mikayla@zed.dev>
Co-authored-by: Antonio <antonio@zed.dev>
2023-11-03 12:10:11 -07:00
Mikayla
2b883bf32e
WIP
2023-11-03 12:04:24 -07:00
Mikayla
6a1fb18334
Update to latest patterns for porting work
2023-11-03 10:46:47 -07:00
Max Brunsfeld
b085569b46
Add channel2 crate
...
Co-authored-by: Marshall <marshall@zed.dev>
2023-11-03 10:41:41 -07:00
Kyle Caverly
343525d77b
added workspace event for WorkspaceCreated ( #3222 )
...
added workspace2 event for WorkspaceCreated
Release Notes:
- NA
2023-11-03 11:06:11 -04:00
Antonio Scandurra
de3d37e070
Don't depend on gpui2 in text
2023-11-03 14:53:08 +01:00
Antonio Scandurra
097171b9b8
Merge remote-tracking branch 'origin/main' into editor2
2023-11-03 14:47:49 +01:00
Antonio Scandurra
3e8fcefaef
Remove more todos
2023-11-03 14:42:26 +01:00
Antonio Scandurra
feaab953a8
Add ViewContext::window_context
2023-11-03 14:41:37 +01:00
KCaverly
b148c61047
added workspace event for WorkspaceCreated
2023-11-03 08:52:18 -04:00
Kirill Bulatov
1a0cd3e09b
Remove and add more todosmerge .
2023-11-03 13:22:11 +02:00
Antonio Scandurra
77e3c7f8ee
WIP
2023-11-03 12:10:15 +01:00
Kirill Bulatov
f1fc07de94
Move journal2 to workspace2
2023-11-03 12:55:06 +02:00
Kirill Bulatov
eb8a0e7148
Uncomment persistence tests
2023-11-03 12:38:09 +02:00
Antonio Scandurra
b7712c2f4b
Fix a todo in workspace
2023-11-03 11:36:39 +01:00
Antonio Scandurra
bed10b433a
Allow converting from a WeakView<V> to an AnyWeakView
2023-11-03 11:36:18 +01:00
Antonio Scandurra
6fc7b17259
Expose a focus handle from workspace::Item
2023-11-03 11:00:57 +01:00
Antonio Scandurra
97d1d9bd9b
Uncomment Editor::report_editor_event
2023-11-03 10:53:55 +01:00
Antonio Scandurra
0dfa3c60b7
Remove some todos
2023-11-03 10:50:30 +01:00
Antonio Scandurra
11feda01e3
Uncomment Editor::new
2023-11-03 10:38:28 +01:00
Antonio Scandurra
2fccde5ab6
Remove unused code
2023-11-03 10:11:13 +01:00
Antonio Scandurra
efa27cf9b8
Uncomment more editor code
2023-11-03 10:09:00 +01:00
Kirill Bulatov
09346fb9f1
Port changes to zed2
2023-11-03 11:02:50 +02:00
Kirill Bulatov
24dd1c5812
Properly order default prettier installations and startups
2023-11-03 11:02:50 +02:00
Kirill Bulatov
244c693968
Reuse already running default prettiers
2023-11-03 11:02:50 +02:00
Kirill Bulatov
cf95f9b082
Make it more clear that missing prettier is to blame
2023-11-03 11:02:50 +02:00
Kirill Bulatov
369b5140fb
Restore LSP names for prettier servers
2023-11-03 11:02:50 +02:00
Kirill Bulatov
b75d8a60a8
Simplify
2023-11-03 11:02:50 +02:00
Kirill Bulatov
ff144def63
Fix the bugs
2023-11-03 11:02:50 +02:00
Kirill Bulatov
6bbb79a9f5
Rework prettier installation and start
2023-11-03 11:02:50 +02:00
Kirill Bulatov
d673efebd2
Add prettier workspace resolution test
2023-11-03 11:02:50 +02:00
Antonio Scandurra
cdc82d01f7
Call editor::init
2023-11-03 09:06:25 +01:00
Antonio Scandurra
800c2685ea
Remove dependency from gpui from editor2
2023-11-03 09:05:58 +01:00
Nathan Sobo
fbee6b5352
Get editor2 compiling with a ton of code commented out
2023-11-02 23:35:20 -06:00
Nathan Sobo
f3b8a9d8c2
WIP
2023-11-02 22:56:04 -06:00
Nathan Sobo
a731f8fb1e
WIP
2023-11-02 21:28:56 -06:00
Nathan Sobo
dfc7c81500
WIP
2023-11-02 21:03:29 -06:00
Nathan Sobo
72b9dc8216
Merge remote-tracking branch 'origin/main' into editor2
2023-11-02 20:47:09 -06:00
Nathan Sobo
6a89f7ce4f
rich text2 ( #3220 )
...
- git -> git3
- Add rich_text2
[[PR Description]]
Release Notes:
N/A
2023-11-02 20:46:45 -06:00
Nathan Sobo
2a12e8f307
Merge remote-tracking branch 'origin/rich_text2' into editor2
2023-11-02 20:34:52 -06:00
Conrad Irwin
0b3932f38c
Convert rich_text2
2023-11-02 19:30:33 -06:00
Conrad Irwin
6ecb4805f7
Add rich_text2
2023-11-02 19:19:18 -06:00
Conrad Irwin
cbd902658c
git -> git3
...
This is needed for the editor.
2023-11-02 19:18:01 -06:00
Conrad Irwin
0aabb19a45
Into the woods
2023-11-02 18:52:08 -06:00
