Commit graph

48 commits

Author SHA1 Message Date
Piotr Osiewicz
780d5c7d35
Auto-fix clippy::collapsible_if violations (#36428)
Release Notes:

- N/A
2025-08-23 10:39:22 -04:00
Bennet Bo Fenner
6ebd617d40
agent2: Fix agent location still being present after thread stopped (#36471)
Release Notes:

- N/A
2025-08-23 10:39:21 -04:00
Bennet Bo Fenner
0155488955
agent2: Port retry logic (#36421)
Release Notes:

- N/A
2025-08-23 10:39:21 -04:00
Cole Miller
4af757d578
agent2: Support directories in @file mentions (#36416)
Release Notes:

- N/A
2025-08-23 10:39:21 -04:00
Piotr Osiewicz
455a95c81d
Fix clippy::needless_borrow lint violations (#36444)
Release Notes:

- N/A
2025-08-23 10:39:20 -04:00
Agus Zubiaga
1b270842a3
Handle auth for claude (#36442)
We'll now use the anthropic provider to get credentials for `claude` and
embed its configuration view in the panel when they are not present.

Release Notes:

- N/A
2025-08-23 10:39:20 -04:00
Agus Zubiaga
e587ed5c6f
acp: Have AcpThread handle all interrupting (#36417)
The view was cancelling the generation, but `AcpThread` already handles
that, so we removed that extra code and fixed a bug where an update from
the first user message would appear after the second one.

Release Notes:

- N/A

Co-authored-by: Danilo <danilo@zed.dev>
2025-08-23 10:39:19 -04:00
Agus Zubiaga
9e0dd0c699
acp: Stay in edit mode when current completion ends (#36413)
When a turn ends and the checkpoint is updated, `AcpThread` emits
`EntryUpdated` with the index of the user message. This was causing the
message editor to be recreated and, therefore, lose focus.

Release Notes:

- N/A
2025-08-23 10:39:19 -04:00
Ben Brandt
7322916b15
Standardize on canceled instead of cancelled (#36385)
Release Notes:

- N/A
2025-08-23 10:39:18 -04:00
Ben Brandt
250fdcdbd3
Refactor ToolCallStatus enum to flat variants (#36356)
Replace nested Allowed variant with distinct statuses for clearer status
handling.

Release Notes:

- N/A
2025-08-23 10:39:17 -04:00
Ben Brandt
de3f7abfb0
Allow Permission Request to only require a ToolCallUpdate instead of a full tool call (#36319)
Release Notes:

- N/A
2025-08-23 10:39:17 -04:00
Agus Zubiaga
a70316d79b
acp thread view: Always use editors for user messages (#36256)
This means the cursor will be at the position you clicked:


https://github.com/user-attachments/assets/0693950d-7513-4d90-88e2-55817df7213a


Release Notes:

- N/A
2025-08-23 10:39:16 -04:00
Bennet Bo Fenner
eb1e6e6b73
agent2: Port Zed AI features (#36172)
Release Notes:

- N/A

---------

Co-authored-by: Antonio Scandurra <me@as-cii.com>
2025-08-23 10:39:15 -04:00
Cole Miller
b9901a44a7
Support images in agent2 threads (#36152)
- Support adding ImageContent to messages through copy/paste and through
path completions
- Ensure images are fully converted to LanguageModelImageContent before
sending them to the model
- Update ACP crate to v0.0.24 to enable passing image paths through the
protocol

Release Notes:

- N/A

---------

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
2025-08-23 10:39:14 -04:00
Agus Zubiaga
03efb2ac3c
acp: Clean up entry views on rewind (#36197)
We were leaking diffs and terminals on rewind, we'll now clean them up.
This PR also introduces a refactor of how we mantain the entry view
state to use a `Vec` that's kept in sync with the thread entries.

Release Notes:

- N/A
2025-08-23 10:39:14 -04:00
Conrad Irwin
3b47c99785
Allow editing Agent2 messages (#36155)
Release Notes:

- N/A

---------

Co-authored-by: Antonio Scandurra <me@as-cii.com>
Co-authored-by: Agus Zubiaga <agus@zed.dev>
2025-08-23 10:39:14 -04:00
Agus Zubiaga
b8887257f5
Fully support all mention kinds (#36134)
Feature parity with the agent1 @mention kinds:
- File
- Symbols
- Selections
- Threads
- Rules
- Fetch


Release Notes:

- N/A

---------

Co-authored-by: Cole Miller <cole@zed.dev>
2025-08-23 10:38:50 -04:00
Ben Brandt
971738b49e
agent2: Initial infra for checkpoints and message editing (#36120)
Release Notes:

- N/A

---------

Co-authored-by: Antonio Scandurra <me@as-cii.com>
2025-08-23 10:38:45 -04:00
Ben Brandt
797dab40aa
Agent2 Model Selector (#36028)
Release Notes:

- N/A

---------

Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
2025-08-23 10:38:45 -04:00
Cole Miller
65f0dc7b7c
Add locations to native agent tool calls, and wire them up to UI (#36058)
Release Notes:

- N/A

---------

Co-authored-by: Conrad <conrad@zed.dev>
2025-08-23 10:38:41 -04:00
Cole Miller
151c71a0ce
Fix external agent still being marked as generating after error response (#35992)
Release Notes:

- N/A
2025-08-23 10:38:41 -04:00
Danilo Leal
359acef10a
agent2: Add custom UI for resource link content blocks (#36005)
Release Notes:

- N/A

---------

Co-authored-by: Agus Zubiaga <agus@zed.dev>
2025-08-23 10:38:40 -04:00
Agus Zubiaga
5913bb8fc3
Include mention context in acp-based native agent (#36006)
Also adds data-layer support for symbols, thread, and rules.

Release Notes:

- N/A

---------

Co-authored-by: Cole Miller <cole@zed.dev>
2025-08-23 10:38:40 -04:00
Antonio Scandurra
4679c43789
Support profiles in agent2 (#36034)
We still need a profile selector.

Release Notes:

- N/A

---------

Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
2025-08-23 10:38:40 -04:00
Danilo Leal
fdfb0662c1
agent2: Refine terminal tool call display (#35984)
Release Notes:

- N/A
2025-08-23 10:38:39 -04:00
Cole Miller
c995fff875
Delay rendering tool call diff editor until it has a revealed range (#35901)
Release Notes:

- N/A
2025-08-23 10:38:19 -04:00
Antonio Scandurra
d6d28a53ce
Port terminal tool to agent2 (#35918)
Release Notes:

- N/A

---------

Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
2025-08-23 10:38:18 -04:00
Ben Brandt
6532d82d32
Pull action_log into its own crate (#35959)
Release Notes:

- N/A
2025-08-23 10:38:18 -04:00
Antonio Scandurra
581cbc3458
Lay the groundwork to create terminals in AcpThread (#35872)
This just prepares the types so that it will be easy later to update a
tool call with a terminal entity. We paused because we realized we want
to simplify how terminals are created in zed, and so that warrants a
dedicated pull request that can be reviewed in isolation.

Release Notes:

- N/A

---------

Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
2025-08-23 10:38:16 -04:00
Agus Zubiaga
37187940e9
agent2: Port edit_file tool (#35844)
TODO:
- [x] Authorization
- [x] Restore tests

Release Notes:

- N/A

---------

Co-authored-by: Antonio Scandurra <me@as-cii.com>
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
2025-08-23 10:38:15 -04:00
Agus Zubiaga
377376ee4b
Fix acp generating status after stop (#35852)
Release Notes:

- N/A
2025-08-23 10:38:15 -04:00
Ben Brandt
a646f94565
Wire up find_path tool in agent2 (#35799)
Release Notes:

- N/A

---------

Co-authored-by: Antonio Scandurra <me@as-cii.com>
2025-08-23 10:38:14 -04:00
Antonio Scandurra
948fd9c540
Add system prompt and tool permission to agent2 (#35781)
Release Notes:

- N/A

---------

Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2025-08-23 10:38:11 -04:00
Agus Zubiaga
6f193d94d5
Fix interrupting ACP threads and CC cancellation (#35752)
Fixes a bug where generation wouldn't continue after interrupting the
agent, and improves CC cancellation so we don't display "[Request
interrupted by user]"

Release Notes:

- N/A

---------

Co-authored-by: Cole Miller <cole@zed.dev>
2025-08-23 10:38:10 -04:00
Cole Miller
62554a978d
Fix flicker when agent plan updates (#35739)
Currently, when the agent updates its plan, there are a few frames where
the text after `Current:` in the plan summary is blank, causing a
flicker. This is because we treat that field as markdown, and the
`MarkdownElement` renders as blank until the raw text has finished
parsing in the background.

This PR fixes the flicker by changing `Markdown::new_text` to
optimistically render the source as a single `MarkdownEvent::Text` span
until background parsing has finished.

Release Notes:

- N/A

Co-authored-by: Agus Zubiaga <agus@zed.dev>
2025-08-23 10:38:10 -04:00
Agus Zubiaga
4f4f1c8882
Fix syntax highlighting in ACP diffs (#35748)
Release Notes:

- N/A
2025-08-23 10:38:10 -04:00
Ben Brandt
3cd60e81a1
ACP champagne (#35609)
cherry pick changes from #35510 onto latest main

Release Notes:

- N/A

---------

Co-authored-by: Nathan Sobo <nathan@zed.dev>
Co-authored-by: Antonio Scandurra <me@as-cii.com>
Co-authored-by: Lukas Wirth <lukas@zed.dev>
2025-08-23 10:38:09 -04:00
Cole Miller
57da8d4e86
Render error state when agent binary exits unexpectedly (#35651)
This PR adds handling for the case where an agent binary exits
unexpectedly after successfully establishing a connection.

Release Notes:

- N/A

---------

Co-authored-by: Agus <agus@zed.dev>
2025-08-23 10:37:27 -04:00
Agus Zubiaga
98cef9708d
Update to acp 0.0.18 (#35595)
Release Notes:

- N/A
2025-08-23 10:37:25 -04:00
Ben Brandt
5f184614e1
Update to new agent schema (#35578)
Release Notes:

- N/A

---------

Co-authored-by: Agus Zubiaga <agus@zed.dev>
2025-08-23 10:37:18 -04:00
Ben Brandt
2b3376ffa2
Fix false positive for editing status in agent panel (#35554)
Release Notes:

- N/A
2025-08-23 10:37:18 -04:00
Ben Brandt
e439342a81
agent_ui: More agent notifications (#35441)
Release Notes:

- N/A
2025-08-23 10:36:14 -04:00
Agus Zubiaga
a9ef9e10bd
Fix remaining agent server integration tests (#35222)
Release Notes:

- N/A
2025-08-23 10:36:05 -04:00
Agus Zubiaga
44812542d5
ACP over MCP server impl (#35196)
Release Notes:

- N/A

---------

Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
2025-08-23 10:36:03 -04:00
Agus Zubiaga
45daf26e7a
Refactor to use new ACP crate (#35043)
This will prepare us for running the protocol over MCP

Release Notes:

- N/A

---------

Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Co-authored-by: Richard Feldman <oss@rtfeldman.com>
2025-08-23 10:35:54 -04:00
Agus Zubiaga
2090fb71c6
Display ACP plans (#34816)
Release Notes:

- N/A

---------

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
2025-08-23 10:35:22 -04:00
Ben Brandt
6740f84de8
E2E Claude tests (#34702)
- **Fix cancellation of tool calls**
- **Make tool_call test more resilient**
- **Fix tool call confirmation test**

Release Notes:

- N/A
2025-08-23 10:35:20 -04:00
Agus Zubiaga
8e4555455c
Claude experiment (#34577)
Release Notes:

- N/A

---------

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Co-authored-by: Anthony Eid <hello@anthonyeid.me>
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
Co-authored-by: Nathan Sobo <nathan@zed.dev>
Co-authored-by: Oleksiy Syvokon <oleksiy.syvokon@gmail.com>
2025-07-17 14:25:55 +00:00