Ben Brandt
b249593abe
agent2: Always finalize diffs from the edit tool ( #36918 )
...
Previously, we wouldn't finalize the diff if an error occurred during
editing or the tool call was canceled.
Release Notes:
- N/A
---------
Co-authored-by: Antonio Scandurra <me@as-cii.com>
2025-08-26 09:46:29 +00:00
Cole Miller
5fd29d37a6
acp: Model-specific prompt capabilities for 1PA ( #36879 )
...
Adds support for per-session prompt capabilities and capability changes
on the Zed side (ACP itself still only has per-connection static
capabilities for now), and uses it to reflect image support accurately
in 1PA threads based on the currently-selected model.
Release Notes:
- N/A
2025-08-25 14:28:11 -04:00
Antonio Scandurra
69127d2bea
acp: Simplify control flow for native agent loop ( #36868 )
...
Release Notes:
- N/A
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
2025-08-25 13:38:19 +00:00
Bennet Bo Fenner
db949546cf
agent2: Less noisy logs ( #36863 )
...
Release Notes:
- N/A
2025-08-25 15:14:48 +02:00
Bennet Bo Fenner
4c0ad95acc
acp: Show retry button for errors ( #36862 )
...
Release Notes:
- N/A
---------
Co-authored-by: Antonio Scandurra <me@as-cii.com>
2025-08-25 12:52:25 +00:00
Antonio Scandurra
a79aef7bdd
acp: Never build a request with a tool use without its corresponding result ( #36847 )
...
Release Notes:
- N/A
2025-08-24 16:30:34 +00:00
Cole Miller
ea42013746
acp: Eagerly load all kinds of mentions ( #36741 )
...
This PR makes it so that all kinds of @-mentions start loading their
context as soon as they are confirmed. Previously, we were waiting to
load the context for file, symbol, selection, and rule mentions until
the user's message was sent. By kicking off loading immediately for
these kinds of context, we can support adding selections from unsaved
buffers, and we make the semantics of @-mentions more consistent.
Loading all kinds of context eagerly also makes it possible to simplify
the structure of the MentionSet and the code around it. Now MentionSet
is just a single hash map, all the management of creases happens in a
uniform way in `MessageEditor::confirm_completion`, and the helper
methods for loading different kinds of context are much more focused and
orthogonal.
Release Notes:
- N/A
---------
Co-authored-by: Conrad <conrad@zed.dev>
2025-08-23 01:21:20 -04:00
Antonio Scandurra
4f0fad6996
acp: Support calling tools provided by MCP servers ( #36752 )
...
Release Notes:
- N/A
2025-08-22 13:16:42 +00:00
Ben Brandt
e1a96b68f0
acp: Tool name prep ( #36726 )
...
Prep work for deduping tool names
Release Notes:
- N/A
2025-08-22 00:37:41 +00:00
Antonio Scandurra
731b5d0def
acp: Allow editing of thread titles in agent2 ( #36706 )
...
Release Notes:
- N/A
---------
Co-authored-by: Richard Feldman <oss@rtfeldman.com>
2025-08-21 20:24:13 +00:00
Antonio Scandurra
190217a43b
acp: Refactor agent2 send
to have a clearer control flow ( #36689 )
...
Release Notes:
- N/A
2025-08-21 18:11:05 +02:00
Agus Zubiaga
6f242772cc
acp: Update to 0.0.30 ( #36643 )
...
See: https://github.com/zed-industries/agent-client-protocol/pull/20
Release Notes:
- N/A
2025-08-21 00:10:36 +00:00
Piotr Osiewicz
74ce543d8b
clippy: println_empty_string & non_minimal_cfg ( #36614 )
...
- **clippy: Fix println-empty-string**
- **clippy: non-minimal-cfg**
Related to #36577
Release Notes:
- N/A
2025-08-20 18:45:40 +00:00
Umesh Yadav
ec8106d1db
Fix clippy::println_empty_string
, clippy::while_let_on_iterator
, clippy::while_let_on_iterator
lint style violations ( #36613 )
...
Related: #36577
Release Notes:
- N/A
2025-08-20 20:14:30 +02:00
Antonio Scandurra
699f58aeba
Capture telemetry when requesting completions in agent2 ( #36600 )
...
Release Notes:
- N/A
2025-08-20 16:04:32 +00:00
Antonio Scandurra
4ee565cd39
Fix mentions roundtrip from/to database and other history bugs ( #36575 )
...
Release Notes:
- N/A
2025-08-20 12:03:20 +00:00
tidely
7bdc99abc1
Fix clippy::redundant_clone
lint violations ( #36558 )
...
This removes around 900 unnecessary clones, ranging from cloning a few
ints all the way to large data structures and images.
A lot of these were fixed using `cargo clippy --fix --workspace
--all-targets`, however it often breaks other lints and needs to be run
again. This was then followed up with some manual fixing.
I understand this is a large diff, but all the changes are pretty
trivial. Rust is doing some heavy lifting here for us. Once I get it up
to speed with main, I'd appreciate this getting merged rather sooner
than later.
Release Notes:
- N/A
2025-08-20 12:20:13 +02:00
Bennet Bo Fenner
a32a264508
agent2: Use correct completion intent when generating summary ( #36573 )
...
Release Notes:
- N/A
2025-08-20 10:03:35 +00:00
Bennet Bo Fenner
0a80209c5e
agent2: Fix remaining update_model_request_usage todos ( #36570 )
...
Release Notes:
- N/A
2025-08-20 09:54:26 +00:00
Bennet Bo Fenner
4290f043cd
agent2: Fix token count not updating when changing model/toggling burn mode ( #36562 )
...
Release Notes:
- N/A
---------
Co-authored-by: Antonio Scandurra <me@as-cii.com>
2025-08-20 09:29:05 +00:00
Conrad Irwin
5d2bb2466e
ACP history mentions ( #36551 )
...
- **TEMP**
- **Update @-mentions to use new history**
Closes #ISSUE
Release Notes:
- N/A
2025-08-20 06:25:07 +00:00
Bennet Bo Fenner
5fb68cb8be
agent2: Token count ( #36496 )
...
Release Notes:
- N/A
---------
Co-authored-by: Agus Zubiaga <agus@zed.dev>
2025-08-19 20:40:31 +00:00
Piotr Osiewicz
05fc0c432c
Fix a bunch of other low-hanging style lints ( #36498 )
...
- **Fix a bunch of low hanging style lints like unnecessary-return**
- **Fix single worktree violation**
- **And the rest**
Release Notes:
- N/A
2025-08-19 21:26:17 +02:00
Conrad Irwin
6ba52a3a42
Re-add history entries for native agent threads ( #36500 )
...
Closes #ISSUE
Release Notes:
- N/A
---------
Co-authored-by: Antonio Scandurra <me@as-cii.com>
2025-08-19 12:08:11 -06:00
Bennet Bo Fenner
6b6eb11643
agent2: Fix tool schemas for Gemini ( #36507 )
...
Release Notes:
- N/A
---------
Co-authored-by: Agus Zubiaga <agus@zed.dev>
2025-08-19 18:06:09 +00:00
Antonio Scandurra
6c255c1973
Lay the groundwork to support history in agent2 ( #36483 )
...
This pull request introduces title generation and history replaying. We
still need to wire up the rest of the history but this gets us very
close. I extracted a lot of this code from `agent2-history` because that
branch was starting to get long-lived and there were lots of changes
since we started.
Release Notes:
- N/A
2025-08-19 14:24:23 +00:00
Piotr Osiewicz
8f567383e4
Auto-fix clippy::collapsible_if violations ( #36428 )
...
Release Notes:
- N/A
2025-08-19 13:27:24 +00:00
Bennet Bo Fenner
790a2a0cfa
agent2: Support preferred_completion_mode
setting ( #36473 )
...
Release Notes:
- N/A
2025-08-19 10:40:02 +00:00
Bennet Bo Fenner
0ea0d466d2
agent2: Port retry logic ( #36421 )
...
Release Notes:
- N/A
2025-08-19 09:41:55 +00:00
Bennet Bo Fenner
b8ddb0141c
agent2: Port rules UI ( #36429 )
...
Release Notes:
- N/A
2025-08-19 11:12:57 +02:00
Cole Miller
7bcea7dc2c
agent2: Support directories in @file mentions ( #36416 )
...
Release Notes:
- N/A
2025-08-19 04:09:43 +00:00
Piotr Osiewicz
9e0e233319
Fix clippy::needless_borrow lint violations ( #36444 )
...
Release Notes:
- N/A
2025-08-18 21:54:35 +00:00
Bennet Bo Fenner
5591fc810e
agent: Restore last used agent session on startup ( #36401 )
...
Release Notes:
- N/A
2025-08-18 10:22:00 +00:00
Bennet Bo Fenner
2eadd5a396
agent2: Make model
of Thread
optional ( #36395 )
...
Related to #36394
Release Notes:
- N/A
2025-08-18 09:56:02 +00:00
Ben Brandt
ea828c0c59
agent2: Emit cancellation stop reason on cancel ( #36381 )
...
Release Notes:
- N/A
---------
Co-authored-by: Antonio Scandurra <me@as-cii.com>
2025-08-18 07:58:30 +00:00
Ben Brandt
332626e582
Allow Permission Request to only require a ToolCallUpdate instead of a full tool call ( #36319 )
...
Release Notes:
- N/A
2025-08-16 15:04:09 +00:00
Bennet Bo Fenner
1e41d86b31
agent2: Set thread_id, prompt_id, temperature on request ( #36246 )
...
Release Notes:
- N/A
2025-08-15 14:23:55 +00:00
Bennet Bo Fenner
10a2426a58
agent2: Port profile selector ( #36244 )
...
Release Notes:
- N/A
2025-08-15 14:06:56 +00:00
Bennet Bo Fenner
f63036548c
agent2: Implement prompt caching ( #36236 )
...
Release Notes:
- N/A
2025-08-15 15:17:56 +02:00
Bennet Bo Fenner
6f3cd42411
agent2: Port Zed AI features ( #36172 )
...
Release Notes:
- N/A
---------
Co-authored-by: Antonio Scandurra <me@as-cii.com>
2025-08-15 11:17:17 +00:00
Conrad Irwin
e5402d5464
Allow editing Agent2 messages ( #36155 )
...
Release Notes:
- N/A
---------
Co-authored-by: Antonio Scandurra <me@as-cii.com>
Co-authored-by: Agus Zubiaga <agus@zed.dev>
2025-08-14 13:39:33 +00:00
Antonio Scandurra
b3d048d6dc
Add back DeletePathTool
to agent2 ( #36168 )
...
This was probably removed accidentally as a result of a merge conflict.
Release Notes:
- N/A
2025-08-14 09:11:27 +00:00
Agus Zubiaga
389d24d7e5
Fully support all mention kinds ( #36134 )
...
Feature parity with the agent1 @mention kinds:
- File
- Symbols
- Selections
- Threads
- Rules
- Fetch
Release Notes:
- N/A
---------
Co-authored-by: Cole Miller <cole@zed.dev>
2025-08-13 20:11:32 +00:00
Ben Brandt
23cd5b59b2
agent2: Initial infra for checkpoints and message editing ( #36120 )
...
Release Notes:
- N/A
---------
Co-authored-by: Antonio Scandurra <me@as-cii.com>
2025-08-13 15:46:28 +00:00
Ben Brandt
2b3dbe8815
agent2: Allow tools to be provider specific ( #36111 )
...
Our WebSearch tool requires access to a Zed provider
Release Notes:
- N/A
2025-08-13 13:22:05 +00:00
Agus Zubiaga
44953375cc
Include mention context in acp-based native agent ( #36006 )
...
Also adds data-layer support for symbols, thread, and rules.
Release Notes:
- N/A
---------
Co-authored-by: Cole Miller <cole@zed.dev>
2025-08-12 13:12:58 +00:00
Antonio Scandurra
2444321756
Support profiles in agent2 ( #36034 )
...
We still need a profile selector.
Release Notes:
- N/A
---------
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
2025-08-12 12:17:48 +00:00
Antonio Scandurra
365b5aa31d
Centralize always_allow
logic when authorizing agent2 tools ( #35988 )
...
Release Notes:
- N/A
---------
Co-authored-by: Cole Miller <cole@zed.dev>
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
Co-authored-by: Agus Zubiaga <agus@zed.dev>
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
2025-08-11 17:22:19 +00:00
Antonio Scandurra
086ea3c619
Port terminal
tool to agent2 ( #35918 )
...
Release Notes:
- N/A
---------
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
2025-08-11 10:31:13 +00:00
Ben Brandt
308cb9e537
Pull action_log into its own crate ( #35959 )
...
Release Notes:
- N/A
2025-08-10 21:57:55 +00:00