Commit graph

23943 commits

Author SHA1 Message Date
Antonio Scandurra
d01995b36c
Miscellaneous UX fixes for agent2 (#36591)
Release Notes:

- N/A
2025-08-23 10:39:26 -04:00
Bennet Bo Fenner
42cc626523
agent2: New thread from summary (#36578)
Release Notes:

- N/A

---------

Co-authored-by: Agus Zubiaga <agus@zed.dev>
Co-authored-by: Cole Miller <cole@zed.dev>
2025-08-23 10:39:26 -04:00
Lukas Wirth
c9b9968b18
remote: Do not leave client hanging on unhandled proto message (#36590)
Otherwise the client will wait for a response that never arrives,
causing the task to lock up

Release Notes:

- N/A
2025-08-23 10:39:26 -04:00
tidely
e9f0fcce50
Fix clippy::manual_map lint violations (#36584)
#36577

Release Notes:

- N/A
2025-08-23 10:39:26 -04:00
Antonio Scandurra
812199233f
Wait for agent2 feature flag before loading panel (#36583)
Release Notes:

- N/A
2025-08-23 10:39:26 -04:00
tidely
eeb690d34f
Enforce style lints which do not have violations (#36580)
Release Notes:

- N/A
2025-08-23 10:39:26 -04:00
Antonio Scandurra
7eee154ea9
Fix mentions roundtrip from/to database and other history bugs (#36575)
Release Notes:

- N/A
2025-08-23 10:39:25 -04:00
tidely
cae072e0a0
Fix clippy::redundant_clone lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few
ints all the way to large data structures and images.

A lot of these were fixed using `cargo clippy --fix --workspace
--all-targets`, however it often breaks other lints and needs to be run
again. This was then followed up with some manual fixing.

I understand this is a large diff, but all the changes are pretty
trivial. Rust is doing some heavy lifting here for us. Once I get it up
to speed with main, I'd appreciate this getting merged rather sooner
than later.

Release Notes:

- N/A
2025-08-23 10:39:25 -04:00
Piotr Osiewicz
a3c89b42f0
lints: A bunch of extra style lint fixes (#36568)
- **lints: Fix 'doc_lazy_continuation'**
- **lints: Fix 'doc_overindented_list_items'**
- **inherent_to_string and io_other_error**
- **Some more lint fixes**
- **lints: enable bool_assert_comparison, match_like_matches_macro and
wrong_self_convention**


Release Notes:

- N/A
2025-08-23 10:39:25 -04:00
Bennet Bo Fenner
90296e6e8d
agent2: Use correct completion intent when generating summary (#36573)
Release Notes:

- N/A
2025-08-23 10:39:25 -04:00
Bennet Bo Fenner
4ca11590ac
agent2: Fix remaining update_model_request_usage todos (#36570)
Release Notes:

- N/A
2025-08-23 10:39:25 -04:00
Finn Evers
1ed012a9ab
Add more string and comment overrides (#36566)
Follow-up to #36469

Part of the issue was that we hadn't defined comment and string
overrides for some languages. Hence, even after the fix edit predictions
would show up in comments for me in e.g. JSONC files.

This PR adds some more overrides where possible for this repo to ensure
this happens less frequently.

Release Notes:

- N/A
2025-08-23 10:39:25 -04:00
Bennet Bo Fenner
3707b42223
agent2: Fix token count not updating when changing model/toggling burn mode (#36562)
Release Notes:

- N/A

---------

Co-authored-by: Antonio Scandurra <me@as-cii.com>
2025-08-23 10:39:25 -04:00
tidely
95ea8f293c
Fix clippy::for_kv_map lint violations (#36493)
Release Notes:

- N/A
2025-08-23 10:39:25 -04:00
Bennet Bo Fenner
9fbbfeb430
agent2: Port more Zed AI features (#36559)
Release Notes:

- N/A

---------

Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
2025-08-23 10:39:25 -04:00
Smit Barmase
c296a2a325
project: Register dynamic capabilities even when registerOptions doesn't exist (#36554)
Closes #36482

Looks like we accidentally referenced
[common/formatting.ts#L67-L70](d90a87f955/client/src/common/formatting.ts (L67-L70))
instead of
[common/client.ts#L2133](d90a87f955/client/src/common/client.ts (L2133)).

Release Notes:

- Fixed code not formatting on save in language servers like Biome.
(Preview Only)
2025-08-23 10:39:25 -04:00
Conrad Irwin
952dd9e45c
ACP history mentions (#36551)
- **TEMP**
- **Update @-mentions to use new history**

Closes #ISSUE

Release Notes:

- N/A
2025-08-23 10:39:25 -04:00
Danilo Leal
539fa3a444
agent2: Port user_modifier_to_send setting (#36550)
Release Notes:

- N/A
2025-08-23 10:39:24 -04:00
Danilo Leal
133d215a31
thread_view: Increase click area of the user rules links (#36549)
Release Notes:

- N/A
2025-08-23 10:39:24 -04:00
Danilo Leal
c1049b1e8c
thread view: Refine the UI a bit (#36504)
Release Notes:

- N/A

---------

Co-authored-by: Agus Zubiaga <agus@zed.dev>
2025-08-23 10:39:24 -04:00
Ben Brandt
73f11a523a
agent_ui: Add check to prevent sending empty messages in MessageEditor (#36545)
Release Notes:

- N/A
2025-08-23 10:39:24 -04:00
Ben Brandt
975a3cc092
Some clippy fixes (#36544)
These showed up today, so just applied the simplifications, which were
mostly switching matches to if let

Release Notes:

- N/A
2025-08-23 10:39:24 -04:00
Conrad Irwin
f1358e5de6
Silence a bucketload of logs (#36534)
Closes #ISSUE

Release Notes:

- Silenced a bunch of logs that were on by default
2025-08-23 10:39:24 -04:00
Agus Zubiaga
961e9b2069
Rename acp flag (#36541)
Release Notes:

- N/A
2025-08-23 10:39:24 -04:00
Cole Miller
d01291e988
Add version detection for CC (#36502)
- Render a helpful message when the installed CC version is too old
- Show the full path for agent binaries when the version is not recent
enough (helps in cases where multiple binaries are installed in
different places)
- Add UI for the case where a server binary is not installed at all
- Refresh thread view after installing/updating server binary

Release Notes:

- N/A
2025-08-23 10:39:24 -04:00
Agus Zubiaga
d6513d90f8
Improve claude tools (#36538)
- Return unified diff from `Edit` tool so model can see the final state
- Format on save if enabled
- Provide `Write` tool
- Disable `MultiEdit` tool
- Better prompting

Release Notes:

- N/A
2025-08-23 10:39:24 -04:00
Agus Zubiaga
4ae570f48d
claude: Include all mentions and images in user message (#36539)
User messages sent to Claude Code will now include the content of all
mentions, and any images included.

Release Notes:

- N/A
2025-08-23 10:39:24 -04:00
Max Brunsfeld
405fb1c3a9
Refactor ssh remoting - make ChannelClient type private (#36514)
This PR is one step in a series of refactors to prepare for having
"remote" projects that do not use SSH. The main use cases for this are
WSL and dev containers.

Release Notes:

- N/A
2025-08-23 10:39:24 -04:00
Marshall Bowers
0d31a81ee8
collab: Make stripe_subscription_id and stripe_subscription_status nullable on billing_subscriptions (#36536)
This PR makes the `stripe_subscription_id` and
`stripe_subscription_status` columns nullable on the
`billing_subscriptions` table.

Release Notes:

- N/A
2025-08-23 10:39:24 -04:00
Conrad Irwin
dc84c736be
Hide old Agent UI when ACP flag set (#36533)
- **Use key value store instead of JSON**
- **Default NewThread to the native agent when flagged**

Closes #ISSUE

Release Notes:

- N/A *or* Added/Fixed/Improved ...
2025-08-23 10:39:24 -04:00
Julia Ryan
5df0807f77
Attach minidump errors to uploaded crash events (#36527)
We see a bunch of crash events with truncated minidumps where they have
a valid header but no events. We think this is due to an issue
generating them, so we're attaching the relevant result to the uploaded
tags.

Release Notes:

- N/A

Co-authored-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2025-08-23 10:39:24 -04:00
Conrad Irwin
6ec4b80b7b
Rebuild recently opened threads for ACP (#36531)
Closes #ISSUE

Release Notes:

- N/A
2025-08-23 10:39:24 -04:00
Julia Ryan
7c1fe1b731
Suspend macOS threads during crashes (#36520)
This should improve our detection of which thread crashed since they
wont be able to resume while the minidump is being generated.

Release Notes:

- N/A
2025-08-23 10:39:24 -04:00
Bennet Bo Fenner
5c9ccc390b
agent2: Token count (#36496)
Release Notes:

- N/A

---------

Co-authored-by: Agus Zubiaga <agus@zed.dev>
2025-08-23 10:39:23 -04:00
Piotr Osiewicz
0d2f70ee8c
Another batch of lint fixes (#36521)
- **Enable a bunch of extra lints**
- **First batch of fixes**
- **More fixes**

Release Notes:

- N/A
2025-08-23 10:39:23 -04:00
Piotr Osiewicz
f61482151a
Fix a bunch of other low-hanging style lints (#36498)
- **Fix a bunch of low hanging style lints like unnecessary-return**
- **Fix single worktree violation**
- **And the rest**

Release Notes:

- N/A
2025-08-23 10:39:23 -04:00
Cole Miller
2a4db70df6
thread_view: Fix issues with images (#36509)
- Clean up failed load tasks for mentions that require async processing
- When dragging and dropping files, hold onto added worktrees until any
async processing has completed; this fixes a bug when dragging items
from outside the project

Release Notes:

- N/A
2025-08-23 10:39:23 -04:00
Umesh Yadav
03d773da99
onboarding: Fix theme selection in system mode (#36484)
Previously, selecting the "System" theme during onboarding would
hardcode the theme based on the device's current mode (e.g., Light or
Dark). This change ensures the "System" setting is saved correctly,
allowing the app to dynamically follow the OS theme by inserting the
correct theme in the config for both light and dark mode.

Release Notes:

- N/A

Signed-off-by: Umesh Yadav <git@umesh.dev>
2025-08-23 10:39:23 -04:00
Conrad Irwin
a73802242a
Re-add history entries for native agent threads (#36500)
Closes #ISSUE

Release Notes:

- N/A

---------

Co-authored-by: Antonio Scandurra <me@as-cii.com>
2025-08-23 10:39:23 -04:00
Bennet Bo Fenner
4ab3d5d1d0
agent2: Fix tool schemas for Gemini (#36507)
Release Notes:

- N/A

---------

Co-authored-by: Agus Zubiaga <agus@zed.dev>
2025-08-23 10:39:23 -04:00
fantacell
6bd4372f32
helix: Uncomment one test (#36328)
There are two tests commented out in the helix file, but one of them
works again. I don't know if this is too little a change to be merged,
but I wanted to suggest it.
The other test might be more complicated though, so I didn't touch it.

Release Notes:

- N/A
2025-08-23 10:39:23 -04:00
Agus Zubiaga
dc9ed7ab94
Split external agent flags (#36499)
Release Notes:

- N/A
2025-08-23 10:39:23 -04:00
Lukas Wirth
fcd95cc0e7
editor: Fix inline diagnostics min column inaccuracy (#36501)
Closes https://github.com/zed-industries/zed/issues/33346

Release Notes:

- Fixed `diagnostic.inline.min_column` being inaccurate
2025-08-23 10:39:23 -04:00
Lukas Wirth
489906c64b
editor: Render dirty and conflict markers in multibuffer headers (#36489)
Release Notes:

- Added rendering of status indicators for multi buffer headers
2025-08-23 10:39:23 -04:00
Smit Barmase
a049c37d01
lsp: Enable dynamic registration for TextDocumentSyncClientCapabilities post revert (#36494)
Follow up: https://github.com/zed-industries/zed/pull/36485

Release Notes:

- N/A
2025-08-23 10:39:22 -04:00
Cole Miller
fa5ff2bd98
Fix Windows test failures not being detected in CI (#36446)
Bug introduced in #35926 

Release Notes:

- N/A
2025-08-23 10:39:22 -04:00
Antonio Scandurra
c65d113f5b
Lay the groundwork to support history in agent2 (#36483)
This pull request introduces title generation and history replaying. We
still need to wire up the rest of the history but this gets us very
close. I extracted a lot of this code from `agent2-history` because that
branch was starting to get long-lived and there were lots of changes
since we started.

Release Notes:

- N/A
2025-08-23 10:39:22 -04:00
Piotr Osiewicz
68d37d3818
Fix unnecessary-mut-passed lint (#36490)
Release Notes:

- N/A
2025-08-23 10:39:22 -04:00
Smit Barmase
99d86ac919
project: Take 2 on Handle textDocument/didSave and textDocument/didChange (un)registration and usage correctly (#36485)
Relands https://github.com/zed-industries/zed/pull/36441 with a
deserialization fix.

Previously, deserializing `"includeText"` into
`lsp::TextDocumentSyncSaveOptions` resulted in a `Supported(false)` type
instead of `SaveOptions(SaveOptions { include_text: Option<bool> })`.

```rs
impl From<bool> for TextDocumentSyncSaveOptions {
    fn from(from: bool) -> Self {
        Self::Supported(from)
    }
}
```

Looks like, while dynamic registartion we only get `SaveOptions` type
and never `Supported` type.
(https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocumentSaveRegistrationOptions)

Release Notes:

- N/A

---------

Co-authored-by: Lukas Wirth <lukas@zed.dev>
2025-08-23 10:39:22 -04:00
Piotr Osiewicz
780d5c7d35
Auto-fix clippy::collapsible_if violations (#36428)
Release Notes:

- N/A
2025-08-23 10:39:22 -04:00