Kirill Bulatov
d38a2b793e
Do not add diagnostics for any selection in the diagnostics panel
2023-11-10 13:35:58 +02:00
Conrad Irwin
cc9fb9dea0
Fix panic caused by focusing the same thing twice
2023-11-09 22:25:46 -07:00
Conrad Irwin
5a711886d4
Refactor to make ModalLayer a View
2023-11-09 22:15:44 -07:00
Conrad Irwin
d4b1d1b528
Move from register_modals to register_workspace_action
2023-11-09 21:51:48 -07:00
Conrad Irwin
e6d6806693
Tidy up some more modal behaviour
2023-11-09 21:11:44 -07:00
Conrad Irwin
a73265ace4
Merge branch 'main' into command_palette2
2023-11-09 20:58:54 -07:00
Conrad Irwin
77d92ff65a
Tidy up
2023-11-09 20:58:35 -07:00
Marshall Bowers
cb8c534dac
theme_importer: Support importing themes containing comments ( #3298 )
...
This PR updates the `theme_importer` with support for parsing theme
files containing comments.
Up until now we've been manually removing comments from the VS Code
theme files.
Release Notes:
- N/A
2023-11-09 19:22:15 -05:00
Marshall Bowers
6bc1cf0fae
Re-import the Synthwave 84 theme ( #3297 )
...
This PR re-imports the Synthwave 84 theme now that we support 3-value
hex colors.
Release Notes:
- N/A
2023-11-09 18:56:42 -05:00
Max Brunsfeld
6f23894b40
Fix editor settings deserialization in editor2
2023-11-09 15:37:46 -08:00
Conrad Irwin
ff15ddf3e0
Render more than one item
2023-11-09 16:36:36 -07:00
Marshall Bowers
8bd02fdadc
Extend RGBA hex color parsing to support 3-value and 4-value variants ( #3295 )
...
This PR extends our support for parsing hex color codes to `Rgba` to
additionally support 3-value (`#rgb`) and 4-value (`#rgba`) formats.
See [here](https://developer.mozilla.org/en-US/docs/Web/CSS/hex-color )
for more details on these hex color variants.
Release Notes:
- N/A
2023-11-09 18:27:47 -05:00
Marshall Bowers
82861e3123
Improve digit duplication
2023-11-09 18:19:58 -05:00
Marshall Bowers
8f5adeb9c3
Improve error conditions when parsing hex colors
2023-11-09 18:00:17 -05:00
Marshall Bowers
417279e01b
Add support for parsing 3-value and 4-value hex codes
2023-11-09 17:45:05 -05:00
Nate Butler
2347576fb5
Extend theme converter to allow multimatching against vscode colors ( #3294 )
...
[[PR Description]]
Adds the ability to specify a vec of VScode syntax scopes to match
against for a given syntax style.
Example:
```rust
pub fn to_vscode(&self) -> Vec<&'static str> {
use ZedSyntaxToken::*;
match self {
SyntaxAttribute => vec!["entity.other.attribute-name"],
SyntaxBoolean => vec!["constant.language"],
SyntaxComment => vec!["comment"],
SyntaxCommentDoc => vec!["comment.block.documentation"],
SyntaxConstant => vec!["constant.character"],
SyntaxConstructor => vec!["entity.name.function.definition.special.constructor"],
SyntaxEmbedded => vec!["meta.embedded"],
SyntaxEmphasis => vec!["markup.italic"],
SyntaxEmphasisStrong => vec![
"markup.bold",
"markup.italic markup.bold",
"markup.bold markup.italic",
],
SyntaxEnum => vec!["support.type.enum"],
SyntaxFunction => vec![
"entity.name.function",
"variable.function",
"support.function",
],
SyntaxKeyword => vec!["keyword"],
SyntaxLabel => vec![
"label",
"entity.name",
"entity.name.import",
"entity.name.package",
],
// .. more styles
}}
```
Useful `settings.json` for testing themes:
```json5
{
// --- Dark Themes ---
"theme": "Ayu Dark"
// "theme": "Ayu Mirage"
// "theme": "Dracula"
// "theme": "Gruvbox Dark Hard"
// "theme": "Gruvbox Dark Medium"
// "theme": "Gruvbox Dark Soft"
// "theme": "Night Owl"
// "theme": "Noctis Obscuro"
// "theme": "Noctis"
// "theme": "Nord"
// "theme": "Palenight (Mild Contrast)"
// "theme": "Palenight Operator"
// "theme": "Palenight"
// "theme": "Rose Pine Moon"
// "theme": "Rose Pine"
// "theme": "Solarized Dark"
// "theme": "Synthwave 84"
// --- Light Themes ---
// "theme": "Ayu Light"
// "theme": "Gruvbox Light Hard"
// "theme": "Gruvbox Light Medium"
// "theme": "Gruvbox Light Soft"
// "theme": "Noctis Lux"
// "theme": "Rose Pine Dawn"
// "theme": "Solarized Light"
}
```
Release Notes:
- N/A
2023-11-09 17:40:10 -05:00
Max Brunsfeld
b6eef26f91
Merge branch 'main' into search-query-suggestion-fixes
2023-11-09 14:18:17 -08:00
Conrad Irwin
fa153a0d56
Make command dispatching work
2023-11-09 15:14:23 -07:00
Max Brunsfeld
6b8ce3cc85
Add a setting for when to seed the search query from the text under the cursor
2023-11-09 14:03:14 -08:00
Nate Butler
6b65acaa99
regenerate themes, format
2023-11-09 16:48:35 -05:00
Nate Butler
024fb4f818
Remove unused import
2023-11-09 16:41:58 -05:00
Nate Butler
4cd37e6e62
Extend theme converter to allow multimatching against vscode colors
2023-11-09 16:38:48 -05:00
Max Brunsfeld
28d3d21108
Generalize Refineable derive macro to derive arbitrary traits on the refinement type
2023-11-09 13:23:31 -08:00
Max Brunsfeld
dba41e99dd
Avoid suggesting search query if cursor is not on a word
2023-11-09 12:33:30 -08:00
Marshall Bowers
31a6409a4c
Refine theme styles ( #3291 )
...
This PR refines a number of styles in the default theme, as well as
updates the theme importer to support importing syntax styles from VS
Code themes.
Release Notes:
- N/A
2023-11-09 15:32:10 -05:00
Marshall Bowers
7b489f5e2e
Allow user-theme related methods to be unused
2023-11-09 15:16:59 -05:00
Nate Butler
1c6a960bbf
Deal with special case where a VSCode theme doesn't have a foreground
color
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-11-09 14:53:04 -05:00
Nate Butler
54157eb99a
Finish passing Syntax from VSCode themes to Zed Themes
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-11-09 14:41:26 -05:00
Max Brunsfeld
c6b76d908f
Use normal JS comments within JSX tags and JSX expression blocks ( #3290 )
...
This fix only required changing the `overrides` queries for JavaScript
and TSX. I've made the fix in both the `zed2` and `zed` crates.
Release Notes:
- Fixed an issue in JavaScript and TSX files, where the 'toggle
comments' command used the wrong comment syntax inside of JSX tags and
expressions within JSX.
2023-11-09 11:15:08 -08:00
Max Brunsfeld
e50318e7e1
Duplicate buffer test changes in language2 version
2023-11-09 11:09:49 -08:00
Max Brunsfeld
4c89b2885e
Use normal JS comments within JSX tags and JSX expression blocks
...
Co-authored-by: Kirill <kirill@zed.dev>
2023-11-09 10:58:33 -08:00
Nate Butler
ff053890cf
Extend UserSyntax to allow font_style and font_weight to be specified
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-11-09 13:46:08 -05:00
Conrad Irwin
72de5cb6ce
Fix escape in GoToLine with new event emitter ( #3289 )
...
[[PR Description]]
Release Notes:
- N/A
2023-11-09 11:23:26 -07:00
Marshall Bowers
978cff8095
Use IndexMap
for a deterministic order when importing syntax colors
2023-11-09 13:12:36 -05:00
Marshall Bowers
1f0fccc353
Reorganize theme_importer
2023-11-09 13:07:32 -05:00
Marshall Bowers
34e31fd489
Properly emit UserHighlightStyle
s
2023-11-09 12:59:20 -05:00
Conrad Irwin
3c689ba33e
Fix escape in GoToLine with new event emitter
2023-11-09 10:52:17 -07:00
Piotr Osiewicz
a1d9f351db
Some more woogaloo around action dispatch
...
Co-authored-by: Conrad <conrad@zed.dev>
2023-11-09 18:51:41 +01:00
Marshall Bowers
ff19a0ca18
Add importing-themes
feature flag to theme2
crate
...
When this feature is set the `themes` module won't be compiled.
This allows us to run the `theme_importer` even when the `themes` module
has compile errors in it.
2023-11-09 12:49:16 -05:00
Marshall Bowers
60eae3e50a
Emit unique highlights for each syntax token
2023-11-09 12:46:37 -05:00
Piotr Osiewicz
194d615691
Fix up keybindings propagation
...
Co-authored-by: Conrad <conrad@zed.dev>
2023-11-09 18:33:36 +01:00
Nate Butler
efd1db1b09
WIP – Add Syntax themes to importer
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-11-09 12:30:53 -05:00
Piotr Osiewicz
d184e0d426
Start working on command_palette2
2023-11-09 17:54:05 +01:00
Julia
9cb14c189b
zed2: Get tsserver running again
2023-11-09 11:43:40 -05:00
Nate Butler
4b5ca3e420
Allow imported themes to refine StatusColors
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-11-09 11:30:59 -05:00
Nate Butler
7253160b04
Add more vscode colors
2023-11-09 11:01:18 -05:00
Kirill Bulatov
b157453630
Do not use prettier for formatting node_modules/** files ( #3286 )
...
Fixes
> the most annoying thing i'm running into right now is that when i'm
patching something inside node_modules, Zed tries to pretty-format it
according to my prettier config. this messes up the patch because it has
formatting changes now. i need the pretty formatting on save to be off
inside node_modules, that never makes sense
feedback from #influencers
Do note though, that language servers will still format any file inside
node_modules, but at least it's not prettier now.
VSCode seem to format the node_modules/** files via language servers
too, so that seems ok for now, and the rest could be fixed during
> "project diagnostics" (eslint) seem to be running inside node_modules,
e.g. i'm seeing 3182 "errors" in my project. that doesn't make sense and
probably wastes resources in addition to being annoying
feedback later.
Release Notes:
- Fixed prettier formatting files inside node_modules
2023-11-09 17:42:58 +02:00
Kirill Bulatov
f55d89088b
Port changes to gpui2
2023-11-09 17:18:41 +02:00
Julia
27b3378020
Get tsserver running again ( #3277 )
...
Release Notes:
- Fixed a few issues preventing Javascript/Typescript language server
from working with latest upstream changes.
2023-11-09 10:14:36 -05:00
Kirill Bulatov
2e957bc564
Do not propose prettier formatters for documents in node_modules/
2023-11-09 14:49:37 +02:00