Julia
c58abf1b0b
Add test for new tab order history behavior
2022-11-01 13:29:21 -04:00
Kay Simmons
4e35b26365
Avoid reordering items by adding an activation history to panes, and remove tab reordering hack
...
Co-Authored-By: Julia Risley <julia@zed.dev>
2022-10-31 14:10:34 -07:00
Nate Butler
9148e1d30a
Update icons
...
- `x_mark_thin` combined into `x_mark`
- updated many icons
- remove unused icons
2022-10-28 12:59:05 -04:00
K Simmons
8cde64d3f6
extract dragged item target
2022-10-24 23:32:00 -07:00
K Simmons
d7b8a189e4
fix issue where empty pane is created
2022-10-24 23:32:00 -07:00
K Simmons
cfde3e348c
Add pane splitting by dragged item. Works, but the overlay doesn't clear quite right
2022-10-24 23:31:58 -07:00
K Simmons
70e2951e35
add mouse region handler bool for adding the handler above the child
2022-10-24 23:30:35 -07:00
Julia
ba35536664
Add action to move active item into the dock
...
Co-Authored-By: Kay Simmons <kay@zed.dev>
2022-10-24 23:30:35 -07:00
Julia
b9f9819637
Handle tab drag end on pane items to insert after active item
...
Co-Authored-By: Kay Simmons <kay@zed.dev>
2022-10-24 23:30:35 -07:00
Nathan Sobo
6e363e464c
Start on view-level dispatch approach for keyboard events
2022-10-16 11:46:31 -06:00
Nathan Sobo
bc03592912
Only invalidate parent view on click/hover if we read that state when rendering
...
Co-Authored-By: Max Brunsfeld <max@zed.dev>
2022-10-14 18:09:15 -06:00
Antonio Scandurra
a5a60eb854
Log view name alongside error in ChildView
2022-10-13 15:44:01 +02:00
K Simmons
1d8717f4de
Remove focus filtering from gpui so all focus events result in focus-in and focus-out calls
...
Remove pane focused event in favor of focus_in at the workspace level
Added is_child to ViewContext to determine if a given view is a child of the current view
Fix issue where dock would get in a infinite loop when activated after dragging an item out of it
Fix issue where the last focused view in an item was not correctly refocused when a pane is focused after switching active tabs
Co-Authored-By: Mikayla Maki <mikayla@zed.dev>
2022-10-12 15:10:00 -07:00
Mikayla Maki
1905ba55d4
Fixed minor issue with pane defocusing Co-Authored-By: kay@zed.dev
2022-09-27 17:05:21 -07:00
K Simmons
1ce48f4a94
Minor improvements to dock visuals, rework dock keybindings, and fix panic on split when dock is active
2022-09-16 12:55:36 -07:00
K Simmons
3b9b2cd443
Add tests for the dock
2022-09-13 19:18:05 -07:00
K Simmons
0b5952e1bd
Fix incorrect rendering of toolbar in right anchored dock
...
Make dock keybinding activate the dock if it wasn't hidden, and hide it if it was already active
Make clicking the expanded dock wash, hide the dock
Fix some issues with programmatically activating other panes, not hiding the dock
Tweak dock anchor menu text
Swap dock hide button for thin variant
Fix dock sidebar interactions
Add clicked state to search button and fix presenter issue sending clicked events when mouse not overlapping MouseRegion
Co-Authored-By: Mikayla Maki <mikayla@zed.dev>
2022-09-13 15:17:27 -07:00
K Simmons
df59b28aaf
Extract panel resize code from sidebar into Resizable element
...
Make resizable work in vertical axis
Make dock resizable
Have dock preserve size based on Anchor position
Make pane buttons work more correctly in pathological cases
Sync status bar dock button with dock visibility/anchor position
Co-Authored-By Mikayla Maki <mikayla@zed.dev>
2022-09-12 18:32:15 -07:00
K Simmons
f2b72eb6d2
WIP working on resizable dock
2022-09-12 14:24:57 -07:00
K Simmons
1dfa711d2e
Fix some pane button issues
2022-09-11 15:52:09 -07:00
K Simmons
6b26965074
Permanent fix to repeat MouseRegion Tag failure in Workspace
...
Polish tab bar buttons
Co-Authored-By: Mikayla Maki <mikayla@zed.dev>
2022-09-11 15:34:10 -07:00
K Simmons
69ecbb644d
DOCK WORKING!
...
Update editor element to use mouse regions instead of dispatch event for mouse events
Fix bug in presenter where mouse region handlers were stored on click and called instead of more up to date handlers from subsequent renders
Changed MouseRegion to require discriminants in all cases
Add scroll wheel event to MouseRegion
Polished a bunch of dock inconsistencies
Co-Authored-By: Mikayla Maki <mikayla@zed.dev>
2022-09-11 15:32:20 -07:00
K Simmons
59fd967793
Swapped keyboard binding and did some minor tweaks to style and focus
2022-09-11 15:31:44 -07:00
K Simmons
b88abcacac
WIP dock split button and default item
2022-09-11 15:31:44 -07:00
Mikayla Maki
b9a6336995
Initial explorations into docks
2022-09-11 15:31:44 -07:00
Max Brunsfeld
636f35f384
Avoid undesirable pane item deduping with multibuffers
2022-09-02 11:59:10 -07:00
K Simmons
91080fb998
Don't panic if a tab isn't present in a from tab when dragged
2022-09-01 15:17:25 -07:00
K Simmons
227cc66594
Simulate mouse up if mouse was released outside window, don't report dragged payload if it was dragged from a different window
2022-08-31 14:06:38 -07:00
K Simmons
3cc07c1099
Fix some drag and drop issues including the mouse cursor not being locked to pointer, tooltips being incorrect when a dragged tab is used, and some subscription leaks from panes
2022-08-26 15:43:15 -07:00
K Simmons
22f62ee137
Add tests for Pane::add_item
2022-08-25 16:21:44 -07:00
K Simmons
042ece00b1
Drag and drop tabs working. all known bugs fixed
2022-08-25 11:14:24 -07:00
K Simmons
0a97a9c0fd
Change dragged tab styling
2022-08-23 18:02:01 -07:00
K Simmons
5c38021a4d
Move pane item reordering from activate_tab to add_item_at.
...
Co-authored-by: nathan@zed.dev
2022-08-23 17:33:01 -07:00
K Simmons
de3acbd75b
Introduce ReorderBehavior to pane, and address drag and drop offset error
2022-08-23 15:41:59 -07:00
K Simmons
0d6125889f
WIP
2022-08-22 16:16:39 -07:00
K Simmons
03a344a272
properly constrained tab
2022-08-22 16:16:39 -07:00
K Simmons
ab9f073443
fixed merge errors
2022-08-22 16:16:39 -07:00
K Simmons
133c194f4a
wip tab drag and drop
2022-08-22 16:16:39 -07:00
K Simmons
a650c146f1
more event wip
2022-08-22 16:16:39 -07:00
K Simmons
53add253b6
wip new mouse region events
2022-08-22 16:16:39 -07:00
ForLoveOfCats
8ba2f77148
One big cleanup pass of clippy lints
...
Co-authored-by: Mikayla <mikayla@zed.dev>
2022-08-10 16:51:01 -07:00
K Simmons
6f180ed822
Pane focus working. Modals seem broken now
2022-08-09 17:15:54 -07:00
K Simmons
690ea57211
WIP compiling but failing with circular reference
2022-08-09 17:15:52 -07:00
K Simmons
6442ec59e7
Switch action dispatch to use MutableAppContext parent utilities and delete parent map from presenter
2022-08-09 17:09:28 -07:00
K Simmons
4271eb3624
Event dispatch moved to MutableAppContext. No longer dispatches from presenter. Not currently handling key presses properly
2022-08-09 17:09:16 -07:00
Mikayla Maki
4549395d02
update icon
2022-08-04 11:58:55 -07:00
Mikayla Maki
314c26e4ec
Removed icons
2022-08-04 08:42:42 -07:00
Mikayla Maki
96cc6d5ce5
Added icons to context menu
2022-08-03 16:47:41 -07:00
Mikayla Maki
bf0ec13e65
New button
2022-08-03 15:59:25 -07:00
Keith Simmons
4ff007eaab
Merge pull request #1414 from zed-industries/fix-theme-issues
...
Fix tab bar themes
2022-07-26 11:55:17 -07:00