Compare commits

...
Sign in to create a new pull request.

2 commits

Author SHA1 Message Date
Antonio Scandurra
0b32bb5ff7 v0.61.1 2022-10-25 16:36:39 +02:00
Antonio Scandurra
70cf542408 Merge pull request #1808 from zed-industries/fix-diagnostics-on-rust
Match progress token's prefix to detect disk-based diagnostic progress
2022-10-25 16:35:32 +02:00
5 changed files with 12 additions and 7 deletions

2
Cargo.lock generated
View file

@ -7531,7 +7531,7 @@ dependencies = [
[[package]] [[package]]
name = "zed" name = "zed"
version = "0.61.0" version = "0.61.1"
dependencies = [ dependencies = [
"activity_indicator", "activity_indicator",
"anyhow", "anyhow",

View file

@ -2262,8 +2262,11 @@ impl Project {
return; return;
} }
let is_disk_based_diagnostics_progress = let is_disk_based_diagnostics_progress = disk_based_diagnostics_progress_token
Some(token.as_ref()) == disk_based_diagnostics_progress_token.as_deref(); .as_ref()
.map_or(false, |disk_based_token| {
token.starts_with(disk_based_token)
});
match progress { match progress {
lsp::WorkDoneProgress::Begin(report) => { lsp::WorkDoneProgress::Begin(report) => {

View file

@ -644,7 +644,9 @@ async fn test_disk_based_diagnostics_progress(cx: &mut gpui::TestAppContext) {
let mut events = subscribe(&project, cx); let mut events = subscribe(&project, cx);
let fake_server = fake_servers.next().await.unwrap(); let fake_server = fake_servers.next().await.unwrap();
fake_server.start_progress(progress_token).await; fake_server
.start_progress(format!("{}/0", progress_token))
.await;
assert_eq!( assert_eq!(
events.next().await.unwrap(), events.next().await.unwrap(),
Event::DiskBasedDiagnosticsStarted { Event::DiskBasedDiagnosticsStarted {
@ -670,7 +672,7 @@ async fn test_disk_based_diagnostics_progress(cx: &mut gpui::TestAppContext) {
} }
); );
fake_server.end_progress(progress_token); fake_server.end_progress(format!("{}/0", progress_token));
assert_eq!( assert_eq!(
events.next().await.unwrap(), events.next().await.unwrap(),
Event::DiskBasedDiagnosticsFinished { Event::DiskBasedDiagnosticsFinished {

View file

@ -3,7 +3,7 @@ authors = ["Nathan Sobo <nathansobo@gmail.com>"]
description = "The fast, collaborative code editor." description = "The fast, collaborative code editor."
edition = "2021" edition = "2021"
name = "zed" name = "zed"
version = "0.61.0" version = "0.61.1"
[lib] [lib]
name = "zed" name = "zed"

View file

@ -93,7 +93,7 @@ impl LspAdapter for RustLspAdapter {
} }
async fn disk_based_diagnostics_progress_token(&self) -> Option<String> { async fn disk_based_diagnostics_progress_token(&self) -> Option<String> {
Some("rustAnalyzer/cargo check".into()) Some("rust-analyzer/checkOnSave".into())
} }
async fn process_diagnostics(&self, params: &mut lsp::PublishDiagnosticsParams) { async fn process_diagnostics(&self, params: &mut lsp::PublishDiagnosticsParams) {