
Added [rhysd/actionlint](https://github.com/rhysd/actionlint/) a static checker for GitHub Actions workflow files. Install locally with `brew install actionlint` the run with `actionlint`. Inspired by: https://github.com/zed-industries/zed/pull/34704 which yielded this observation: > In github actions: > 1. strings are truthy > 2. `${{ }}` will become a string if it doesn't wrap the whole value. > > So `if: false && true` becomes `false` > and `if: ${{ false && true }}` becomes `false` > but `if: false && ${{ true }}` becomes `"false && true"` which evaluates true > The reason you sometimes need `${{ }}` is because YAML doesn't like `!` > so `if: !false` is invalid yaml > and `if: ${{ !false }}` works just fine. Changes: - Add `actionlint` job - Refactor `job_spec` job to be more readable - Fix all `actionlint` and `shellcheck` errors in Actions workflows (62 in all) - Add `self-mini-macos` and `self-32vcpu-windows-2022` labels to self-hosted runners. Not strictly related, but useful if you need to take a runner out of the rotation (since `macOS`, `self-hosted`, and `ARM64` are auto-set and cannot be added/removed). - Change ci.yml macos_relase to target `self-mini-macos` instead of `bundle` which was previously deprecated. This would've caught the error fixed in https://github.com/zed-industries/zed/pull/34704. Here's what that [job failure](https://github.com/zed-industries/zed/actions/runs/16376993944/job/46279281842?pr=34729) would've looked like. Release Notes: - N/A
70 lines
2.5 KiB
YAML
70 lines
2.5 KiB
YAML
name: Release Actions
|
|
|
|
on:
|
|
release:
|
|
types: [published]
|
|
|
|
jobs:
|
|
discord_release:
|
|
if: github.repository_owner == 'zed-industries'
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Get release URL
|
|
id: get-release-url
|
|
run: |
|
|
if [ "${{ github.event.release.prerelease }}" == "true" ]; then
|
|
URL="https://zed.dev/releases/preview/latest"
|
|
else
|
|
URL="https://zed.dev/releases/stable/latest"
|
|
fi
|
|
|
|
echo "URL=$URL" >> "$GITHUB_OUTPUT"
|
|
- name: Get content
|
|
uses: 2428392/gh-truncate-string-action@b3ff790d21cf42af3ca7579146eedb93c8fb0757 # v1.4.1
|
|
id: get-content
|
|
with:
|
|
stringToTruncate: |
|
|
📣 Zed [${{ github.event.release.tag_name }}](<${{ steps.get-release-url.outputs.URL }}>) was just released!
|
|
|
|
${{ github.event.release.body }}
|
|
maxLength: 2000
|
|
truncationSymbol: "..."
|
|
- name: Discord Webhook Action
|
|
uses: tsickert/discord-webhook@c840d45a03a323fbc3f7507ac7769dbd91bfb164 # v5.3.0
|
|
with:
|
|
webhook-url: ${{ secrets.DISCORD_WEBHOOK_URL }}
|
|
content: ${{ steps.get-content.outputs.string }}
|
|
|
|
send_release_notes_email:
|
|
if: github.repository_owner == 'zed-industries' && !github.event.release.prerelease
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: Check if release was promoted from preview
|
|
id: check-promotion-from-preview
|
|
run: |
|
|
VERSION="${{ github.event.release.tag_name }}"
|
|
PREVIEW_TAG="${VERSION}-pre"
|
|
|
|
if git rev-parse "$PREVIEW_TAG" > /dev/null 2>&1; then
|
|
echo "was_promoted_from_preview=true" >> "$GITHUB_OUTPUT"
|
|
else
|
|
echo "was_promoted_from_preview=false" >> "$GITHUB_OUTPUT"
|
|
fi
|
|
|
|
- name: Send release notes email
|
|
if: steps.check-promotion-from-preview.outputs.was_promoted_from_preview == 'true'
|
|
run: |
|
|
TAG="${{ github.event.release.tag_name }}"
|
|
cat << 'EOF' > release_body.txt
|
|
${{ github.event.release.body }}
|
|
EOF
|
|
jq -n --arg tag "$TAG" --rawfile body release_body.txt '{version: $tag, markdown_body: $body}' \
|
|
> release_data.json
|
|
curl -X POST "https://zed.dev/api/send_release_notes_email" \
|
|
-H "Authorization: Bearer ${{ secrets.RELEASE_NOTES_API_TOKEN }}" \
|
|
-H "Content-Type: application/json" \
|
|
-d @release_data.json
|