Finn Evers 1ecd00a113 editor: Ensure minimap is shown when show_minimap is toggled to true (#30326) ... Follow-up of #30285 This PR ensures the action added in the linked PR also works when the user does not have the minimap enabled via settings. Currently, the toggle only works when the user has already enabled the minimap in their settings. This happens because in b4fbb9bc08/crates/editor/src/element.rs (L7160-L7164) as well as b4fbb9bc08/crates/editor/src/element.rs (L1542) we check for the user configuration before reserving space for the minimap as well as layouting it and because in b4fbb9bc08/crates/editor/src/editor.rs (L16404) with b4fbb9bc08/crates/editor/src/editor_settings.rs (L132-L134) we would not even create a minimap when the user disabled it via their settings. --- This PR fixes this by ensuring a minimap is created on the toggle issue as well as lifting some of the restrictions. Since we are always only returning a minimap in b4fbb9bc08/crates/editor/src/editor.rs (L16443-L16445) when `show_minimap` is set to `true`, we can assume in the rendering code that if a minimap is present, it should be layouted and rendered no matter if `ShowMinimap` is currently set to `Never`. We can do this since `show_minimap` always reflects the current user configuration, see b4fbb9bc08/crates/editor/src/editor.rs (L18163-L18164) I also removed the minimap deletion/recreation on the toggling of `show_minimap`, since this is not really needed - once we have stored a minimap editor within the editor, `show_minimap` is sufficient to ensure that it is only shown when the user requests it. Notice that we still will never create a minimap unless neccesary. Lastly, I updated the `supports_minimap` check to account for the fact that the minimap is currently disabled entirely for multibuffers. --- One thing I ~~did not tackle here~~ tackled in the second commit is that due to `show_minimap` now being exposed to the user, it is possible to enable the minimap for all full mode editors, e.g. the agent text thread editor <img width="592" alt="grafik" src="https://github.com/user-attachments/assets/5f6c0e8b-45f9-44e8-9625-9d51c1480f98" /> which should most likely not be possible when the minimap is programmatically disabled. Release Notes: - N/A		2025-05-09 08:32:31 +03:00
..
contents	Fix bundle script	2023-11-17 17:44:41 -08:00
resources	macOS: Add support for external file managers to open directory in Zed (#26357)	2025-03-10 15:21:39 +05:30
src	editor: Ensure minimap is shown when show_minimap is toggled to true (#30326)	2025-05-09 08:32:31 +03:00
build.rs	call: Fix crash when screensharing on MacOS (#28784)	2025-04-15 16:36:08 +00:00
Cargo.toml	Remove assistant crate (#30168)	2025-05-07 23:05:38 +00:00
LICENSE-GPL	chore: Change AGPL-licensed crates to GPL (except for collab) (#4231)	2024-01-24 00:26:58 +01:00
RELEASE_CHANNEL	Restore the default release channel (#23671)	2025-01-26 09:19:24 +00:00