ZIm/crates/dap_adapters/src
Piotr Osiewicz a305eda8d1
debugger: Relax implementation of validate_config to not run validation (#31785)
When we moved to schema-based debug configs, we've added validate_config
- a trait method
that is supposed to both validate the configuration and determine
whether it is a launch configuration
or an attach configuration.

The validation bit is a bit problematic though - we received reports on
Discords about
scenarios not starting up properly; it turned out that Javascript's
implementation was overly strict.
Thus, I got rid of any code that tries to validate the config - let's
let the debug adapter itself
decide whether it can digest the configuration or not. validate_config
is now left unimplemented for most
DebugAdapter implementations (except for PHP), because all adapters use
`request`: 'launch'/'attach' for that.
Let's leave the trait method in place though, as nothing guarantees this
to be true for all adapters.

cc @Anthony-Eid

Release Notes:

- debugger: Improved error messages when the debug scenario is not
valid.
- debugger: Fixed cases where valid configs were rejected.
2025-05-30 23:08:41 +02:00
..
codelldb.rs debugger: Relax implementation of validate_config to not run validation (#31785) 2025-05-30 23:08:41 +02:00
dap_adapters.rs go: Use delve-dap-shim for spawning delve (#31700) 2025-05-29 21:19:56 +02:00
gdb.rs debugger: Relax implementation of validate_config to not run validation (#31785) 2025-05-30 23:08:41 +02:00
go.rs debugger: Relax implementation of validate_config to not run validation (#31785) 2025-05-30 23:08:41 +02:00
javascript.rs debugger: Relax implementation of validate_config to not run validation (#31785) 2025-05-30 23:08:41 +02:00
php.rs debugger: Relax implementation of validate_config to not run validation (#31785) 2025-05-30 23:08:41 +02:00
python.rs debugger: Relax implementation of validate_config to not run validation (#31785) 2025-05-30 23:08:41 +02:00
ruby.rs debugger: Relax implementation of validate_config to not run validation (#31785) 2025-05-30 23:08:41 +02:00