ZIm/crates
Finn Evers 4280bff10a
Reapply "ui: Account for padding of parent container during scrollbar layout" (#30577)
This PR reapplies #27402 which was reverted in
https://github.com/zed-industries/zed/pull/30544 due to the issue
@ConradIrwin reported in
https://github.com/zed-industries/zed/pull/27402#issuecomment-2871745132.
The reported issue is already present on main but not visible, see
https://github.com/zed-industries/zed/pull/27402#issuecomment-2872546903
for more context and reproduction steps.

The fix here was to move the padding for the hover popover up to the
parent container. This does not fix the underlying problem but serves as
workaround without any disadvantages until a better solution is found. I
would currently guess that the underlying issue might be related to some
rem-size calculations for small font sizes or something similar (e.g.
https://github.com/zed-industries/zed/pull/22732 could possibly be
somewhat related).

Notably, the fix here does not cause any difference in layouting (the
following screenshots are actually distinct images), yet fixes the
problem at hand.

### Default font size (`15px`) 

| `main` | This PR |
| --- | --- |
|
![main_large](https://github.com/user-attachments/assets/66d38827-9023-4f78-9ceb-54fb13c21e41)
|![PR](https://github.com/user-attachments/assets/7af82bd2-2732-4cba-8d4b-54605d6ff101)
|

### Smaller font size (`12px`)

| `main` | This PR |
| --- | --- |
|
![pr_large](https://github.com/user-attachments/assets/d43be6e6-6840-422c-baf0-368aab733dac)
|
![PR](https://github.com/user-attachments/assets/43f60b2b-2578-45d2-bcab-44edf2612ce2)
|

Furthermore, for the second scenario, the popover would be scrollable on
main. As there is no scrollbar in the second image for this PR, this no
longer happens with this branch.


Release Notes:

- N/A
2025-05-14 13:26:14 +02:00
..
activity_indicator Add a way to clear activity indicator (#30156) 2025-05-07 17:50:52 +00:00
agent agent: Overwrite files more cautiously (#30649) 2025-05-14 10:40:44 +03:00
anthropic Add image input support for OpenAI models (#30639) 2025-05-13 17:32:42 +02:00
askpass askpass: Remove attempt to surface friendly error if zed exe path is not executable before use in askpass script (#30396) 2025-05-09 15:37:19 +00:00
assets Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
assistant_context_editor context_editor: Allow copying entire line when selection is empty (#30612) 2025-05-13 21:23:19 +00:00
assistant_settings Deny unknown keys in settings in JSON schema so user gets warnings but settings still parses (#30583) 2025-05-12 17:48:36 -04:00
assistant_slash_command Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
assistant_slash_commands assistant_slash_commands: Be more precise in content type matching (#29124) 2025-05-06 04:38:03 +00:00
assistant_tool Have read_file support images (#30435) 2025-05-13 10:58:00 +02:00
assistant_tools agent: Overwrite files more cautiously (#30649) 2025-05-14 10:40:44 +03:00
audio Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
auto_update Add a way to clear activity indicator (#30156) 2025-05-07 17:50:52 +00:00
auto_update_helper Update block diagnostics (#28006) 2025-04-15 09:35:13 -06:00
auto_update_ui Restyle notification close control (#30262) 2025-05-08 14:10:30 +00:00
aws_http_client Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
bedrock bedrock: Fix Claude 3.5 Haiku support (#30560) 2025-05-12 12:45:35 +00:00
breadcrumbs breadcrumbs: Update multibuffer to match singleton (#28267) 2025-04-07 20:26:55 +00:00
buffer_diff Fix diff recalculation hang (#28377) 2025-04-10 22:58:41 +00:00
call Deny unknown keys in settings in JSON schema so user gets warnings but settings still parses (#30583) 2025-05-12 17:48:36 -04:00
channel Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
cli Try to weak-link ScreenCaptureKit always (#28585) 2025-04-11 17:38:14 +00:00
client Separate timeout and connection dropped errors out (#30457) 2025-05-10 15:12:58 +03:00
clock Add the ability to follow the agent as it makes edits (#29839) 2025-05-04 08:28:39 +00:00
collab Separate timeout and connection dropped errors out (#30457) 2025-05-10 15:12:58 +03:00
collab_ui Update panels serialization from global to per-workspace (#30652) 2025-05-14 00:05:42 +05:30
collections Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
command_palette Simplify the SerializableItem::cleanup implementation (#29567) 2025-04-28 22:15:24 +00:00
command_palette_hooks Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
component component: Component crate cleanup (#29967) 2025-05-06 03:41:52 +00:00
context_server context_store: Refactor state management (#29910) 2025-05-05 21:36:12 +02:00
copilot Add image input support for OpenAI models (#30639) 2025-05-13 17:32:42 +02:00
credentials_provider Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
dap debugger: Show language icons in debug scenario picker (#30662) 2025-05-14 00:50:58 +02:00
dap_adapters debugger: Show language icons in debug scenario picker (#30662) 2025-05-14 00:50:58 +02:00
db Simplify the SerializableItem::cleanup implementation (#29567) 2025-04-28 22:15:24 +00:00
debug_adapter_extension debugger: Add extensions support (#30625) 2025-05-13 22:42:51 +00:00
debugger_tools Rename debug: commands to dev: (#30675) 2025-05-14 11:15:27 +02:00
debugger_ui debugger: Fix launch picker program arg not using relative paths (#30680) 2025-05-14 09:51:13 +00:00
deepseek Default to fast model for thread summaries and titles + don't include system prompt / context / thinking segments (#29102) 2025-04-19 23:26:29 +00:00
diagnostics Allow to hide more buttons with the settings (#30565) 2025-05-12 13:34:52 +00:00
docs_preprocessor Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
editor Reapply "ui: Account for padding of parent container during scrollbar layout" (#30577) 2025-05-14 13:26:14 +02:00
eval agent: Overwrite files more cautiously (#30649) 2025-05-14 10:40:44 +03:00
extension debugger: Add extensions support (#30625) 2025-05-13 22:42:51 +00:00
extension_api debugger: Add extensions support (#30625) 2025-05-13 22:42:51 +00:00
extension_cli Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
extension_host debugger: Add extensions support (#30625) 2025-05-13 22:42:51 +00:00
extensions_ui Suggest nim extension for *.nim files (#29912) 2025-05-05 11:46:42 +00:00
feature_flags agent: Remove feature flag checks (#30055) 2025-05-06 21:38:05 -04:00
feedback feedback: Update issue template URL (#28790) 2025-04-15 21:36:30 -04:00
file_finder Allow opening the FS root dir as a remote project (#30190) 2025-05-07 16:50:57 -07:00
file_icons Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
fs windows: Remove extra empty line when loading default settings (#30344) 2025-05-09 19:00:16 +08:00
fsevent Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
fuzzy Fix out-of-bounds panic in fuzzy matcher with Unicode/multibyte characters (#30546) 2025-05-12 14:43:14 +00:00
git Improve handling of remote-tracking branches in the picker (#29744) 2025-05-01 21:24:26 -04:00
git_hosting_providers VSCode Settings import (#29018) 2025-04-23 20:54:09 +00:00
git_ui zed: Reduce clones (#30550) 2025-05-12 10:09:23 +00:00
go_to_line editor: Add minimap (#26893) 2025-05-07 23:11:09 +03:00
google_ai Add support for getting the token count for all parts of Gemini generation requests (#29630) 2025-05-04 21:32:45 +00:00
gpui Reapply "ui: Account for padding of parent container during scrollbar layout" (#30577) 2025-05-14 13:26:14 +02:00
gpui_macros Rename regex search tool to grep and accept an include glob pattern (#29100) 2025-04-20 00:53:30 +00:00
gpui_tokio Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
html_to_markdown Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
http_client Remove individual URL overrides for LLM service (#30290) 2025-05-08 17:54:46 +00:00
http_client_tls Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
icons agent: Fix layout shift due to the "Generating" label (#30422) 2025-05-09 16:20:14 -03:00
image_viewer Add the ability to follow the agent as it makes edits (#29839) 2025-05-04 08:28:39 +00:00
indexed_docs indexed_docs: Remove some unnecessary cloning (#30236) 2025-05-08 10:59:56 +00:00
inline_completion Show edit predictions usage in status bar menu (#29046) 2025-04-18 14:15:19 +00:00
inline_completion_button zeta: Do not show usage for copilot/supermaven (#30563) 2025-05-12 14:03:50 +00:00
install_cli install_cli: Show feedback when installing CLI from welcome screen (#28532) 2025-04-11 01:47:40 +05:30
journal VSCode Settings import (#29018) 2025-04-23 20:54:09 +00:00
language debugger: Show language icons in debug scenario picker (#30662) 2025-05-14 00:50:58 +02:00
language_extension debugger/extensions: Revert changes to extension store related to language config (#30225) 2025-05-08 14:01:39 +02:00
language_model agent: Remove unused max monthly spend reached error (#30615) 2025-05-13 09:43:13 +00:00
language_model_selector Have read_file support images (#30435) 2025-05-13 10:58:00 +02:00
language_models Add tool result image support to Gemini models (#30647) 2025-05-14 00:51:31 +00:00
language_selector Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
language_tools Rename debug: commands to dev: (#30675) 2025-05-14 11:15:27 +02:00
languages Rename debug: commands to dev: (#30675) 2025-05-14 11:15:27 +02:00
livekit_api Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
livekit_client Fix deafening new participants (#28330) 2025-04-08 16:01:27 +00:00
lmstudio lmstudio: Fix streaming not working in v0.3.15 (#30013) 2025-05-06 12:59:36 -04:00
lsp Remove the minimap from the debugger console (#30610) 2025-05-13 08:09:38 +00:00
markdown markdown: Fix out of range panic in parser (#30510) 2025-05-11 15:08:37 +00:00
markdown_preview Use image cache to stop leaking images (#29452) 2025-04-29 19:30:16 +00:00
media chore: Make objc a workspace level crate (#28258) 2025-04-07 18:46:09 +00:00
menu agent: Add new panel navigation dropdown (#29539) 2025-04-29 21:58:45 -03:00
migrator settings: Migration for fixing duplicated agent keys (#30237) 2025-05-08 12:38:19 +00:00
mistral mistral: Add new Mistral medium model (#30171) 2025-05-07 21:57:15 -04:00
multi_buffer editor: Trim indent guides at last non-empty line (#29482) 2025-05-12 17:04:46 +02:00
node_runtime Wait to locate system-installed Node until the shell environment is loaded (#30416) 2025-05-09 19:24:28 +00:00
notifications Merge Component and ComponentPreview trait (#28365) 2025-04-08 16:09:06 -06:00
ollama Improve Ollama tool use (#30120) 2025-05-07 15:37:06 +00:00
open_ai Add image input support for OpenAI models (#30639) 2025-05-13 17:32:42 +02:00
outline Highlight merge conflicts and provide for resolving them (#28065) 2025-04-23 12:38:46 -04:00
outline_panel Update panels serialization from global to per-workspace (#30652) 2025-05-14 00:05:42 +05:30
panel Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
paths Implement global settings file (#30444) 2025-05-13 08:29:32 +02:00
picker agent: Keyboard navigation improvements (#30274) 2025-05-09 13:52:06 +00:00
prettier Separate timeout and connection dropped errors out (#30457) 2025-05-10 15:12:58 +03:00
project project_settings: Fix default settings values for DiagnosticsSettings (#30686) 2025-05-14 07:13:51 -04:00
project_panel Update panels serialization from global to per-workspace (#30652) 2025-05-14 00:05:42 +05:30
project_symbols Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
prompt_store assistant_context_editor: Remove suggest edits (#30286) 2025-05-08 17:27:49 +00:00
proto language_models: Improve subscription states in the Agent configuration view (#30252) 2025-05-08 09:10:50 -04:00
recent_projects Allow opening the FS root dir as a remote project (#30190) 2025-05-07 16:50:57 -07:00
refineable Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
release_channel Fix handling of --system-specs argument so it happens before Application::new (#29240) 2025-04-22 21:32:32 +00:00
remote Add a test for remote tool use by the agent (#30289) 2025-05-08 16:53:04 -04:00
remote_server Have read_file support images (#30435) 2025-05-13 10:58:00 +02:00
repl Implement rendering of images with data urls in markdown (#30322) 2025-05-08 18:26:24 -07:00
reqwest_client Fix license symlinks (#29758) 2025-05-01 19:24:14 +00:00
rich_text Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
rope chore: Bump Rust version to 1.86 (#28021) 2025-04-03 23:32:50 +02:00
rpc rpc: Remove llm module in favor of zed_llm_client (#28900) 2025-04-16 20:22:44 +00:00
rules_library Reuse conversation cache when streaming edits (#30245) 2025-05-08 14:36:34 +02:00
schema_generator Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
search Fix project search focus not toggling between query and results on ESC (#30613) 2025-05-13 08:36:18 +00:00
semantic_index Reuse conversation cache when streaming edits (#30245) 2025-05-08 14:36:34 +02:00
semantic_version Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
session Avoid unnecessary DB writes (#29417) 2025-04-25 17:41:49 +03:00
settings Rename debug: commands to dev: (#30675) 2025-05-14 11:15:27 +02:00
settings_ui Add searchable global tab switcher (#28047) 2025-04-28 09:21:27 +00:00
snippet Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
snippet_provider editor: Improve snippet completion to show key inline in completion and description as aside (#30603) 2025-05-13 05:28:59 +05:30
snippets_ui Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
sqlez Simplify the SerializableItem::cleanup implementation (#29567) 2025-04-28 22:15:24 +00:00
sqlez_macros Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
story Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
storybook Merge Component and ComponentPreview trait (#28365) 2025-04-08 16:09:06 -06:00
streaming_diff Introduce a new StreamingEditFileTool (#29733) 2025-05-01 17:37:43 +02:00
sum_tree Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
supermaven Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
supermaven_api Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
tab_switcher Add searchable global tab switcher (#28047) 2025-04-28 09:21:27 +00:00
task Parse env vars and args from debug launch editor (#30538) 2025-05-12 09:44:17 +00:00
tasks_ui debugger: Add debug task picker to new session modal (#29702) 2025-05-02 08:38:29 +00:00
telemetry Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
telemetry_events Add new action to run agent eval (#29158) 2025-04-21 21:30:21 -07:00
terminal Do not flicker when switching cmd-hovered words in terminal (#30098) 2025-05-07 11:04:11 +00:00
terminal_view Reapply "ui: Account for padding of parent container during scrollbar layout" (#30577) 2025-05-14 13:26:14 +02:00
text format: Re-implement support for formatting with code actions that contain commands (#28392) 2025-04-09 01:53:54 +00:00
theme theme: Add scrollbar_thumb_active_background color (#30177) 2025-05-07 23:15:32 +03:00
theme_extension Add workspace-hack (#27277) 2025-04-02 13:26:34 -07:00
theme_importer theme: Add scrollbar_thumb_active_background color (#30177) 2025-05-07 23:15:32 +03:00
theme_selector theme_selector: Don't select last theme when fuzzy searching (#28278) 2025-04-28 14:29:17 +00:00
time_format agent: Add date separators to Thread History (#29961) 2025-05-06 10:18:48 +00:00
title_bar project_settings: Fix default settings values for DiagnosticsSettings (#30686) 2025-05-14 07:13:51 -04:00
toolchain_selector toolchain: Respect currently focused file when querying toolchains (#28875) 2025-04-16 19:05:57 +02:00
ui Reapply "ui: Account for padding of parent container during scrollbar layout" (#30577) 2025-05-14 13:26:14 +02:00
ui_input Merge Component and ComponentPreview trait (#28365) 2025-04-08 16:09:06 -06:00
ui_macros Merge Component and ComponentPreview trait (#28365) 2025-04-08 16:09:06 -06:00
ui_prompt markdown: Don't retain MarkdownStyle in favor of using MarkdownElement directly (#28255) 2025-04-07 19:03:24 +00:00
util Separate timeout and connection dropped errors out (#30457) 2025-05-10 15:12:58 +03:00
util_macros Fix license symlinks (#29758) 2025-05-01 19:24:14 +00:00
vim vim: Add :w <filename> command (#29256) 2025-05-12 15:09:18 +02:00
vim_mode_setting VSCode Settings import (#29018) 2025-04-23 20:54:09 +00:00
web_search agent: Expose web search tool to beta users (#29273) 2025-04-23 15:30:20 +00:00
web_search_providers Remove individual URL overrides for LLM service (#30290) 2025-05-08 17:54:46 +00:00
welcome welcome: Theme preview tile (#29689) 2025-04-30 17:46:11 +00:00
workspace Reapply "ui: Account for padding of parent container during scrollbar layout" (#30577) 2025-05-14 13:26:14 +02:00
worktree Separate timeout and connection dropped errors out (#30457) 2025-05-10 15:12:58 +03:00
zed Bump Zed to v0.188 (#30685) 2025-05-14 10:41:09 +00:00
zed_actions Add :h[elp] vim command (#30179) 2025-05-07 17:26:42 -07:00
zeta zeta: Do not show usage for copilot/supermaven (#30563) 2025-05-12 14:03:50 +00:00
zlog zlog: Fall back to printing module path instead of *unknown* or just crate name (#29691) 2025-05-01 10:59:51 -04:00
zlog_settings VSCode Settings import (#29018) 2025-04-23 20:54:09 +00:00