ZIm/crates/proto
Kirill Bulatov 8a7a78fafb
Avoid modifying the LSP message before resolving it (#26347)
Closes https://github.com/zed-industries/zed/issues/21277

To the left is current Zed, right is the improved version.
3rd message, from Zed, to resolve the item, does not have `textEdit` on
the right side, and has one on the left.
Seems to not influence the end result though, but at least Zed behaves
more appropriate now.

<img width="1727" alt="image"
src="https://github.com/user-attachments/assets/ca1236fd-9ce2-41ba-88fe-1f3178cdcbde"
/>


Instead of modifying the original LSP completion item, store completion
list defaults and apply them when the item is requested (except `data`
defaults, needed for resolve).

Now, the only place that can modify the completion items is this method,
and Python impl seems to be the one doing it:


ca9c3af56f/crates/languages/src/python.rs (L182-L204)

Seems ok to leave untouched for now.

Release Notes:

- Fixed LSP completion items modified before resolve request
2025-03-10 00:12:53 +02:00
..
proto Avoid modifying the LSP message before resolving it (#26347) 2025-03-10 00:12:53 +02:00
src git_ui: Add support for generating commit messages with an LLM (#26227) 2025-03-06 19:47:52 +00:00
build.rs Allow rpc_url to be assigned on Client with test-support feature (#13430) 2024-07-10 13:36:22 -06:00
Cargo.toml Chunk git status entries (#25627) 2025-02-26 12:38:16 -07:00
LICENSE-GPL Add missing LICENSE file to proto crate (#12863) 2024-06-10 15:35:37 -04:00