Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
ZIm/crates
History
Auf keinen Fall Jens 633b665379
Option to insert comment character(s) at the beginning of the line(s) (#19746) 
Closes #19459


This PR adds the optional setting to insert comment character(s) at the
beginning of the line(s) instead of after the indentation. It can be
enabled via keybindings:

```
"ctrl-/": ["editor::ToggleComments", { "ignore_indent": true }]
```

As suggested by @notpeter in #19459, this is implemented in
`toggle_comments` (editor.rs) taking the existing `advance_downwards`
option as example.

There's also a test case for the setting, which mimics the test case for
the regular comment toggling behavior.

---

I am not entirely happy with the name `ignore_indent`. The default would
be a double negative now `ignore_indent=false`. A positive wording would
probably easier to understand, but I could not think of anything
concise. `insert_at_line_start` or just `at_line_start` might work, but
didn't convince me either. That said, I am happy to change the name if
there are better ideas.

---

Release Notes:

- Added optional setting to insert comment character(s) at the beginning
of the line(s) instead of after the indentation. It can be used by
changing the default mapping to toggle comments like this: `"ctrl-/":
["editor::ToggleComments", { "ignore_indent": true }]`
2024-10-31 09:39:57 +01:00
..
activity_indicator Log prettier errors on failures (#19951) 2024-10-30 14:49:47 +02:00
anthropic Switch to Anthropic -latest tags (#19615) 2024-10-23 15:13:52 -04:00
assets add ui::Vector and separate images from icons (#17815) 2024-09-13 17:44:16 -04:00
assistant Adjust design of the slash command picker (#19973) 2024-10-30 19:42:42 -03:00
assistant_slash_command Adjust design of the slash command picker (#19973) 2024-10-30 19:42:42 -03:00
assistant_tool assistant: Add basic tool invocation (#17368) 2024-09-04 14:32:20 -04:00
audio Update Rust crate rodio to 0.19.0 (#17389) 2024-09-16 21:55:32 -06:00
auto_update Fail download if download fails (#19990) 2024-10-30 14:50:41 -07:00
breadcrumbs Add missing shortcuts in tooltips (#18282) 2024-09-27 11:06:48 +02:00
call Remove dev servers (#19638) 2024-10-24 12:14:03 -06:00
channel Remove hosted projects (#19754) 2024-10-27 19:44:21 -07:00
cli Remove dev servers (#19638) 2024-10-24 12:14:03 -06:00
client ssh remoting: Show the host's GitHub name in the titlebar when sharing an SSH project (#19844) 2024-10-29 09:52:54 +01:00
clock Fix bugs with applying hunks from branch buffers (#18721) 2024-10-07 16:28:33 -07:00
collab Migration to remove dev servers (#19639) 2024-10-30 11:55:55 -06:00
collab_ui Fix mouse clicks on remote-open-folder UI (#19851) 2024-10-28 12:55:55 -07:00
collections gpui: Add SVG rendering to img element and generic asset cache (#9931) 2024-03-29 17:09:49 -07:00
command_palette chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
command_palette_hooks chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
context_servers context_servers: Support tools (#19548) 2024-10-28 10:37:58 -04:00
copilot Fix mouse clicks on remote-open-folder UI (#19851) 2024-10-28 12:55:55 -07:00
db chore: Fix some violations of 'needless_pass_by_ref_mut' lint (#18795) 2024-10-07 01:29:58 +02:00
dev_server_projects/src Remove dev servers (#19638) 2024-10-24 12:14:03 -06:00
diagnostics Take a mutable context when resolving selections (#19948) 2024-10-30 15:21:51 +01:00
docs_preprocessor Don't rely on relative path for docs preprocessor (#16883) 2024-08-26 11:43:13 -04:00
editor Option to insert comment character(s) at the beginning of the line(s) (#19746) 2024-10-31 09:39:57 +01:00
evals Restore HTTP client transition, but use reqwest everywhere (#19055) 2024-10-11 14:58:58 -07:00
extension Add language toolchains (#19576) 2024-10-28 15:34:03 +01:00
extension_api zed_extension_api: Use v0.2.0 WIT types (#17802) 2024-09-13 14:49:50 -04:00
extension_cli Restore HTTP client transition, but use reqwest everywhere (#19055) 2024-10-11 14:58:58 -07:00
extensions_ui Add settings to remote servers, use XDG paths on remote, and enable node LSPs (#19176) 2024-10-15 23:32:44 -07:00
feature_flags Initial Notebook UI structure (#19756) 2024-10-29 11:30:07 -07:00
feedback Stop leaking isahc assumption (#18408) 2024-09-26 14:01:05 -06:00
file_finder Add more context to the save new file path picker (#19863) 2024-10-28 17:21:41 -07:00
file_icons chore: Clean up allocs around project panel (#15422) 2024-07-29 14:21:41 +02:00
fs Add support for git branches on remote projects (#19755) 2024-10-27 15:50:54 -07:00
fsevent Retain run loop (#11241) 2024-04-30 23:31:59 -06:00
fuzzy Improve slash commands (#16195) 2024-08-13 23:06:07 -07:00
git Make Git remote URL parsing more robust (#19924) 2024-10-29 16:19:05 -04:00
git_hosting_providers git_hosting_providers: Fix support for GitLab remotes containing subgroups (#19962) 2024-10-30 11:16:44 -04:00
go_to_line Take a mutable context when resolving selections (#19948) 2024-10-30 15:21:51 +01:00
google_ai Stop leaking isahc assumption (#18408) 2024-09-26 14:01:05 -06:00
gpui Add KeyContextView (#19872) 2024-10-30 11:26:54 -06:00
gpui_macros add ui::Vector and separate images from icons (#17815) 2024-09-13 17:44:16 -04:00
html_to_markdown chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
http_client Add settings to remote servers, use XDG paths on remote, and enable node LSPs (#19176) 2024-10-15 23:32:44 -07:00
image_viewer Fix mouse clicks on remote-open-folder UI (#19851) 2024-10-28 12:55:55 -07:00
indexed_docs chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
inline_completion_button Support .editorconfig (#19455) 2024-10-21 13:05:30 +03:00
install_cli Fix flickering (#9012) 2024-03-11 10:45:57 +01:00
journal chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
language Fix missing diagnostic and text highlights after blocks (#19920) 2024-10-29 13:47:43 -07:00
language_model Fix wrong UpdateWorktree chunk size being used in release mode (#19912) 2024-10-29 11:22:41 -06:00
language_selector use ssh lsp store (#17655) 2024-09-10 15:51:01 -04:00
language_tools Add KeyContextView (#19872) 2024-10-30 11:26:54 -06:00
languages Fix quotes in Rust (#19914) 2024-10-29 12:35:34 -06:00
live_kit_client chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
live_kit_server Restore HTTP client transition, but use reqwest everywhere (#19055) 2024-10-11 14:58:58 -07:00
lsp Fix a few Windows tests (#19773) 2024-10-26 03:32:22 +03:00
markdown SSH Remoting: Fix yes/no/fingerprint prompt (#19526) 2024-10-21 15:28:22 -06:00
markdown_preview Take a mutable context when resolving selections (#19948) 2024-10-30 15:21:51 +01:00
media Update Rust crate bindgen to 0.70.0 (#17024) 2024-08-28 22:12:49 -07:00
menu open picker (#14524) 2024-07-15 17:04:15 -06:00
multi_buffer vim: Copy comment to new lines with o/O (#19766) 2024-10-25 16:47:44 -06:00
node_runtime Make python run local worktree LSPs (#18353) 2024-09-25 12:45:41 -07:00
notifications Pass Summary::Context to Item::summarize (#18510) 2024-09-29 10:30:48 -06:00
ollama Fix read timeout for ollama (#18417) 2024-09-27 00:36:17 -06:00
open_ai Stop leaking isahc assumption (#18408) 2024-09-26 14:01:05 -06:00
outline Take a mutable context when resolving selections (#19948) 2024-10-30 15:21:51 +01:00
outline_panel Add scrollbars to outline panel (#19969) 2024-10-30 19:09:14 +02:00
paths Support .editorconfig (#19455) 2024-10-21 13:05:30 +03:00
picker Add more context to the save new file path picker (#19863) 2024-10-28 17:21:41 -07:00
prettier Log prettier errors on failures (#19951) 2024-10-30 14:49:47 +02:00
project Log prettier errors on failures (#19951) 2024-10-30 14:49:47 +02:00
project_panel Future-proof indent guides settings for panels (#19878) 2024-10-29 09:52:36 +01:00
project_symbols Fix renames over language server for SSH remoting (#17897) 2024-09-16 16:20:17 -06:00
proto proto: Remove unused UpdateUserSettings message (#20005) 2024-10-31 09:36:18 +01:00
quick_action_bar Add missing shortcuts in tooltips (#18282) 2024-09-27 11:06:48 +02:00
recent_projects SSH installation refactor (#19991) 2024-10-30 16:20:11 -07:00
refineable Move Clippy configuration to the workspace level (#8891) 2024-03-05 12:01:17 -05:00
release_channel chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
remote SSH installation refactor (#19991) 2024-10-30 16:20:11 -07:00
remote_server remote dev: Allow canceling language server work in editor (#19946) 2024-10-30 13:27:11 +01:00
repl Trim whitespace from base64 encoded image data before decoding it (#19977) 2024-10-30 12:32:17 -07:00
reqwest_client reqwest_client: Fix socks proxy settings (#19123) 2024-10-18 09:57:00 -07:00
rich_text Disable definition lists in Markdown (#17648) 2024-09-10 11:16:27 -04:00
rope Speed up point translation in the Rope (#19913) 2024-10-30 10:59:03 +01:00
rpc Add support for git branches on remote projects (#19755) 2024-10-27 15:50:54 -07:00
search Fix mouse clicks on remote-open-folder UI (#19851) 2024-10-28 12:55:55 -07:00
semantic_index semantic_index: Disable embeddings index for non-staff (#19618) 2024-10-23 12:34:51 -04:00
semantic_version Extract SemanticVersion into its own crate (#9956) 2024-03-29 12:11:57 -04:00
session chore: Fix some violations of 'needless_pass_by_ref_mut' lint (#18795) 2024-10-07 01:29:58 +02:00
settings Add support for git branches on remote projects (#19755) 2024-10-27 15:50:54 -07:00
settings_ui chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
snippet Correct escaping in snippets (#14912) 2024-07-22 00:57:34 +02:00
snippet_provider chore: Fix some violations of 'needless_pass_by_ref_mut' lint (#18795) 2024-10-07 01:29:58 +02:00
snippets_ui Add snippet commands (#18453) 2024-10-02 13:27:16 +02:00
sqlez Fix a rare crash on startup (#19922) 2024-10-29 12:30:55 -07:00
sqlez_macros Compare migrations formatted uniformly (#18760) 2024-10-05 12:58:45 +03:00
story chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
storybook project panel: Add indent guides (#18260) 2024-10-24 13:07:20 +02:00
sum_tree Speed up point translation in the Rope (#19913) 2024-10-30 10:59:03 +01:00
supermaven Cap the size of the Supermaven states buffer (#19246) 2024-10-23 10:36:14 +03:00
supermaven_api chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
tab_switcher tab_switcher: Use git-aware colors for file icons (#18733) 2024-10-04 10:37:41 -04:00
task Fix remoting things (#19587) 2024-10-23 00:14:43 -07:00
tasks_ui Add more context to the save new file path picker (#19863) 2024-10-28 17:21:41 -07:00
telemetry_events Implement panic reporting saving and uploads (#19932) 2024-10-29 23:54:00 -07:00
terminal ssh remoting: Fix wrong working directory for SSH terminals (#19672) 2024-10-24 13:52:26 +02:00
terminal_view Fix mouse clicks on remote-open-folder UI (#19851) 2024-10-28 12:55:55 -07:00
text Restructure assistant edits to show all changes in a proposed-change editor (#18240) 2024-10-17 13:18:13 -04:00
theme Use theme families to refine user themes (#19936) 2024-10-29 22:30:58 -04:00
theme_importer chore: Another round of style lints fixes (#17519) 2024-09-07 02:36:55 +02:00
theme_selector settings_ui: Add theme settings controls (#15115) 2024-07-24 16:25:52 -04:00
time_format chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
title_bar ssh remoting: Hide share button while connecting to project (#19885) 2024-10-29 12:13:21 +01:00
toolchain_selector Add language toolchains (#19576) 2024-10-28 15:34:03 +01:00
ui Adjust design of the slash command picker (#19973) 2024-10-30 19:42:42 -03:00
ui_input Rename ui_text_field crate to ui_input (#13949) 2024-07-08 17:05:30 -04:00
ui_macros Add ui_macros crate & DerivePathStr derive macro (#17811) 2024-09-13 16:45:16 -04:00
util Add support for git branches on remote projects (#19755) 2024-10-27 15:50:54 -07:00
vcs_menu vsc menu: Fix issue when switching branch while non-visible worktree is open (#19888) 2024-10-29 12:27:30 +01:00
vim Take a mutable context when resolving selections (#19948) 2024-10-30 15:21:51 +01:00
welcome Fix mouse clicks on remote-open-folder UI (#19851) 2024-10-28 12:55:55 -07:00
workspace Add missing full-size styles for panes (#19935) 2024-10-29 21:16:45 -04:00
worktree Add support for self-hosted GitLab instances for Git permalinks (#19909) 2024-10-29 12:31:51 -04:00
zed Support zed://ssh (#19970) 2024-10-30 11:28:25 -06:00
zed_actions Add KeyContextView (#19872) 2024-10-30 11:26:54 -06:00