5447821715
This commit is all about strings, not about line layout at all. When laying out text, we use a line layout cache to avoid roundtrips to system layout engine where possible. This makes it so that we might end up not needing an owned version of text to insert into the cache, as we might get a cached version. The API boundary of line layout accepted text to be laid out as &str. It then performed cache lookup (which didn't require having an owned version) and only resorted to making an owned version when needed. As it turned out though, exact cache hits are quite rare and we end up needing owned version more often than not. The callers of line layout either dealt with SharedStrings or owned Strings. Due to coercing them into &str, we were ~always copying text into a new string (unless there was a same-frame-hit). This is a bit wasteful, thus this PR generifies the API a bit to make it easier to reuse existing string allocations if there are any. Benchmark scenario: scrolling down page-by-page through editor_tests (I ran the same scenario twice):   Release Notes: - N/A |
||
|---|---|---|
| .. | ||
| font_fallbacks.rs | ||
| font_features.rs | ||
| line.rs | ||
| line_layout.rs | ||
| line_wrapper.rs | ||