70bde54a2c
Added [rhysd/actionlint](https://github.com/rhysd/actionlint/) a static checker for GitHub Actions workflow files. Install locally with `brew install actionlint` the run with `actionlint`. Inspired by: https://github.com/zed-industries/zed/pull/34704 which yielded this observation: > In github actions: > 1. strings are truthy > 2. `${{ }}` will become a string if it doesn't wrap the whole value. > > So `if: false && true` becomes `false` > and `if: ${{ false && true }}` becomes `false` > but `if: false && ${{ true }}` becomes `"false && true"` which evaluates true > The reason you sometimes need `${{ }}` is because YAML doesn't like `!` > so `if: !false` is invalid yaml > and `if: ${{ !false }}` works just fine. Changes: - Add `actionlint` job - Refactor `job_spec` job to be more readable - Fix all `actionlint` and `shellcheck` errors in Actions workflows (62 in all) - Add `self-mini-macos` and `self-32vcpu-windows-2022` labels to self-hosted runners. Not strictly related, but useful if you need to take a runner out of the rotation (since `macOS`, `self-hosted`, and `ARM64` are auto-set and cannot be added/removed). - Change ci.yml macos_relase to target `self-mini-macos` instead of `bundle` which was previously deprecated. This would've caught the error fixed in https://github.com/zed-industries/zed/pull/34704. Here's what that [job failure](https://github.com/zed-industries/zed/actions/runs/16376993944/job/46279281842?pr=34729) would've looked like. Release Notes: - N/A
51 lines
1.5 KiB
YAML
51 lines
1.5 KiB
YAML
name: bump_patch_version
|
|
|
|
on:
|
|
workflow_dispatch:
|
|
inputs:
|
|
branch:
|
|
description: "Branch name to run on"
|
|
required: true
|
|
|
|
concurrency:
|
|
# Allow only one workflow per any non-`main` branch.
|
|
group: ${{ github.workflow }}-${{ inputs.branch }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
bump_patch_version:
|
|
if: github.repository_owner == 'zed-industries'
|
|
runs-on:
|
|
- buildjet-16vcpu-ubuntu-2204
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
|
|
with:
|
|
ref: ${{ github.event.inputs.branch }}
|
|
ssh-key: ${{ secrets.ZED_BOT_DEPLOY_KEY }}
|
|
|
|
- name: Bump Patch Version
|
|
run: |
|
|
set -eux
|
|
|
|
channel="$(cat crates/zed/RELEASE_CHANNEL)"
|
|
|
|
tag_suffix=""
|
|
case $channel in
|
|
stable)
|
|
;;
|
|
preview)
|
|
tag_suffix="-pre"
|
|
;;
|
|
*)
|
|
echo "this must be run on either of stable|preview release branches" >&2
|
|
exit 1
|
|
;;
|
|
esac
|
|
which cargo-set-version > /dev/null || cargo install cargo-edit
|
|
output="$(cargo set-version -p zed --bump patch 2>&1 | sed 's/.* //')"
|
|
export GIT_COMMITTER_NAME="Zed Bot"
|
|
export GIT_COMMITTER_EMAIL="hi@zed.dev"
|
|
git commit -am "Bump to $output for @$GITHUB_ACTOR" --author "Zed Bot <hi@zed.dev>"
|
|
git tag "v${output}${tag_suffix}"
|
|
git push origin HEAD "v${output}${tag_suffix}"
|