70bde54a2c
Added [rhysd/actionlint](https://github.com/rhysd/actionlint/) a static checker for GitHub Actions workflow files. Install locally with `brew install actionlint` the run with `actionlint`. Inspired by: https://github.com/zed-industries/zed/pull/34704 which yielded this observation: > In github actions: > 1. strings are truthy > 2. `${{ }}` will become a string if it doesn't wrap the whole value. > > So `if: false && true` becomes `false` > and `if: ${{ false && true }}` becomes `false` > but `if: false && ${{ true }}` becomes `"false && true"` which evaluates true > The reason you sometimes need `${{ }}` is because YAML doesn't like `!` > so `if: !false` is invalid yaml > and `if: ${{ !false }}` works just fine. Changes: - Add `actionlint` job - Refactor `job_spec` job to be more readable - Fix all `actionlint` and `shellcheck` errors in Actions workflows (62 in all) - Add `self-mini-macos` and `self-32vcpu-windows-2022` labels to self-hosted runners. Not strictly related, but useful if you need to take a runner out of the rotation (since `macOS`, `self-hosted`, and `ARM64` are auto-set and cannot be added/removed). - Change ci.yml macos_relase to target `self-mini-macos` instead of `bundle` which was previously deprecated. This would've caught the error fixed in https://github.com/zed-industries/zed/pull/34704. Here's what that [job failure](https://github.com/zed-industries/zed/actions/runs/16376993944/job/46279281842?pr=34729) would've looked like. Release Notes: - N/A
68 lines
2.3 KiB
YAML
68 lines
2.3 KiB
YAML
name: "Nix build"
|
|
|
|
on:
|
|
workflow_call:
|
|
inputs:
|
|
flake-output:
|
|
type: string
|
|
default: "default"
|
|
cachix-filter:
|
|
type: string
|
|
default: ""
|
|
|
|
jobs:
|
|
nix-build:
|
|
timeout-minutes: 60
|
|
name: (${{ matrix.system.os }}) Nix Build
|
|
continue-on-error: true # TODO: remove when we want this to start blocking CI
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
system:
|
|
- os: x86 Linux
|
|
runner: buildjet-16vcpu-ubuntu-2204
|
|
install_nix: true
|
|
- os: arm Mac
|
|
runner: [macOS, ARM64, test]
|
|
install_nix: false
|
|
if: github.repository_owner == 'zed-industries'
|
|
runs-on: ${{ matrix.system.runner }}
|
|
env:
|
|
ZED_CLIENT_CHECKSUM_SEED: ${{ secrets.ZED_CLIENT_CHECKSUM_SEED }}
|
|
ZED_CLOUD_PROVIDER_ADDITIONAL_MODELS_JSON: ${{ secrets.ZED_CLOUD_PROVIDER_ADDITIONAL_MODELS_JSON }}
|
|
GIT_LFS_SKIP_SMUDGE: 1 # breaks the livekit rust sdk examples which we don't actually depend on
|
|
steps:
|
|
- name: Checkout repo
|
|
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
|
|
with:
|
|
clean: false
|
|
|
|
# on our macs we manually install nix. for some reason the cachix action is running
|
|
# under a non-login /bin/bash shell which doesn't source the proper script to add the
|
|
# nix profile to PATH, so we manually add them here
|
|
- name: Set path
|
|
if: ${{ ! matrix.system.install_nix }}
|
|
run: |
|
|
echo "/nix/var/nix/profiles/default/bin" >> "$GITHUB_PATH"
|
|
echo "/Users/administrator/.nix-profile/bin" >> "$GITHUB_PATH"
|
|
|
|
- uses: cachix/install-nix-action@02a151ada4993995686f9ed4f1be7cfbb229e56f # v31
|
|
if: ${{ matrix.system.install_nix }}
|
|
with:
|
|
github_access_token: ${{ secrets.GITHUB_TOKEN }}
|
|
|
|
- uses: cachix/cachix-action@0fc020193b5a1fa3ac4575aa3a7d3aa6a35435ad # v16
|
|
with:
|
|
name: zed
|
|
authToken: "${{ secrets.CACHIX_AUTH_TOKEN }}"
|
|
pushFilter: "${{ inputs.cachix-filter }}"
|
|
cachixArgs: "-v"
|
|
|
|
- run: nix build .#${{ inputs.flake-output }} -L --accept-flake-config
|
|
|
|
- name: Limit /nix/store to 50GB on macs
|
|
if: ${{ ! matrix.system.install_nix }}
|
|
run: |
|
|
if [ "$(du -sm /nix/store | cut -f1)" -gt 50000 ]; then
|
|
nix-collect-garbage -d || true
|
|
fi
|