
There's still a bit more work to do on this, but this PR is compiling (with warnings) after eliminating the key types. When the tasks below are complete, this will be the new narrative for GPUI: - `Entity<T>` - This replaces `View<T>`/`Model<T>`. It represents a unit of state, and if `T` implements `Render`, then `Entity<T>` implements `Element`. - `&mut App` This replaces `AppContext` and represents the app. - `&mut Context<T>` This replaces `ModelContext` and derefs to `App`. It is provided by the framework when updating an entity. - `&mut Window` Broken out of `&mut WindowContext` which no longer exists. Every method that once took `&mut WindowContext` now takes `&mut Window, &mut App` and every method that took `&mut ViewContext<T>` now takes `&mut Window, &mut Context<T>` Not pictured here are the two other failed attempts. It's been quite a month! Tasks: - [x] Remove `View`, `ViewContext`, `WindowContext` and thread through `Window` - [x] [@cole-miller @mikayla-maki] Redraw window when entities change - [x] [@cole-miller @mikayla-maki] Get examples and Zed running - [x] [@cole-miller @mikayla-maki] Fix Zed rendering - [x] [@mikayla-maki] Fix todo! macros and comments - [x] Fix a bug where the editor would not be redrawn because of view caching - [x] remove publicness window.notify() and replace with `AppContext::notify` - [x] remove `observe_new_window_models`, replace with `observe_new_models` with an optional window - [x] Fix a bug where the project panel would not be redrawn because of the wrong refresh() call being used - [x] Fix the tests - [x] Fix warnings by eliminating `Window` params or using `_` - [x] Fix conflicts - [x] Simplify generic code where possible - [x] Rename types - [ ] Update docs ### issues post merge - [x] Issues switching between normal and insert mode - [x] Assistant re-rendering failure - [x] Vim test failures - [x] Mac build issue Release Notes: - N/A --------- Co-authored-by: Antonio Scandurra <me@as-cii.com> Co-authored-by: Cole Miller <cole@zed.dev> Co-authored-by: Mikayla <mikayla@zed.dev> Co-authored-by: Joseph <joseph@zed.dev> Co-authored-by: max <max@zed.dev> Co-authored-by: Michael Sloan <michael@zed.dev> Co-authored-by: Mikayla Maki <mikaylamaki@Mikaylas-MacBook-Pro.local> Co-authored-by: Mikayla <mikayla.c.maki@gmail.com> Co-authored-by: joão <joao@zed.dev>
115 lines
3.7 KiB
Rust
115 lines
3.7 KiB
Rust
use anyhow::{anyhow, Context as _, Result};
|
|
use assistant_slash_command::{
|
|
ArgumentCompletion, SlashCommand, SlashCommandOutput, SlashCommandOutputSection,
|
|
SlashCommandResult,
|
|
};
|
|
use gpui::{Task, WeakEntity};
|
|
use language::{BufferSnapshot, LspAdapterDelegate};
|
|
use prompt_library::PromptStore;
|
|
use std::sync::{atomic::AtomicBool, Arc};
|
|
use ui::prelude::*;
|
|
use workspace::Workspace;
|
|
|
|
pub struct PromptSlashCommand;
|
|
|
|
impl SlashCommand for PromptSlashCommand {
|
|
fn name(&self) -> String {
|
|
"prompt".into()
|
|
}
|
|
|
|
fn description(&self) -> String {
|
|
"Insert prompt from library".into()
|
|
}
|
|
|
|
fn icon(&self) -> IconName {
|
|
IconName::Library
|
|
}
|
|
|
|
fn menu_text(&self) -> String {
|
|
self.description()
|
|
}
|
|
|
|
fn requires_argument(&self) -> bool {
|
|
true
|
|
}
|
|
|
|
fn complete_argument(
|
|
self: Arc<Self>,
|
|
arguments: &[String],
|
|
_cancellation_flag: Arc<AtomicBool>,
|
|
_workspace: Option<WeakEntity<Workspace>>,
|
|
_: &mut Window,
|
|
cx: &mut App,
|
|
) -> Task<Result<Vec<ArgumentCompletion>>> {
|
|
let store = PromptStore::global(cx);
|
|
let query = arguments.to_owned().join(" ");
|
|
cx.background_executor().spawn(async move {
|
|
let prompts = store.await?.search(query).await;
|
|
Ok(prompts
|
|
.into_iter()
|
|
.filter_map(|prompt| {
|
|
let prompt_title = prompt.title?.to_string();
|
|
Some(ArgumentCompletion {
|
|
label: prompt_title.clone().into(),
|
|
new_text: prompt_title,
|
|
after_completion: true.into(),
|
|
replace_previous_arguments: true,
|
|
})
|
|
})
|
|
.collect())
|
|
})
|
|
}
|
|
|
|
fn run(
|
|
self: Arc<Self>,
|
|
arguments: &[String],
|
|
_context_slash_command_output_sections: &[SlashCommandOutputSection<language::Anchor>],
|
|
_context_buffer: BufferSnapshot,
|
|
_workspace: WeakEntity<Workspace>,
|
|
_delegate: Option<Arc<dyn LspAdapterDelegate>>,
|
|
_: &mut Window,
|
|
cx: &mut App,
|
|
) -> Task<SlashCommandResult> {
|
|
let title = arguments.to_owned().join(" ");
|
|
if title.trim().is_empty() {
|
|
return Task::ready(Err(anyhow!("missing prompt name")));
|
|
};
|
|
|
|
let store = PromptStore::global(cx);
|
|
let title = SharedString::from(title.clone());
|
|
let prompt = cx.background_executor().spawn({
|
|
let title = title.clone();
|
|
async move {
|
|
let store = store.await?;
|
|
let prompt_id = store
|
|
.id_for_title(&title)
|
|
.with_context(|| format!("no prompt found with title {:?}", title))?;
|
|
let body = store.load(prompt_id).await?;
|
|
anyhow::Ok(body)
|
|
}
|
|
});
|
|
cx.foreground_executor().spawn(async move {
|
|
let mut prompt = prompt.await?;
|
|
|
|
if prompt.starts_with('/') {
|
|
// Prevent an edge case where the inserted prompt starts with a slash command (that leads to funky rendering).
|
|
prompt.insert(0, '\n');
|
|
}
|
|
if prompt.is_empty() {
|
|
prompt.push('\n');
|
|
}
|
|
let range = 0..prompt.len();
|
|
Ok(SlashCommandOutput {
|
|
text: prompt,
|
|
sections: vec![SlashCommandOutputSection {
|
|
range,
|
|
icon: IconName::Library,
|
|
label: title,
|
|
metadata: None,
|
|
}],
|
|
run_commands_in_text: true,
|
|
}
|
|
.to_event_stream())
|
|
})
|
|
}
|
|
}
|