
There's still a bit more work to do on this, but this PR is compiling (with warnings) after eliminating the key types. When the tasks below are complete, this will be the new narrative for GPUI: - `Entity<T>` - This replaces `View<T>`/`Model<T>`. It represents a unit of state, and if `T` implements `Render`, then `Entity<T>` implements `Element`. - `&mut App` This replaces `AppContext` and represents the app. - `&mut Context<T>` This replaces `ModelContext` and derefs to `App`. It is provided by the framework when updating an entity. - `&mut Window` Broken out of `&mut WindowContext` which no longer exists. Every method that once took `&mut WindowContext` now takes `&mut Window, &mut App` and every method that took `&mut ViewContext<T>` now takes `&mut Window, &mut Context<T>` Not pictured here are the two other failed attempts. It's been quite a month! Tasks: - [x] Remove `View`, `ViewContext`, `WindowContext` and thread through `Window` - [x] [@cole-miller @mikayla-maki] Redraw window when entities change - [x] [@cole-miller @mikayla-maki] Get examples and Zed running - [x] [@cole-miller @mikayla-maki] Fix Zed rendering - [x] [@mikayla-maki] Fix todo! macros and comments - [x] Fix a bug where the editor would not be redrawn because of view caching - [x] remove publicness window.notify() and replace with `AppContext::notify` - [x] remove `observe_new_window_models`, replace with `observe_new_models` with an optional window - [x] Fix a bug where the project panel would not be redrawn because of the wrong refresh() call being used - [x] Fix the tests - [x] Fix warnings by eliminating `Window` params or using `_` - [x] Fix conflicts - [x] Simplify generic code where possible - [x] Rename types - [ ] Update docs ### issues post merge - [x] Issues switching between normal and insert mode - [x] Assistant re-rendering failure - [x] Vim test failures - [x] Mac build issue Release Notes: - N/A --------- Co-authored-by: Antonio Scandurra <me@as-cii.com> Co-authored-by: Cole Miller <cole@zed.dev> Co-authored-by: Mikayla <mikayla@zed.dev> Co-authored-by: Joseph <joseph@zed.dev> Co-authored-by: max <max@zed.dev> Co-authored-by: Michael Sloan <michael@zed.dev> Co-authored-by: Mikayla Maki <mikaylamaki@Mikaylas-MacBook-Pro.local> Co-authored-by: Mikayla <mikayla.c.maki@gmail.com> Co-authored-by: joão <joao@zed.dev>
154 lines
4.5 KiB
Rust
154 lines
4.5 KiB
Rust
#![allow(missing_docs)]
|
|
use gpui::{AnyElement, ScrollHandle};
|
|
use smallvec::SmallVec;
|
|
|
|
use crate::prelude::*;
|
|
use crate::Tab;
|
|
|
|
#[derive(IntoElement)]
|
|
pub struct TabBar {
|
|
id: ElementId,
|
|
start_children: SmallVec<[AnyElement; 2]>,
|
|
children: SmallVec<[AnyElement; 2]>,
|
|
end_children: SmallVec<[AnyElement; 2]>,
|
|
scroll_handle: Option<ScrollHandle>,
|
|
}
|
|
|
|
impl TabBar {
|
|
pub fn new(id: impl Into<ElementId>) -> Self {
|
|
Self {
|
|
id: id.into(),
|
|
start_children: SmallVec::new(),
|
|
children: SmallVec::new(),
|
|
end_children: SmallVec::new(),
|
|
scroll_handle: None,
|
|
}
|
|
}
|
|
|
|
pub fn track_scroll(mut self, scroll_handle: ScrollHandle) -> Self {
|
|
self.scroll_handle = Some(scroll_handle);
|
|
self
|
|
}
|
|
|
|
pub fn start_children_mut(&mut self) -> &mut SmallVec<[AnyElement; 2]> {
|
|
&mut self.start_children
|
|
}
|
|
|
|
pub fn start_child(mut self, start_child: impl IntoElement) -> Self
|
|
where
|
|
Self: Sized,
|
|
{
|
|
self.start_children_mut()
|
|
.push(start_child.into_element().into_any());
|
|
self
|
|
}
|
|
|
|
pub fn start_children(
|
|
mut self,
|
|
start_children: impl IntoIterator<Item = impl IntoElement>,
|
|
) -> Self
|
|
where
|
|
Self: Sized,
|
|
{
|
|
self.start_children_mut().extend(
|
|
start_children
|
|
.into_iter()
|
|
.map(|child| child.into_any_element()),
|
|
);
|
|
self
|
|
}
|
|
|
|
pub fn end_children_mut(&mut self) -> &mut SmallVec<[AnyElement; 2]> {
|
|
&mut self.end_children
|
|
}
|
|
|
|
pub fn end_child(mut self, end_child: impl IntoElement) -> Self
|
|
where
|
|
Self: Sized,
|
|
{
|
|
self.end_children_mut()
|
|
.push(end_child.into_element().into_any());
|
|
self
|
|
}
|
|
|
|
pub fn end_children(mut self, end_children: impl IntoIterator<Item = impl IntoElement>) -> Self
|
|
where
|
|
Self: Sized,
|
|
{
|
|
self.end_children_mut().extend(
|
|
end_children
|
|
.into_iter()
|
|
.map(|child| child.into_any_element()),
|
|
);
|
|
self
|
|
}
|
|
}
|
|
|
|
impl ParentElement for TabBar {
|
|
fn extend(&mut self, elements: impl IntoIterator<Item = AnyElement>) {
|
|
self.children.extend(elements)
|
|
}
|
|
}
|
|
|
|
impl RenderOnce for TabBar {
|
|
fn render(self, _: &mut Window, cx: &mut App) -> impl IntoElement {
|
|
div()
|
|
.id(self.id)
|
|
.group("tab_bar")
|
|
.flex()
|
|
.flex_none()
|
|
.w_full()
|
|
.h(Tab::container_height(cx))
|
|
.bg(cx.theme().colors().tab_bar_background)
|
|
.when(!self.start_children.is_empty(), |this| {
|
|
this.child(
|
|
h_flex()
|
|
.flex_none()
|
|
.gap(DynamicSpacing::Base04.rems(cx))
|
|
.px(DynamicSpacing::Base06.rems(cx))
|
|
.border_b_1()
|
|
.border_r_1()
|
|
.border_color(cx.theme().colors().border)
|
|
.children(self.start_children),
|
|
)
|
|
})
|
|
.child(
|
|
div()
|
|
.relative()
|
|
.flex_1()
|
|
.h_full()
|
|
.overflow_x_hidden()
|
|
.child(
|
|
div()
|
|
.absolute()
|
|
.top_0()
|
|
.left_0()
|
|
.size_full()
|
|
.border_b_1()
|
|
.border_color(cx.theme().colors().border),
|
|
)
|
|
.child(
|
|
h_flex()
|
|
.id("tabs")
|
|
.flex_grow()
|
|
.overflow_x_scroll()
|
|
.when_some(self.scroll_handle, |cx, scroll_handle| {
|
|
cx.track_scroll(&scroll_handle)
|
|
})
|
|
.children(self.children),
|
|
),
|
|
)
|
|
.when(!self.end_children.is_empty(), |this| {
|
|
this.child(
|
|
h_flex()
|
|
.flex_none()
|
|
.gap(DynamicSpacing::Base04.rems(cx))
|
|
.px(DynamicSpacing::Base06.rems(cx))
|
|
.border_b_1()
|
|
.border_l_1()
|
|
.border_color(cx.theme().colors().border)
|
|
.children(self.end_children),
|
|
)
|
|
})
|
|
}
|
|
}
|