ZIm/crates/assistant_tools/src
Bennet Bo Fenner 9e38c45a9b
agent: Show which lines were read when using read_file tool (#28077)
This makes sure that we specify which lines the agent actually read,
avoids confusing scenarios such as:

<img width="642" alt="Screenshot 2025-04-04 at 10 22 10"
src="https://github.com/user-attachments/assets/2680c313-4f77-4971-8743-8e3f5327c18d"
/>

Here the agent starts out by actually only reading a certain amount of
lines when the first tool call happens, then it does a second tool call
to read the whole file. To the user this looks like to identical tool
calls.

Now:
<img width="621" alt="image"
src="https://github.com/user-attachments/assets/76222258-9cc8-4b7c-98c0-6d5cffb282f2"
/>
<img width="362" alt="image"
src="https://github.com/user-attachments/assets/293f2fc0-365d-4b84-8400-4c11474caeb8"
/>
<img width="420" alt="image"
src="https://github.com/user-attachments/assets/ca92493e-67ce-4d45-8f83-0168df575326"
/>



Release Notes:

- N/A
2025-04-04 09:40:05 +00:00
..
bash_tool bash tool: Rename working_directory to cd and improve command wrap (#26702) 2025-03-13 18:29:25 +00:00
batch_tool Add Batch tool call for calling multiple tools (#27621) 2025-03-27 18:21:26 -04:00
code_symbols_tool Add Code Symbols tool (#27733) 2025-03-31 05:13:13 +00:00
copy_path_tool Add copy-path tool (#27371) 2025-03-24 21:21:55 -04:00
create_directory_tool Add Create Directory Tool (#27505) 2025-03-26 11:59:03 -04:00
create_file_tool Add create-file-tool (#27381) 2025-03-25 10:56:41 -04:00
delete_path_tool Delete tool uses paths instead of globs (#26715) 2025-03-16 11:58:25 +01:00
diagnostics_tool assistant2: Change system prompt to discourage doom loops (#27781) 2025-03-31 14:03:47 +00:00
edit_files_tool chore: Bump Rust edition to 2024 (#27800) 2025-03-31 20:55:27 +02:00
fetch_tool assistant_tools: Add fetch tool (#26999) 2025-03-18 16:25:51 +00:00
find_replace_tool assistant2: Fail find-replace tool if both strings are equal (#27783) 2025-03-31 14:23:46 +00:00
list_directory_tool Add ListDirectoryTool (#26549) 2025-03-12 15:17:12 +00:00
move_path_tool Add move_path tool (#27366) 2025-03-24 14:45:19 +00:00
open_tool Add Open Tool (#27499) 2025-03-27 18:20:59 -04:00
path_search_tool Paginate regex and path search tools (#26997) 2025-03-18 15:44:41 +00:00
read_file_tool Remove list_worktrees and use relative paths instead (#26546) 2025-03-12 15:06:04 +00:00
regex_search_tool Add symbol info tool (#27742) 2025-03-31 00:23:03 -04:00
symbol_info_tool Add symbol info tool (#27742) 2025-03-31 00:23:03 -04:00
thinking_tool Add thinking tool (#26675) 2025-03-14 16:26:22 -04:00
assistant_tools.rs Add tool calling support for Gemini models (#27772) 2025-03-31 17:46:42 +02:00
bash_tool.rs agent: Improve action confirmation UX (#27932) 2025-04-02 17:40:49 +00:00
batch_tool.rs assistant2: Use snake_case for tool names (#27903) 2025-04-02 12:17:58 +02:00
code_symbol_iter.rs Add Code Symbols tool (#27733) 2025-03-31 05:13:13 +00:00
code_symbols_tool.rs assistant2: Use snake_case for tool names (#27903) 2025-04-02 12:17:58 +02:00
copy_path_tool.rs assistant2: Use snake_case for tool names (#27903) 2025-04-02 12:17:58 +02:00
create_directory_tool.rs assistant2: Use snake_case for tool names (#27903) 2025-04-02 12:17:58 +02:00
create_file_tool.rs Avoid requiring confirmation for tools that edit buffers (#27923) 2025-04-02 15:13:16 +00:00
delete_path_tool.rs assistant2: Use snake_case for tool names (#27903) 2025-04-02 12:17:58 +02:00
diagnostics_tool.rs assistant2: Adjust icons for some tools (#27814) 2025-03-31 20:12:51 -03:00
edit_files_tool.rs Avoid requiring confirmation for tools that edit buffers (#27923) 2025-04-02 15:13:16 +00:00
fetch_tool.rs chore: Bump Rust edition to 2024 (#27800) 2025-03-31 20:55:27 +02:00
find_replace_file_tool.rs Avoid requiring confirmation for tools that edit buffers (#27923) 2025-04-02 15:13:16 +00:00
list_directory_tool.rs assistant2: Use snake_case for tool names (#27903) 2025-04-02 12:17:58 +02:00
move_path_tool.rs assistant2: Use snake_case for tool names (#27903) 2025-04-02 12:17:58 +02:00
now_tool.rs chore: Bump Rust edition to 2024 (#27800) 2025-03-31 20:55:27 +02:00
open_tool.rs assistant2: Adjust icons for some tools (#27814) 2025-03-31 20:12:51 -03:00
path_search_tool.rs assistant2: Use snake_case for tool names (#27903) 2025-04-02 12:17:58 +02:00
read_file_tool.rs agent: Show which lines were read when using read_file tool (#28077) 2025-04-04 09:40:05 +00:00
regex_search_tool.rs assistant2: Use snake_case for tool names (#27903) 2025-04-02 12:17:58 +02:00
replace.rs Improve tracking for agent edits (#27857) 2025-04-01 22:13:28 +00:00
schema.rs chore: Bump Rust edition to 2024 (#27800) 2025-03-31 20:55:27 +02:00
symbol_info_tool.rs assistant2: Use snake_case for tool names (#27903) 2025-04-02 12:17:58 +02:00
thinking_tool.rs chore: Bump Rust edition to 2024 (#27800) 2025-03-31 20:55:27 +02:00