
We're doing it. Svelte support is moving into an extension. This PR fixes some issues that came up along the way. Notes * extensions need to be able to retrieve the path the `node` binary installed by Zed * previously we were silently swallowing any errors that occurred while loading a grammar * npm commands ran by extensions weren't run in the right directory * Tree-sitter's WASM stdlib didn't support a C function (`strncmp`) needed by the Svelte parser's external scanner * the way that LSP installation status was reported was unnecessarily complex Release Notes: - Removed built-in support for the Svelte and Gleam languages, because full support for those languages is now available via extensions. These extensions will be suggested for download when you open a `.svelte` or `.gleam` file. --------- Co-authored-by: Marshall <marshall@zed.dev>
126 lines
3.6 KiB
Rust
126 lines
3.6 KiB
Rust
use std::{env, fs};
|
|
use zed_extension_api::{self as zed, Result};
|
|
|
|
struct SvelteExtension {
|
|
did_find_server: bool,
|
|
}
|
|
|
|
const SERVER_PATH: &str = "node_modules/svelte-language-server/bin/server.js";
|
|
const PACKAGE_NAME: &str = "svelte-language-server";
|
|
|
|
impl SvelteExtension {
|
|
fn server_exists(&self) -> bool {
|
|
fs::metadata(SERVER_PATH).map_or(false, |stat| stat.is_file())
|
|
}
|
|
|
|
fn server_script_path(&mut self, config: zed::LanguageServerConfig) -> Result<String> {
|
|
let server_exists = self.server_exists();
|
|
if self.did_find_server && server_exists {
|
|
return Ok(SERVER_PATH.to_string());
|
|
}
|
|
|
|
zed::set_language_server_installation_status(
|
|
&config.name,
|
|
&zed::LanguageServerInstallationStatus::CheckingForUpdate,
|
|
);
|
|
let version = zed::npm_package_latest_version(PACKAGE_NAME)?;
|
|
|
|
if !server_exists
|
|
|| zed::npm_package_installed_version(PACKAGE_NAME)?.as_ref() != Some(&version)
|
|
{
|
|
zed::set_language_server_installation_status(
|
|
&config.name,
|
|
&zed::LanguageServerInstallationStatus::Downloading,
|
|
);
|
|
let result = zed::npm_install_package(PACKAGE_NAME, &version);
|
|
match result {
|
|
Ok(()) => {
|
|
if !self.server_exists() {
|
|
Err(format!(
|
|
"installed package '{PACKAGE_NAME}' did not contain expected path '{SERVER_PATH}'",
|
|
))?;
|
|
}
|
|
}
|
|
Err(error) => {
|
|
if !self.server_exists() {
|
|
Err(error)?;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
self.did_find_server = true;
|
|
Ok(SERVER_PATH.to_string())
|
|
}
|
|
}
|
|
|
|
impl zed::Extension for SvelteExtension {
|
|
fn new() -> Self {
|
|
Self {
|
|
did_find_server: false,
|
|
}
|
|
}
|
|
|
|
fn language_server_command(
|
|
&mut self,
|
|
config: zed::LanguageServerConfig,
|
|
_: &zed::Worktree,
|
|
) -> Result<zed::Command> {
|
|
let server_path = self.server_script_path(config)?;
|
|
Ok(zed::Command {
|
|
command: zed::node_binary_path()?,
|
|
args: vec![
|
|
env::current_dir()
|
|
.unwrap()
|
|
.join(&server_path)
|
|
.to_string_lossy()
|
|
.to_string(),
|
|
"--stdio".to_string(),
|
|
],
|
|
env: Default::default(),
|
|
})
|
|
}
|
|
|
|
fn language_server_initialization_options(
|
|
&mut self,
|
|
_: zed::LanguageServerConfig,
|
|
_: &zed::Worktree,
|
|
) -> Result<Option<String>> {
|
|
let config = r#"{
|
|
"inlayHints": {
|
|
"parameterNames": {
|
|
"enabled": "all",
|
|
"suppressWhenArgumentMatchesName": false
|
|
},
|
|
"parameterTypes": {
|
|
"enabled": true
|
|
},
|
|
"variableTypes": {
|
|
"enabled": true,
|
|
"suppressWhenTypeMatchesName": false
|
|
},
|
|
"propertyDeclarationTypes": {
|
|
"enabled": true
|
|
},
|
|
"functionLikeReturnType": {
|
|
"enabled": true
|
|
},
|
|
"enumMemberValues": {
|
|
"enabled": true
|
|
}
|
|
}
|
|
}"#;
|
|
|
|
Ok(Some(format!(
|
|
r#"{{
|
|
"provideFormatter": true,
|
|
"configuration": {{
|
|
"typescript": {config},
|
|
"javascript": {config}
|
|
}}
|
|
}}"#
|
|
)))
|
|
}
|
|
}
|
|
|
|
zed::register_extension!(SvelteExtension);
|