ZIm/crates/git_ui/src
Michael Sloan 681c88d4e7
Fix clicking in to agent message editor and tighten up vertical spacing (#32765)
* Adds `min_lines` to `EditorMode::AutoHeight` and use `min_lines: 4` in
agent message editor. This makes it so that clicks in the blank space
below the first line of the editor also focus it, instead of needing to
click the very first line.

* Removes the div wrapping the editor, as it was only there to set
`min_h_16()`. This also tightens up the min space given to the editor -
before it was not evenly dividing the number of lines.

* Further tightens up vertical spacing by using `gap_1` instead of
`gap_4` between editor and controls below

At 4 line min height (after on the left, before on the right):


![image](https://github.com/user-attachments/assets/e8eefb1b-9ea3-4f98-ad55-25f95760d61f)

At 5 lines, one more than min height (after on the left, before on the
right):


![image](https://github.com/user-attachments/assets/a6ba737c-6a56-4343-a55a-d264f2a06377)

Release Notes:

- Agent: Fixed clicking to focus the message editor to also work for
clicks below the last line.
2025-06-15 18:45:44 +00:00
..
askpass_modal.rs chore: Bump Rust edition to 2024 (#27800) 2025-03-31 20:55:27 +02:00
blame_ui.rs editor: Move blame popover from hover_tooltip to editor prepaint (#29320) 2025-04-25 01:52:24 +05:30
branch_picker.rs git_ui: Replace spaces with hyphens in new branch names (#27873) 2025-05-27 17:10:20 +00:00
commit_message_prompt.txt git_ui: Try to prompt the model out of including the diff output (#26281) 2025-03-07 15:05:35 +00:00
commit_modal.rs Use git config --global user.email for email address in automatic Co-authored-by (#32624) 2025-06-12 19:39:08 +00:00
commit_tooltip.rs editor: Move blame popover from hover_tooltip to editor prepaint (#29320) 2025-04-25 01:52:24 +05:30
commit_view.rs Use anyhow more idiomatically (#31052) 2025-05-20 23:06:07 +00:00
conflict_view.rs Refine styling of merge conflicts (#31012) 2025-06-09 19:03:19 +00:00
git_panel.rs Fix clicking in to agent message editor and tighten up vertical spacing (#32765) 2025-06-15 18:45:44 +00:00
git_panel_settings.rs Git tweaks (#28791) 2025-04-28 23:42:23 -06:00
git_ui.rs Add git: open modified files action (#32347) 2025-06-12 13:56:10 -04:00
onboarding.rs chore: Bump Rust edition to 2024 (#27800) 2025-03-31 20:55:27 +02:00
picker_prompt.rs git: Pick which remote to fetch (#26897) 2025-06-06 11:28:07 -04:00
project_diff.rs Don't autosave unmodified buffers (#32626) 2025-06-12 22:12:14 +00:00
remote_output.rs git: Pick which remote to fetch (#26897) 2025-06-06 11:28:07 -04:00
repository_selector.rs chore: Bump Rust edition to 2024 (#27800) 2025-03-31 20:55:27 +02:00