ZIm/crates/remote/src
Kirill Bulatov 16366cf9f2
Use anyhow more idiomatically (#31052)
https://github.com/zed-industries/zed/issues/30972 brought up another
case where our context is not enough to track the actual source of the
issue: we get a general top-level error without inner error.

The reason for this was `.ok_or_else(|| anyhow!("failed to read HEAD
SHA"))?; ` on the top level.

The PR finally reworks the way we use anyhow to reduce such issues (or
at least make it simpler to bubble them up later in a fix).
On top of that, uses a few more anyhow methods for better readability.

* `.ok_or_else(|| anyhow!("..."))`, `map_err` and other similar error
conversion/option reporting cases are replaced with `context` and
`with_context` calls
* in addition to that, various `anyhow!("failed to do ...")` are
stripped with `.context("Doing ...")` messages instead to remove the
parasitic `failed to` text
* `anyhow::ensure!` is used instead of `if ... { return Err(...); }`
calls
* `anyhow::bail!` is used instead of `return Err(anyhow!(...));`

Release Notes:

- N/A
2025-05-20 23:06:07 +00:00
..
json_log.rs Improve ssh remote error handling and logging (#15035) 2024-07-23 13:29:56 -07:00
protocol.rs Fix flakey SSH connection (#19439) 2024-10-18 15:41:43 -07:00
proxy.rs remote server: Do not spawn server when proxy reconnects (#18864) 2024-10-09 16:51:12 +02:00
remote.rs ssh remote: Handle disconnect on project and show overlay (#19014) 2024-10-10 12:59:09 +02:00
ssh_session.rs Use anyhow more idiomatically (#31052) 2025-05-20 23:06:07 +00:00