Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
ZIm/crates
History
Richard Feldman bc4bd2e168
Don't conservatively include Suggest Edits token in token count (#20180) 
Before: (note the 1.3k in the upper right corner instead of 3 in the
second screenshot)

<img width="459" alt="Screenshot 2024-11-04 at 11 37 58 AM"
src="https://github.com/user-attachments/assets/64c06aff-f7d2-42a4-a767-0d7a4ba0f486">

Now:
<img width="631" alt="Screenshot 2024-11-04 at 11 38 11 AM"
src="https://github.com/user-attachments/assets/22af974d-915a-41e1-9ee0-f0622901e242">

This was intended to be a conservative estimate in case you pressed
Suggest Edits (and therefore might have an unpleasant surprise if you
were under the context limit but Suggest Edits failed with a "too much
context" error message anyway, after the Suggest Edits context got added
for you behind the scenes).

However, in retrospect this design created more [confusion in the common
case](https://github.com/zed-industries/zed/pull/19900#issuecomment-2453456569)
because it made it look like more context had been actually consumed
than what was actually consumed.

This does raise a potential design question for the future: the Suggest
Edits button adds more context at the last minute without ever
communicating that it's going to do that.

In the meantime it seems best to go back to the less-confusing way of
reporting the token counts, especially since only users of the
experimental flag could possibly press Suggest Edits anyway.

Release Notes:

- Fixed issue where initial token count was over-reported as 1.3k
instead of 3 (for the context string "You").
2024-11-04 15:40:10 -05:00
..
activity_indicator Rename extension crate to extension_host (#20081) 2024-11-01 12:53:02 -04:00
anthropic Switch to Anthropic -latest tags (#19615) 2024-10-23 15:13:52 -04:00
assets add ui::Vector and separate images from icons (#17815) 2024-09-13 17:44:16 -04:00
assistant Don't conservatively include Suggest Edits token in token count (#20180) 2024-11-04 15:40:10 -05:00
assistant_slash_command Adjust design of the slash command picker (#19973) 2024-10-30 19:42:42 -03:00
assistant_tool assistant: Add basic tool invocation (#17368) 2024-09-04 14:32:20 -04:00
audio Update Rust crate rodio to 0.19.0 (#17389) 2024-09-16 21:55:32 -06:00
auto_update Fail download if download fails (#19990) 2024-10-30 14:50:41 -07:00
breadcrumbs Add missing shortcuts in tooltips (#18282) 2024-09-27 11:06:48 +02:00
call Add new extension crate (#20089) 2024-11-01 13:20:30 -04:00
channel Remove hosted projects (#19754) 2024-10-27 19:44:21 -07:00
cli Remove dev servers (#19638) 2024-10-24 12:14:03 -06:00
client assistant: Add health telemetry (#19928) 2024-10-31 16:21:26 -07:00
clock Fix bugs with applying hunks from branch buffers (#18721) 2024-10-07 16:28:33 -07:00
collab Migration to remove dev servers (#19639) 2024-10-30 11:55:55 -06:00
collab_ui Fix mouse clicks on remote-open-folder UI (#19851) 2024-10-28 12:55:55 -07:00
collections gpui: Add SVG rendering to img element and generic asset cache (#9931) 2024-03-29 17:09:49 -07:00
command_palette chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
command_palette_hooks chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
context_servers context_servers: Support tools (#19548) 2024-10-28 10:37:58 -04:00
copilot copilot: Add support for new models (#19968) 2024-11-04 10:55:20 +01:00
db chore: Fix some violations of 'needless_pass_by_ref_mut' lint (#18795) 2024-10-07 01:29:58 +02:00
dev_server_projects/src Remove dev servers (#19638) 2024-10-24 12:14:03 -06:00
diagnostics diagnostics: Improve performance with large # of diagnostics (#20189) 2024-11-04 12:16:02 -07:00
docs_preprocessor Don't rely on relative path for docs preprocessor (#16883) 2024-08-26 11:43:13 -04:00
editor Fix two auto-indent issues with Markdown and YAML (#20193) 2024-11-04 12:29:38 -08:00
evals Restore HTTP client transition, but use reqwest everywhere (#19055) 2024-10-11 14:58:58 -07:00
extension Add new extension crate (#20089) 2024-11-01 13:20:30 -04:00
extension_api extension: Add support for labelDetails for LSP completions (#20144) 2024-11-04 11:02:19 -05:00
extension_cli Add new extension crate (#20089) 2024-11-01 13:20:30 -04:00
extension_host extension: Add support for labelDetails for LSP completions (#20144) 2024-11-04 11:02:19 -05:00
extensions_ui Rename extension crate to extension_host (#20081) 2024-11-01 12:53:02 -04:00
feature_flags Initial Notebook UI structure (#19756) 2024-10-29 11:30:07 -07:00
feedback Stop leaking isahc assumption (#18408) 2024-09-26 14:01:05 -06:00
file_finder Add more context to the save new file path picker (#19863) 2024-10-28 17:21:41 -07:00
file_icons chore: Clean up allocs around project panel (#15422) 2024-07-29 14:21:41 +02:00
fs Add support for git branches on remote projects (#19755) 2024-10-27 15:50:54 -07:00
fsevent Retain run loop (#11241) 2024-04-30 23:31:59 -06:00
fuzzy Improve slash commands (#16195) 2024-08-13 23:06:07 -07:00
git Make Git remote URL parsing more robust (#19924) 2024-10-29 16:19:05 -04:00
git_hosting_providers git_hosting_providers: Fix support for GitLab remotes containing subgroups (#19962) 2024-10-30 11:16:44 -04:00
go_to_line Take a mutable context when resolving selections (#19948) 2024-10-30 15:21:51 +01:00
google_ai Stop leaking isahc assumption (#18408) 2024-09-26 14:01:05 -06:00
gpui Fix saving files as *.sql on macOS Sequoia (#20195) 2024-11-04 13:23:59 -07:00
gpui_macros add ui::Vector and separate images from icons (#17815) 2024-09-13 17:44:16 -04:00
html_to_markdown chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
http_client Add settings to remote servers, use XDG paths on remote, and enable node LSPs (#19176) 2024-10-15 23:32:44 -07:00
image_viewer image viewer: Show path in breadcrumbs (#20155) 2024-11-04 10:18:21 +01:00
indexed_docs chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
inline_completion_button Support .editorconfig (#19455) 2024-10-21 13:05:30 +03:00
install_cli Fix flickering (#9012) 2024-03-11 10:45:57 +01:00
journal chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
language Fix two auto-indent issues with Markdown and YAML (#20193) 2024-11-04 12:29:38 -08:00
language_model copilot: Add support for new models (#19968) 2024-11-04 10:55:20 +01:00
language_selector use ssh lsp store (#17655) 2024-09-10 15:51:01 -04:00
language_tools Add KeyContextView (#19872) 2024-10-30 11:26:54 -06:00
languages Fix two auto-indent issues with Markdown and YAML (#20193) 2024-11-04 12:29:38 -08:00
live_kit_client chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
live_kit_server Restore HTTP client transition, but use reqwest everywhere (#19055) 2024-10-11 14:58:58 -07:00
lsp Fix a few Windows tests (#19773) 2024-10-26 03:32:22 +03:00
markdown Fix clang popovers (#20090) 2024-11-01 13:28:34 -06:00
markdown_preview markdown preview: Refresh preview when file is changed outside of the editor (#20175) 2024-11-04 17:23:32 +01:00
media Update Rust crate bindgen to 0.70.0 (#17024) 2024-08-28 22:12:49 -07:00
menu open picker (#14524) 2024-07-15 17:04:15 -06:00
multi_buffer Expand selections to Replace block boundaries (#20092) 2024-11-01 16:10:19 -04:00
node_runtime Make python run local worktree LSPs (#18353) 2024-09-25 12:45:41 -07:00
notifications Pass Summary::Context to Item::summarize (#18510) 2024-09-29 10:30:48 -06:00
ollama Fix read timeout for ollama (#18417) 2024-09-27 00:36:17 -06:00
open_ai Stop leaking isahc assumption (#18408) 2024-09-26 14:01:05 -06:00
outline Extract outline rendering to outline crate (#20179) 2024-11-04 11:54:37 -05:00
outline_panel Extract outline rendering to outline crate (#20179) 2024-11-04 11:54:37 -05:00
paths Support .editorconfig (#19455) 2024-10-21 13:05:30 +03:00
picker Add more context to the save new file path picker (#19863) 2024-10-28 17:21:41 -07:00
prettier Log prettier errors on failures (#19951) 2024-10-30 14:49:47 +02:00
project Fix file reloading not populating the history (#20156) 2024-11-04 11:30:15 +02:00
project_panel project panel: Focus editor when single-clicking on file and preview tabs are disabled (#20154) 2024-11-04 10:02:55 +01:00
project_symbols Fix renames over language server for SSH remoting (#17897) 2024-09-16 16:20:17 -06:00
proto proto: Remove unused UpdateUserSettings message (#20005) 2024-10-31 09:36:18 +01:00
quick_action_bar Add missing shortcuts in tooltips (#18282) 2024-09-27 11:06:48 +02:00
recent_projects recent projects: Fix inconsistent keybinding with which window is replaced or not (#20176) 2024-11-04 17:41:25 +01:00
refineable Move Clippy configuration to the workspace level (#8891) 2024-03-05 12:01:17 -05:00
release_channel chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
remote Remoting: Fix connecting to servers with long hostnames (#20093) 2024-11-01 13:52:21 -06:00
remote_server Remoting: Fix connecting to servers with long hostnames (#20093) 2024-11-01 13:52:21 -06:00
repl Clean up notebook item creation in project (#20030) 2024-10-31 07:01:46 -07:00
reqwest_client reqwest_client: Fix socks proxy settings (#19123) 2024-10-18 09:57:00 -07:00
rich_text Disable definition lists in Markdown (#17648) 2024-09-10 11:16:27 -04:00
rope Speed up point translation in the Rope (#19913) 2024-10-30 10:59:03 +01:00
rpc Add support for git branches on remote projects (#19755) 2024-10-27 15:50:54 -07:00
search vim: Add :noh[lsearch] (#20056) 2024-10-31 23:25:59 -06:00
semantic_index semantic_index: Disable embeddings index for non-staff (#19618) 2024-10-23 12:34:51 -04:00
semantic_version Extract SemanticVersion into its own crate (#9956) 2024-03-29 12:11:57 -04:00
session chore: Fix some violations of 'needless_pass_by_ref_mut' lint (#18795) 2024-10-07 01:29:58 +02:00
settings settings: Include null in the type for optional settings (#20192) 2024-11-04 14:25:44 -05:00
settings_ui Revert "theme: Turn ThemeRegistry into a trait (#20076)" (#20094) 2024-11-01 15:34:20 -04:00
snippet Correct escaping in snippets (#14912) 2024-07-22 00:57:34 +02:00
snippet_provider chore: Fix some violations of 'needless_pass_by_ref_mut' lint (#18795) 2024-10-07 01:29:58 +02:00
snippets_ui Add snippet commands (#18453) 2024-10-02 13:27:16 +02:00
sqlez Fix a rare crash on startup (#19922) 2024-10-29 12:30:55 -07:00
sqlez_macros Compare migrations formatted uniformly (#18760) 2024-10-05 12:58:45 +03:00
story chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
storybook Revert "theme: Turn ThemeRegistry into a trait (#20076)" (#20094) 2024-11-01 15:34:20 -04:00
sum_tree Speed up point translation in the Rope (#19913) 2024-10-30 10:59:03 +01:00
supermaven Cap the size of the Supermaven states buffer (#19246) 2024-10-23 10:36:14 +03:00
supermaven_api chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
tab_switcher tab_switcher: Use git-aware colors for file icons (#18733) 2024-10-04 10:37:41 -04:00
task tasks: Add editor: Spawn Nearest Task action (#19901) 2024-10-31 14:25:57 +01:00
tasks_ui Add more context to the save new file path picker (#19863) 2024-10-28 17:21:41 -07:00
telemetry_events assistant: Add health telemetry (#19928) 2024-10-31 16:21:26 -07:00
terminal ssh remoting: Fix wrong working directory for SSH terminals (#19672) 2024-10-24 13:52:26 +02:00
terminal_view terminal: Do not show multibuffer hint when in centered pane (#20137) 2024-11-04 09:19:48 +01:00
text Simplify line normalization (#19712) 2024-10-31 22:24:24 -06:00
theme Revert "theme: Turn ThemeRegistry into a trait (#20076)" (#20094) 2024-11-01 15:34:20 -04:00
theme_importer chore: Another round of style lints fixes (#17519) 2024-09-07 02:36:55 +02:00
theme_selector Revert "theme: Turn ThemeRegistry into a trait (#20076)" (#20094) 2024-11-01 15:34:20 -04:00
time_format chore: Fix several style lints (#17488) 2024-09-06 11:58:39 +02:00
title_bar ssh remoting: Hide share button while connecting to project (#19885) 2024-10-29 12:13:21 +01:00
toolchain_selector Add language toolchains (#19576) 2024-10-28 15:34:03 +01:00
ui gpui: Add scroll anchors (#19894) 2024-11-01 14:47:46 +01:00
ui_input Rename ui_text_field crate to ui_input (#13949) 2024-07-08 17:05:30 -04:00
ui_macros Add ui_macros crate & DerivePathStr derive macro (#17811) 2024-09-13 16:45:16 -04:00
util Add support for git branches on remote projects (#19755) 2024-10-27 15:50:54 -07:00
vcs_menu chore: Update BranchListDelegate to use WeakView<Workspace> (#20157) 2024-11-04 12:17:11 +02:00
vim Add surround aliases (#20104) 2024-11-04 09:03:27 -07:00
welcome Fix mouse clicks on remote-open-folder UI (#19851) 2024-10-28 12:55:55 -07:00
workspace Add pages to theme_preview (#20185) 2024-11-04 12:57:36 -05:00
worktree Add support for self-hosted GitLab instances for Git permalinks (#19909) 2024-10-29 12:31:51 -04:00
zed Revert "theme: Turn ThemeRegistry into a trait (#20076)" (#20094) 2024-11-01 15:34:20 -04:00
zed_actions Add KeyContextView (#19872) 2024-10-30 11:26:54 -06:00