ZIm/crates/util/src
Kirill Bulatov 16366cf9f2
Use anyhow more idiomatically (#31052)
https://github.com/zed-industries/zed/issues/30972 brought up another
case where our context is not enough to track the actual source of the
issue: we get a general top-level error without inner error.

The reason for this was `.ok_or_else(|| anyhow!("failed to read HEAD
SHA"))?; ` on the top level.

The PR finally reworks the way we use anyhow to reduce such issues (or
at least make it simpler to bubble them up later in a fix).
On top of that, uses a few more anyhow methods for better readability.

* `.ok_or_else(|| anyhow!("..."))`, `map_err` and other similar error
conversion/option reporting cases are replaced with `context` and
`with_context` calls
* in addition to that, various `anyhow!("failed to do ...")` are
stripped with `.context("Doing ...")` messages instead to remove the
parasitic `failed to` text
* `anyhow::ensure!` is used instead of `if ... { return Err(...); }`
calls
* `anyhow::bail!` is used instead of `return Err(anyhow!(...));`

Release Notes:

- N/A
2025-05-20 23:06:07 +00:00
..
test Fix Clippy warnings in util crate (#8721) 2024-03-02 13:06:35 -05:00
arc_cow.rs Rust 1.85 (#25272) 2025-02-28 18:33:35 +01:00
command.rs windows: Set CREATE_NO_WINDOW for commands (#18447) 2024-11-20 16:52:38 -08:00
fs.rs chore: Bump Rust edition to 2024 (#27800) 2025-03-31 20:55:27 +02:00
markdown.rs Refactor markdown formatting utilities to avoid building intermediate strings (#29511) 2025-04-27 19:04:51 +00:00
paths.rs Use anyhow more idiomatically (#31052) 2025-05-20 23:06:07 +00:00
serde.rs Track cumulative token usage in assistant2 when using anthropic API (#26738) 2025-03-13 22:56:16 +00:00
size.rs agent: Create TerminalToolCard and display shell output while it's running (#29546) 2025-04-29 16:06:43 +00:00
test.rs Canonicalize paths when running tests (#23655) 2025-01-26 14:56:07 +08:00
time.rs agent: Create TerminalToolCard and display shell output while it's running (#29546) 2025-04-29 16:06:43 +00:00
util.rs Use anyhow more idiomatically (#31052) 2025-05-20 23:06:07 +00:00