ZIm/crates/assistant2/src
Bennet Bo Fenner c929533e00
editor: Hide horizontal scrollbar if not visible (#23337)
This PR fixes two visual issues, that were caused by the fact that we
were always painting the horizontal scrollbar even if there is no
horizontal scrolling possible

Obscuring deleted lines when using the inline assistant:

https://github.com/user-attachments/assets/f8460c3f-403e-40a6-8622-65268ba2d875

Cutting off text even when horizontal scrolling is not possible:

https://github.com/user-attachments/assets/23c909f7-1c23-4693-8edc-40a2f089d4a8

This issue was only present in some themes (e.g. Nord, Catpuccin)


Closes #22716

Release Notes:

- Fixed an issue where horizontal scrollbars of editors would always be
painted (even if there is no horizontal scrolling to be done)
2025-01-18 21:50:07 +00:00
..
context_picker assistant2: Use notify_async_err for error notifications (#23330) 2025-01-18 21:10:22 +00:00
ui assistant2: Navigate context strip with keyboard (#23128) 2025-01-14 16:45:11 +00:00
active_thread.rs assistant2: Adjust "generating" state design (#23299) 2025-01-17 20:22:27 -03:00
assistant.rs assistant2: Thread history keyboard navigation (#23145) 2025-01-17 18:41:17 -03:00
assistant_model_selector.rs Dedupe AssistantSettings (#23190) 2025-01-15 18:52:54 +00:00
assistant_panel.rs assistant2: Adjust "generating" state design (#23299) 2025-01-17 20:22:27 -03:00
buffer_codegen.rs Add streaming_diff crate (#23264) 2025-01-16 23:12:46 +00:00
context.rs assistant2: Remove unneeded #[allow(unused)]s (#22979) 2025-01-10 19:05:08 +00:00
context_picker.rs assistant2: Use notify_async_err for error notifications (#23330) 2025-01-18 21:10:22 +00:00
context_store.rs assistant2: Make ContextStore::insert_* methods private (#22989) 2025-01-10 22:50:33 +00:00
context_strip.rs assistant2: Use notify_async_err for error notifications (#23330) 2025-01-18 21:10:22 +00:00
inline_assistant.rs editor: Hide horizontal scrollbar if not visible (#23337) 2025-01-18 21:50:07 +00:00
inline_prompt_editor.rs assistant2: Navigate context strip with keyboard (#23128) 2025-01-14 16:45:11 +00:00
message_editor.rs assistant2: Adjust "generating" state design (#23299) 2025-01-17 20:22:27 -03:00
terminal_codegen.rs Reuse prompt editor across buffer and terminal assist (#22188) 2024-12-18 16:12:54 -05:00
terminal_inline_assistant.rs Extract PromptStore and PromptBuilder to new prompt_library crate (#23254) 2025-01-16 20:06:16 +00:00
thread.rs assistant2: Cancel pending completion when an error occurs (#23143) 2025-01-14 19:04:47 +00:00
thread_history.rs assistant2: Thread history keyboard navigation (#23145) 2025-01-17 18:41:17 -03:00
thread_store.rs assistant2: Thread history keyboard navigation (#23145) 2025-01-17 18:41:17 -03:00
ui.rs assistant2: Sketch in sending file context to model (#21829) 2024-12-10 16:35:53 -05:00