ZIm/crates/collab/src
Cole Miller 1b6e212eba
debugger: Fix endless restarts when connecting to TCP adapters over SSH (#34328)
Closes #34323
Closes #34313

The previous PR #33932 introduced a way to "close" the
`pending_requests` buffer of the `TransportDelegate`, preventing any
more requests from being added. This prevents pending requests from
accumulating without ever being drained during the shutdown sequence;
without it, some of our tests hang at this point (due to using a
single-threaded executor).

The bug occurred because we were closing `pending_requests` whenever we
detected the server side of the transport shut down, and this closed
state stuck around and interfered with the retry logic for SSH+TCP
adapter connections.

This PR fixes the bug by only closing `pending_requests` on session
shutdown, and adds a regression test covering the SSH retry logic.

Release Notes:

- debugger: Fixed a bug causing SSH connections to some adapters
(Python, Go, JavaScript) to fail and restart endlessly.
2025-07-12 11:27:18 -04:00
..
api collab: Add logs to Stripe usage sync job (#33731) 2025-07-01 18:10:00 +00:00
bin windows: Make collab run on Windows (#23117) 2025-01-17 09:39:13 +02:00
db Delete access tokens on user delete (#34036) 2025-07-08 10:08:17 -04:00
llm Bypass account age check when feature flag is set (#32393) 2025-06-09 18:44:48 +02:00
rpc Use anyhow more idiomatically (#31052) 2025-05-20 23:06:07 +00:00
stripe_client collab: Add ability to add tax ID during Stripe Checkout (#34246) 2025-07-11 11:26:36 -04:00
tests debugger: Fix endless restarts when connecting to TCP adapters over SSH (#34328) 2025-07-12 11:27:18 -04:00
api.rs Update names of collab auth functions to clarify behavior (#32648) 2025-06-13 00:35:18 +00:00
auth.rs Use anyhow more idiomatically (#31052) 2025-05-20 23:06:07 +00:00
cents.rs Send llm events to snowflake too (#21091) 2024-11-22 20:40:39 -07:00
completion.rs Supermaven (#10788) 2024-05-03 12:50:42 -07:00
db.rs Never run transactions using serializable isolation (#33780) 2025-07-02 14:30:38 +00:00
env.rs Use anyhow more idiomatically (#31052) 2025-05-20 23:06:07 +00:00
errors.rs Remove more unused code related to GitHub auth and errors 2022-04-21 08:57:49 -06:00
executor.rs chore: Prepare for Rust edition bump to 2024 (without autofix) (#27791) 2025-03-31 20:10:36 +02:00
lib.rs Never run transactions using serializable isolation (#33780) 2025-07-02 14:30:38 +00:00
llm.rs Bypass account age check when feature flag is set (#32393) 2025-06-09 18:44:48 +02:00
main.rs Never run transactions using serializable isolation (#33780) 2025-07-02 14:30:38 +00:00
migrations.rs Use anyhow more idiomatically (#31052) 2025-05-20 23:06:07 +00:00
rpc.rs collab: Send down new usage limits even when the user does not have any usage (#34217) 2025-07-10 15:52:19 +00:00
seed.rs Update names of collab auth functions to clarify behavior (#32648) 2025-06-13 00:35:18 +00:00
stripe_billing.rs collab: Add ability to add tax ID during Stripe Checkout (#34246) 2025-07-11 11:26:36 -04:00
stripe_client.rs collab: Add ability to add tax ID during Stripe Checkout (#34246) 2025-07-11 11:26:36 -04:00
tests.rs collab: Introduce StripeClient trait to abstract over Stripe interactions (#31615) 2025-05-28 18:34:44 +00:00
user_backfiller.rs Update names of collab auth functions to clarify behavior (#32648) 2025-06-13 00:35:18 +00:00