Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
ZIm/crates/ui/src/components/stories
History
Marshall Bowers 1cc7f66f86
Fix documentation labels obscuring other content in completion menu (#4167) 
This PF fixes an issue where the documentation labels in the completion
menu could end up completing obscuring the primary content.

#### Before
<img width="691" alt="Screenshot 2024-01-19 at 1 42 19 PM"
src="https://github.com/zed-industries/zed/assets/1486634/187f2978-08be-4f5e-ba93-91ed09cd6e87">

#### After

<img width="704" alt="Screenshot 2024-01-19 at 1 39 45 PM"
src="https://github.com/zed-industries/zed/assets/1486634/e5929c04-bace-4336-b878-4ada5660d235">

Since this involved changes to the `ListItem`, I also made sure to test
the other problematic case that was fixed in #3845 to make sure we
didn't regress there:

<img width="665" alt="Screenshot 2024-01-19 at 1 39 11 PM"
src="https://github.com/zed-industries/zed/assets/1486634/14b72d44-b6a6-4aef-a708-37fb60b8875a">

I also tried to capture these cases in the `ListItem` stories to make it
easier to test all of them at once:

<img width="1141" alt="Screenshot 2024-01-19 at 1 40 03 PM"
src="https://github.com/zed-industries/zed/assets/1486634/333886ff-e394-4cba-89db-98352481c7f6">

Release Notes:

- Fixed an issue where documentation labels could obscure other content
in the editor completion menu
([#2419](https://github.com/zed-industries/community/issues/2419)).
2024-01-19 14:01:09 -05:00
..
avatar.rs Increase border width used to indicate speaking (#4077) 2024-01-16 17:09:28 -05:00
button.rs Rename IconElement to just Icon (#3974) 2024-01-09 10:11:20 -05:00
checkbox.rs Rename h_stack and v_stack to h_flex and v_flex, respectively (#4053) 2024-01-15 11:34:06 -05:00
context_menu.rs Remove 2 suffix for ui, storybook, text 2024-01-03 12:33:51 -08:00
disclosure.rs Remove 2 suffix for ui, storybook, text 2024-01-03 12:33:51 -08:00
icon.rs Rename IconElement to just Icon (#3974) 2024-01-09 10:11:20 -05:00
icon_button.rs Fix file paths in stories (#4104) 2024-01-17 16:59:57 -05:00
keybinding.rs Remove 2 suffix for ui, storybook, text 2024-01-03 12:33:51 -08:00
label.rs Remove 2 suffix for ui, storybook, text 2024-01-03 12:33:51 -08:00
list.rs Remove 2 suffix for ui, storybook, text 2024-01-03 12:33:51 -08:00
list_header.rs Rename IconElement to just Icon (#3974) 2024-01-09 10:11:20 -05:00
list_item.rs Fix documentation labels obscuring other content in completion menu (#4167) 2024-01-19 14:01:09 -05:00
tab.rs Rename h_stack and v_stack to h_flex and v_flex, respectively (#4053) 2024-01-15 11:34:06 -05:00
tab_bar.rs Rename h_stack and v_stack to h_flex and v_flex, respectively (#4053) 2024-01-15 11:34:06 -05:00
toggle_button.rs Fix file paths in stories (#4104) 2024-01-17 16:59:57 -05:00