9ee5dd7568
Closes #33510 https://github.com/zed-extensions/php/issues/29 If certain language servers do not provide an insert/replace range, we use `surrounding_word` as a fallback for that range, which internally uses `word_characters`. It makes sense to use `completion_query_characters` instead of `word_characters` to get that range, because we use `completion_query_characters` to query completions in the first place. That means, for some hypothetical reason (e.g., if the Tailwind server stops providing insert/replace ranges), we would correctly fall back to the range "bg-blue-200^" instead of "200^", because `completion_query_characters` includes "-" in this case. For this particular fix, right now the default PHP language server `phpactor` does not provide an insert/replace range, and hence completion query character is used, which is `$` in this case. Note that `$` isn't in word characters for reasons mentioned here: https://github.com/zed-extensions/php/issues/14 Release Notes: - Fixed an issue where accepting variable completion in PHP would result in a double $ sign in the prefix. |
||
|---|---|---|
| .. | ||
| syntax_map | ||
| buffer.rs | ||
| buffer_tests.rs | ||
| diagnostic_set.rs | ||
| highlight_map.rs | ||
| language.rs | ||
| language_registry.rs | ||
| language_settings.rs | ||
| manifest.rs | ||
| outline.rs | ||
| proto.rs | ||
| syntax_map.rs | ||
| task_context.rs | ||
| text_diff.rs | ||
| toolchain.rs | ||